[PATCH v4 0/5] Add onboard-dev USB hub host managed vbus handling support

[PATCH v4 0/5] Add onboard-dev USB hub host managed vbus handling support

[Marco Felsch]

Hi,

the whole purpose of this series is to make it possible to control the
USB VBUS regulators of an USB hub via host managed regulators.

Regards,
  Marco

---
Changes in v4:
- dt-bindings: change to vbus-supply and shift doc to usb-device.yaml
- onboard_dev: make use of new regulator API to parse child device
               regulators.
- onboard_dev: drop hard coded downstream port number and make it more
               dynamic
- onboard_dev: drop limiting support to SMSC hubs
- Link to v3: https://lore.kernel.org/r/20250821-v6-16-topic-usb-onboard-dev-v3-0-6d2b38a5d818@pengutronix.de

Changes in v3:
- fix dt-bindings issues
- Link to v2: https://lore.kernel.org/all/20250327172803.3404615-1-m.felsch@pengutronix.de/

Changes in v2:
- fix compile time errors in case the module builds
- Link to v1: https://lore.kernel.org/all/20240807-b4-v6-10-topic-usb-onboard-dev-v1-0-f33ce21353c9@pengutronix.de/

---
Marco Felsch (5):
      usb: port: track the disabled state
      usb: hub: add infrastructure to pass onboard_dev port features
      dt-bindings: usb: usb-device: add usb hub port vbus-supply suppport
      dt-bindings: usb: microchip,usb2514: add vbus-supply example
      usb: misc: onboard_dev: add hub downstream port host vbus-supply handling

 .../devicetree/bindings/usb/microchip,usb2514.yaml |   7 ++
 .../devicetree/bindings/usb/usb-device.yaml        |   6 ++
 drivers/usb/core/hub.c                             |  55 +++++++++-
 drivers/usb/core/hub.h                             |   4 +
 drivers/usb/core/port.c                            |   6 ++
 drivers/usb/misc/onboard_usb_dev.c                 | 117 +++++++++++++++++++++
 include/linux/usb.h                                |   3 +
 7 files changed, 196 insertions(+), 2 deletions(-)
---
base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
change-id: 20250821-v6-16-topic-usb-onboard-dev-b8d4d1d8a086

Best regards,
-- 
Marco Felsch <m.felsch@pengutronix.de>

[PATCH v4 1/5] usb: port: track the disabled state

[Marco Felsch]

The disable state isn't tracked at the moment, instead the state is
directly passed to the hub driver. Change this behavior to only trigger
the hub if a state change happened. Exit early in case of no state
changes but don't return an error.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/usb/core/hub.h  | 2 ++
 drivers/usb/core/port.c | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/drivers/usb/core/hub.h b/drivers/usb/core/hub.h
index 9ebc5ef54a325d63e01b0deb59a1853d2b13c8d5..297adf2c6078809ca582104f228e5222c464f999 100644
--- a/drivers/usb/core/hub.h
+++ b/drivers/usb/core/hub.h
@@ -97,6 +97,7 @@ struct usb_hub {
  * @usb3_lpm_u2_permit: whether USB3 U2 LPM is permitted.
  * @early_stop: whether port initialization will be stopped earlier.
  * @ignore_event: whether events of the port are ignored.
+ * @disabled: whether the port is disabled
  */
 struct usb_port {
 	struct usb_device *child;
@@ -118,6 +119,7 @@ struct usb_port {
 	unsigned int is_superspeed:1;
 	unsigned int usb3_lpm_u1_permit:1;
 	unsigned int usb3_lpm_u2_permit:1;
+	unsigned int disabled:1;
 };
 
 #define to_usb_port(_dev) \
diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c
index f54198171b6a3fb49c5f74f4a8a303b422d099eb..cae08a9a71e65c42fb9a8f5369060bd82b8daebb 100644
--- a/drivers/usb/core/port.c
+++ b/drivers/usb/core/port.c
@@ -117,6 +117,10 @@ static ssize_t disable_store(struct device *dev, struct device_attribute *attr,
 	if (rc)
 		return rc;
 
+	/* Early quit if no change was detected */
+	if (port_dev->disabled == disabled)
+		return count;
+
 	hub_get(hub);
 	rc = usb_autopm_get_interface(intf);
 	if (rc < 0)
@@ -148,6 +152,8 @@ static ssize_t disable_store(struct device *dev, struct device_attribute *attr,
 			usb_clear_port_feature(hdev, port1, USB_PORT_FEAT_C_ENABLE);
 	}
 
+	port_dev->disabled = disabled;
+
 	if (!rc)
 		rc = count;
 

-- 
2.47.3

[PATCH v4 2/5] usb: hub: add infrastructure to pass onboard_dev port features

[Marco Felsch]

On board devices may require special handling for en-/disable port
features due to PCB design decisions e.g. enable/disable the VBUS power
on the port via a host controlled regulator or GPIO.

This commit adds the necessary infrastructure to prepare the common code
base for such use-cases.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/usb/core/hub.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++--
 drivers/usb/core/hub.h |  2 ++
 include/linux/usb.h    |  3 +++
 3 files changed, 58 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 256fe8c86828d51c33442345acdb7f3fe80a98ce..50ae500e2ad3711996609fc84806803449a5bf16 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -457,9 +457,19 @@ static int clear_hub_feature(struct usb_device *hdev, int feature)
  */
 int usb_clear_port_feature(struct usb_device *hdev, int port1, int feature)
 {
-	return usb_control_msg(hdev, usb_sndctrlpipe(hdev, 0),
+	struct usb_hub *hub = usb_hub_to_struct_hub(hdev);
+	int ret;
+
+	ret = usb_control_msg(hdev, usb_sndctrlpipe(hdev, 0),
 		USB_REQ_CLEAR_FEATURE, USB_RT_PORT, feature, port1,
 		NULL, 0, 1000);
+	if (ret)
+		return ret;
+
+	if (hub->onboard_hub_clear_port_feature)
+		ret = hub->onboard_hub_clear_port_feature(hdev, feature, port1);
+
+	return ret;
 }
 
 /*
@@ -467,9 +477,19 @@ int usb_clear_port_feature(struct usb_device *hdev, int port1, int feature)
  */
 static int set_port_feature(struct usb_device *hdev, int port1, int feature)
 {
-	return usb_control_msg(hdev, usb_sndctrlpipe(hdev, 0),
+	struct usb_hub *hub = usb_hub_to_struct_hub(hdev);
+	int ret;
+
+	ret = usb_control_msg(hdev, usb_sndctrlpipe(hdev, 0),
 		USB_REQ_SET_FEATURE, USB_RT_PORT, feature, port1,
 		NULL, 0, 1000);
+	if (ret)
+		return ret;
+
+	if (hub->onboard_hub_set_port_feature)
+		ret = hub->onboard_hub_set_port_feature(hdev, feature, port1);
+
+	return ret;
 }
 
 static char *to_led_name(int selector)
@@ -6544,6 +6564,37 @@ void usb_hub_adjust_deviceremovable(struct usb_device *hdev,
 	}
 }
 
+/**
+ * usb_hub_register_port_feature_hooks - Register port set/get feature hooks
+ * @hdev: USB device belonging to the usb hub
+ * @set_port_feature: set_feature hook which gets called by the hub core
+ * @clear_port_feature: clear_feature hook which gets called by the hub core
+ *
+ * Register set/get_port_feature hooks for a onboard_dev hub.
+ */
+void usb_hub_register_port_feature_hooks(struct usb_device *hdev,
+		int (*set_port_feature)(struct usb_device *, int, int),
+		int (*clear_port_feature)(struct usb_device *, int, int))
+{
+	struct usb_hub *hub = usb_hub_to_struct_hub(hdev);
+
+	if (WARN_ON_ONCE(is_root_hub(hdev) || !hub))
+		return;
+
+	if (set_port_feature)
+		hub->onboard_hub_set_port_feature = set_port_feature;
+	if (clear_port_feature)
+		hub->onboard_hub_clear_port_feature = clear_port_feature;
+
+	/*
+	 * Keep it simple for now. Just check the power state and re-sync it
+	 * after adding the hooks since the onboard-dev may do some additional
+	 * logic e.g. controlling regulators.
+	 */
+	hub_power_on(hub, false);
+}
+EXPORT_SYMBOL_GPL(usb_hub_register_port_feature_hooks);
+
 #ifdef CONFIG_ACPI
 /**
  * usb_get_hub_port_acpi_handle - Get the usb port's acpi handle
diff --git a/drivers/usb/core/hub.h b/drivers/usb/core/hub.h
index 297adf2c6078809ca582104f228e5222c464f999..31800b5922ba896dc7cac5f9e3ed1a77e7c5a801 100644
--- a/drivers/usb/core/hub.h
+++ b/drivers/usb/core/hub.h
@@ -76,6 +76,8 @@ struct usb_hub {
 	struct timer_list	irq_urb_retry;
 	struct usb_port		**ports;
 	struct list_head        onboard_devs;
+	int (*onboard_hub_set_port_feature)(struct usb_device *udev, int feature, int port1);
+	int (*onboard_hub_clear_port_feature)(struct usb_device *udev, int feature, int port1);
 };
 
 /**
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 92c752f5446ff37ef09b9296f7711e1a622680ea..1415a826953ac5488619073e2f659188f7988d6e 100644
--- a/include/linux/usb.h
+++ b/include/linux/usb.h
@@ -928,6 +928,9 @@ int usb_hub_claim_port(struct usb_device *hdev, unsigned port1,
 		struct usb_dev_state *owner);
 int usb_hub_release_port(struct usb_device *hdev, unsigned port1,
 		struct usb_dev_state *owner);
+void usb_hub_register_port_feature_hooks(struct usb_device *hdev,
+		int (*set_port_feature)(struct usb_device *, int, int),
+		int (*clear_port_feature)(struct usb_device *, int, int));
 
 /**
  * usb_make_path - returns stable device path in the usb tree

-- 
2.47.3

[PATCH v4 3/5] dt-bindings: usb: usb-device: add usb hub port vbus-supply suppport

[Marco Felsch]

Some PCB designs don't use the dedicated USB hub port power control GPIO
to control the port VBUS supply. Instead host managed GPIOs are used to
control the VBUS supply.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 Documentation/devicetree/bindings/usb/usb-device.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/usb-device.yaml b/Documentation/devicetree/bindings/usb/usb-device.yaml
index 09fceb469f10525e9dcdb91435b142b0d21964b8..2f891a05ab9bca095eb881c5f601ac27ac63b542 100644
--- a/Documentation/devicetree/bindings/usb/usb-device.yaml
+++ b/Documentation/devicetree/bindings/usb/usb-device.yaml
@@ -53,6 +53,12 @@ properties:
   "#size-cells":
     const: 0
 
+  vbus-supply:
+    description: USB hub port VBUS supply.
+      The host managed regulator which controlls the USB hub port VBUS. This
+      regulator is only required if the hub internal control signals aren't
+      used to control the VBUS regulators.
+
 patternProperties:
   "^interface@[0-9a-f]{1,2}(,[0-9a-f]{1,2})$":
     type: object

-- 
2.47.3

Re: [PATCH v4 3/5] dt-bindings: usb: usb-device: add usb hub port vbus-supply suppport

[Rob Herring]

On Thu, Sep 11, 2025 at 10:22:44PM +0200, Marco Felsch wrote:
> Some PCB designs don't use the dedicated USB hub port power control GPIO
> to control the port VBUS supply. Instead host managed GPIOs are used to
> control the VBUS supply.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/usb/usb-device.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-device.yaml b/Documentation/devicetree/bindings/usb/usb-device.yaml
> index 09fceb469f10525e9dcdb91435b142b0d21964b8..2f891a05ab9bca095eb881c5f601ac27ac63b542 100644
> --- a/Documentation/devicetree/bindings/usb/usb-device.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-device.yaml
> @@ -53,6 +53,12 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  vbus-supply:
> +    description: USB hub port VBUS supply.
> +      The host managed regulator which controlls the USB hub port VBUS. This

controls

With that,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

> +      regulator is only required if the hub internal control signals aren't
> +      used to control the VBUS regulators.
> +
>  patternProperties:
>    "^interface@[0-9a-f]{1,2}(,[0-9a-f]{1,2})$":
>      type: object
> 
> -- 
> 2.47.3
> 

[PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example

[Marco Felsch]

Add an usb hub vbus-supply example to make it easier for users to
understand the binding, after the usb-device.yaml gained the support for
it.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
index 4e3901efed3fcd4fbbd8cb777f9df4fcadf2ca00..9874bbd03e31fd7ff1c439eb860a15617f147406 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
@@ -86,5 +86,12 @@ examples:
                 compatible = "usbb95,772b";
                 reg = <1>;
             };
+
+            /* VBUS on the 2nd port is managed by the host */
+            ethernet@2 {
+                compatible = "usbb95,772b";
+                reg = <2>;
+                vbus-supply = <&reg_5v0_vbus>;
+            };
         };
     };

-- 
2.47.3

Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example

[Rob Herring (Arm)]

On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> Add an usb hub vbus-supply example to make it easier for users to
> understand the binding, after the usb-device.yaml gained the support for
> it.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250911-v6-16-topic-usb-onboard-dev-v4-4-1af288125d74@pengutronix.de

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example

[Marco Felsch]

On 25-09-11, Rob Herring (Arm) wrote:
> 
> On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> > Add an usb hub vbus-supply example to make it easier for users to
> > understand the binding, after the usb-device.yaml gained the support for
> > it.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#

Well this is just an example on how to use it, we can drop this patch of
course.

Regards,
  Marco

Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example

[Rob Herring]

On Fri, Sep 12, 2025 at 10:51:56AM +0200, Marco Felsch wrote:
> On 25-09-11, Rob Herring (Arm) wrote:
> > 
> > On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> > > Add an usb hub vbus-supply example to make it easier for users to
> > > understand the binding, after the usb-device.yaml gained the support for
> > > it.
> > > 
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > >  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> > 	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#
> 
> Well this is just an example on how to use it, we can drop this patch of
> course.

Yes, but how's it going to work for an actual user?

Rob

Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example

[Marco Felsch]

On 25-09-12, Rob Herring wrote:
> On Fri, Sep 12, 2025 at 10:51:56AM +0200, Marco Felsch wrote:
> > On 25-09-11, Rob Herring (Arm) wrote:
> > > 
> > > On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> > > > Add an usb hub vbus-supply example to make it easier for users to
> > > > understand the binding, after the usb-device.yaml gained the support for
> > > > it.
> > > > 
> > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > ---
> > > >  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > 
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> > > 	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#
> > 
> > Well this is just an example on how to use it, we can drop this patch of
> > course.
> 
> Yes, but how's it going to work for an actual user?

What do you mean? It's working as you requested:

  hub@1 {
  	compatible = "..";
	reg = <1>;

	device@1 {
		compatible = "..";
		reg = <1>;
		
		vbus-supply = <&vbus_supply_port1>;
	};

	device@4 {
		compatible = "..";
		reg = <4>;
		
		vbus-supply = <&vbus_supply_port4>;
	};
  };

> 
> Rob
> 

[PATCH v4 5/5] usb: misc: onboard_dev: add hub downstream port host vbus-supply handling

[Marco Felsch]

Some PCB designs don't use the dedicated USB hub port power GPIOs.
Instead they route the signals to the host. So the host is in charge to
power the VBUS supplies.

As first step the USB hub OF information is parsed and possible optional
vbus-supply regulators are added. This is done during the platform
driver probe() function.

Afterwards, during the usb driver probe() function and in case this is
an USB hub, the set/clear features hooks are registered via the new
usb_hub_register_port_feature_hooks().

After this registration all generic usb hub set/clear features calls are
passed to the onboard_dev driver too. This allows the driver to
en-/disable the regulators.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/usb/misc/onboard_usb_dev.c | 117 +++++++++++++++++++++++++++++++++++++
 1 file changed, 117 insertions(+)

diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
index 5b481876af1b2c10ce625fcf0fb8bfbe8905aa8c..1ceea75d30d320e5d2203c768b9641876ebd37ad 100644
--- a/drivers/usb/misc/onboard_usb_dev.c
+++ b/drivers/usb/misc/onboard_usb_dev.c
@@ -54,6 +54,12 @@ struct usbdev_node {
 	struct list_head list;
 };
 
+struct onboard_dev_port_regulator {
+	struct regulator *vbus_supply;
+	unsigned int port;
+	struct list_head list;
+};
+
 struct onboard_dev {
 	struct regulator_bulk_data supplies[MAX_SUPPLIES];
 	struct device *dev;
@@ -65,6 +71,7 @@ struct onboard_dev {
 	struct list_head udev_list;
 	struct mutex lock;
 	struct clk *clk;
+	struct list_head ext_vbus_supplies;
 };
 
 static int onboard_dev_get_regulators(struct onboard_dev *onboard_dev)
@@ -226,6 +233,71 @@ static int onboard_dev_add_usbdev(struct onboard_dev *onboard_dev,
 	return err;
 }
 
+static int onboard_dev_port_power(struct onboard_dev *onboard_dev, int port1,
+				  bool enable)
+{
+	struct onboard_dev_port_regulator *regulator;
+	struct regulator *vbus_supply = NULL;
+
+	list_for_each_entry(regulator, &onboard_dev->ext_vbus_supplies, list) {
+		if (regulator->port == port1) {
+			vbus_supply = regulator->vbus_supply;
+			break;
+		}
+	}
+
+	/* External supplies are optional, return no error */
+	if (!vbus_supply)
+		return 0;
+
+	if (enable)
+		return regulator_enable(vbus_supply);
+
+	return regulator_disable(vbus_supply);
+}
+
+static int onboard_dev_add_ext_vbus_supplies(struct onboard_dev *onboard_dev)
+{
+	struct device *dev = onboard_dev->dev;
+
+	if (!onboard_dev->pdata->is_hub)
+		return 0;
+
+	INIT_LIST_HEAD(&onboard_dev->ext_vbus_supplies);
+
+	for_each_child_of_node_scoped(dev->of_node, child) {
+		struct onboard_dev_port_regulator *regulator;
+		struct regulator *port_supply;
+		u32 port;
+
+		port_supply = devm_of_regulator_get_optional(dev, child, "vbus");
+		if (IS_ERR(port_supply)) {
+			if (PTR_ERR(port_supply) == -ENODEV)
+				continue;
+			return PTR_ERR(port_supply);
+		}
+
+		/*
+		 * The VBUS of this downstream port is controlled by a host
+		 * managed regulator
+		 */
+		if (of_property_read_u32(child, "reg", &port)) {
+			dev_err(dev, "Failed to parse USB device reg property\n");
+			return -EINVAL;
+		}
+
+		regulator = devm_kzalloc(dev, sizeof(*regulator), GFP_KERNEL);
+		if (!regulator)
+			return -ENOMEM;
+
+		regulator->vbus_supply = port_supply;
+		regulator->port = port;
+		list_add(&regulator->list, &onboard_dev->ext_vbus_supplies);
+	}
+
+	return 0;
+}
+
 static void onboard_dev_remove_usbdev(struct onboard_dev *onboard_dev,
 				      const struct usb_device *udev)
 {
@@ -460,6 +532,10 @@ static int onboard_dev_probe(struct platform_device *pdev)
 		return dev_err_probe(dev, PTR_ERR(onboard_dev->reset_gpio),
 				     "failed to get reset GPIO\n");
 
+	err = onboard_dev_add_ext_vbus_supplies(onboard_dev);
+	if (err)
+		return dev_err_probe(dev, err, "failed to parse port vbus supplies\n");
+
 	mutex_init(&onboard_dev->lock);
 	INIT_LIST_HEAD(&onboard_dev->udev_list);
 
@@ -573,6 +649,44 @@ static struct platform_driver onboard_dev_driver = {
 #define VENDOR_ID_VIA		0x2109
 #define VENDOR_ID_XMOS		0x20B1
 
+static int onboard_dev_port_feature(struct usb_device *udev, bool set,
+				    int feature, int port1)
+{
+	struct device *dev = &udev->dev;
+	struct onboard_dev *onboard_dev = dev_get_drvdata(dev);
+
+	/*
+	 * Check usb_hub_register_port_feature_hooks() if you want to extent
+	 * the list of handled features. At the moment only power is synced
+	 * after adding the hook.
+	 */
+	switch (feature) {
+	case USB_PORT_FEAT_POWER:
+		return onboard_dev_port_power(onboard_dev, port1, set);
+	default:
+		return 0;
+	}
+}
+
+static int
+onboard_dev_set_port_feature(struct usb_device *udev, int feature, int port1)
+{
+	return onboard_dev_port_feature(udev, true, feature, port1);
+}
+
+static int
+onboard_dev_clear_port_feature(struct usb_device *udev, int feature, int port1)
+{
+	return onboard_dev_port_feature(udev, false, feature, port1);
+}
+
+static void
+onboard_dev_register_hub_hooks(struct usb_device *udev)
+{
+	usb_hub_register_port_feature_hooks(udev, onboard_dev_set_port_feature,
+					    onboard_dev_clear_port_feature);
+}
+
 /*
  * Returns the onboard_dev platform device that is associated with the USB
  * device passed as parameter.
@@ -632,6 +746,9 @@ static int onboard_dev_usbdev_probe(struct usb_device *udev)
 
 	dev_set_drvdata(dev, onboard_dev);
 
+	if (onboard_dev->pdata->is_hub)
+		onboard_dev_register_hub_hooks(udev);
+
 	err = onboard_dev_add_usbdev(onboard_dev, udev);
 	if (err)
 		return err;

-- 
2.47.3

Re: [PATCH v4 0/5] Add onboard-dev USB hub host managed vbus handling support

[Ze Huang]

On Fri Sep 12, 2025 at 4:22 AM CST, Marco Felsch wrote:
> Hi,
>
> the whole purpose of this series is to make it possible to control the
> USB VBUS regulators of an USB hub via host managed regulators.
>
> Regards,
>   Marco
>
> ---
> Changes in v4:
> - dt-bindings: change to vbus-supply and shift doc to usb-device.yaml
> - onboard_dev: make use of new regulator API to parse child device
>                regulators.
> - onboard_dev: drop hard coded downstream port number and make it more
>                dynamic
> - onboard_dev: drop limiting support to SMSC hubs
> - Link to v3: https://lore.kernel.org/r/20250821-v6-16-topic-usb-onboard-dev-v3-0-6d2b38a5d818@pengutronix.de
>
> Changes in v3:
> - fix dt-bindings issues
> - Link to v2: https://lore.kernel.org/all/20250327172803.3404615-1-m.felsch@pengutronix.de/
>
> Changes in v2:
> - fix compile time errors in case the module builds
> - Link to v1: https://lore.kernel.org/all/20240807-b4-v6-10-topic-usb-onboard-dev-v1-0-f33ce21353c9@pengutronix.de/
>
> ---
> Marco Felsch (5):
>       usb: port: track the disabled state
>       usb: hub: add infrastructure to pass onboard_dev port features
>       dt-bindings: usb: usb-device: add usb hub port vbus-supply suppport
>       dt-bindings: usb: microchip,usb2514: add vbus-supply example
>       usb: misc: onboard_dev: add hub downstream port host vbus-supply handling
>
>  .../devicetree/bindings/usb/microchip,usb2514.yaml |   7 ++
>  .../devicetree/bindings/usb/usb-device.yaml        |   6 ++
>  drivers/usb/core/hub.c                             |  55 +++++++++-
>  drivers/usb/core/hub.h                             |   4 +
>  drivers/usb/core/port.c                            |   6 ++
>  drivers/usb/misc/onboard_usb_dev.c                 | 117 +++++++++++++++++++++
>  include/linux/usb.h                                |   3 +
>  7 files changed, 196 insertions(+), 2 deletions(-)
> ---
> base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> change-id: 20250821-v6-16-topic-usb-onboard-dev-b8d4d1d8a086
>
> Best regards,

Hi Marco,

I'm checking in to ask about the status of this patch series.

We are currently working on the Spacemit K1 SoC and we have a use case
that requires onboard_dev to manage the USB VBUS regulator. This series
would be very helpful for us :)

Link: https://lore.kernel.org/all/DG8QBWSJ79MP.2MVIHFRBX3WXX@linux.dev/

Best regards,
Ze Huang

Re: [PATCH v4 0/5] Add onboard-dev USB hub host managed vbus handling support

[Marco Felsch]

Hi,

On 26-02-10, Ze Huang wrote:
> On Fri Sep 12, 2025 at 4:22 AM CST, Marco Felsch wrote:
> > Hi,
> >
> > the whole purpose of this series is to make it possible to control the
> > USB VBUS regulators of an USB hub via host managed regulators.
> >
> > Regards,
> >   Marco
> >
> > ---
> > Changes in v4:
> > - dt-bindings: change to vbus-supply and shift doc to usb-device.yaml
> > - onboard_dev: make use of new regulator API to parse child device
> >                regulators.
> > - onboard_dev: drop hard coded downstream port number and make it more
> >                dynamic
> > - onboard_dev: drop limiting support to SMSC hubs
> > - Link to v3: https://lore.kernel.org/r/20250821-v6-16-topic-usb-onboard-dev-v3-0-6d2b38a5d818@pengutronix.de
> >
> > Changes in v3:
> > - fix dt-bindings issues
> > - Link to v2: https://lore.kernel.org/all/20250327172803.3404615-1-m.felsch@pengutronix.de/
> >
> > Changes in v2:
> > - fix compile time errors in case the module builds
> > - Link to v1: https://lore.kernel.org/all/20240807-b4-v6-10-topic-usb-onboard-dev-v1-0-f33ce21353c9@pengutronix.de/
> >
> > ---
> > Marco Felsch (5):
> >       usb: port: track the disabled state
> >       usb: hub: add infrastructure to pass onboard_dev port features
> >       dt-bindings: usb: usb-device: add usb hub port vbus-supply suppport
> >       dt-bindings: usb: microchip,usb2514: add vbus-supply example
> >       usb: misc: onboard_dev: add hub downstream port host vbus-supply handling
> >
> >  .../devicetree/bindings/usb/microchip,usb2514.yaml |   7 ++
> >  .../devicetree/bindings/usb/usb-device.yaml        |   6 ++
> >  drivers/usb/core/hub.c                             |  55 +++++++++-
> >  drivers/usb/core/hub.h                             |   4 +
> >  drivers/usb/core/port.c                            |   6 ++
> >  drivers/usb/misc/onboard_usb_dev.c                 | 117 +++++++++++++++++++++
> >  include/linux/usb.h                                |   3 +
> >  7 files changed, 196 insertions(+), 2 deletions(-)
> > ---
> > base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> > change-id: 20250821-v6-16-topic-usb-onboard-dev-b8d4d1d8a086
> >
> > Best regards,
> 
> Hi Marco,
> 
> I'm checking in to ask about the status of this patch series.
> 
> We are currently working on the Spacemit K1 SoC and we have a use case
> that requires onboard_dev to manage the USB VBUS regulator. This series
> would be very helpful for us :)

:)

> Link: https://lore.kernel.org/all/DG8QBWSJ79MP.2MVIHFRBX3WXX@linux.dev/

Regarding the status of this series. Rob provided his r-b tag once I
fixed the minor typo. I also need to fix bug [1] which is triggered by
the asix binding. I could move the 'vbus-supply' example to the
usb-device.yaml.

@Greg, @USB-maintainers
Are the driver changes OK?

Regards,
  Marco

[1] https://lore.kernel.org/all/175763620958.1187267.14091957840948870392.robh@kernel.org/


> 
> Best regards,
> Ze Huang
> 
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

Re: [PATCH v4 0/5] Add onboard-dev USB hub host managed vbus handling support

[Greg Kroah-Hartman]

On Tue, Feb 10, 2026 at 01:32:28PM +0100, Marco Felsch wrote:
> Hi,
> 
> On 26-02-10, Ze Huang wrote:
> > On Fri Sep 12, 2025 at 4:22 AM CST, Marco Felsch wrote:
> > > Hi,
> > >
> > > the whole purpose of this series is to make it possible to control the
> > > USB VBUS regulators of an USB hub via host managed regulators.
> > >
> > > Regards,
> > >   Marco
> > >
> > > ---
> > > Changes in v4:
> > > - dt-bindings: change to vbus-supply and shift doc to usb-device.yaml
> > > - onboard_dev: make use of new regulator API to parse child device
> > >                regulators.
> > > - onboard_dev: drop hard coded downstream port number and make it more
> > >                dynamic
> > > - onboard_dev: drop limiting support to SMSC hubs
> > > - Link to v3: https://lore.kernel.org/r/20250821-v6-16-topic-usb-onboard-dev-v3-0-6d2b38a5d818@pengutronix.de
> > >
> > > Changes in v3:
> > > - fix dt-bindings issues
> > > - Link to v2: https://lore.kernel.org/all/20250327172803.3404615-1-m.felsch@pengutronix.de/
> > >
> > > Changes in v2:
> > > - fix compile time errors in case the module builds
> > > - Link to v1: https://lore.kernel.org/all/20240807-b4-v6-10-topic-usb-onboard-dev-v1-0-f33ce21353c9@pengutronix.de/
> > >
> > > ---
> > > Marco Felsch (5):
> > >       usb: port: track the disabled state
> > >       usb: hub: add infrastructure to pass onboard_dev port features
> > >       dt-bindings: usb: usb-device: add usb hub port vbus-supply suppport
> > >       dt-bindings: usb: microchip,usb2514: add vbus-supply example
> > >       usb: misc: onboard_dev: add hub downstream port host vbus-supply handling
> > >
> > >  .../devicetree/bindings/usb/microchip,usb2514.yaml |   7 ++
> > >  .../devicetree/bindings/usb/usb-device.yaml        |   6 ++
> > >  drivers/usb/core/hub.c                             |  55 +++++++++-
> > >  drivers/usb/core/hub.h                             |   4 +
> > >  drivers/usb/core/port.c                            |   6 ++
> > >  drivers/usb/misc/onboard_usb_dev.c                 | 117 +++++++++++++++++++++
> > >  include/linux/usb.h                                |   3 +
> > >  7 files changed, 196 insertions(+), 2 deletions(-)
> > > ---
> > > base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> > > change-id: 20250821-v6-16-topic-usb-onboard-dev-b8d4d1d8a086
> > >
> > > Best regards,
> > 
> > Hi Marco,
> > 
> > I'm checking in to ask about the status of this patch series.
> > 
> > We are currently working on the Spacemit K1 SoC and we have a use case
> > that requires onboard_dev to manage the USB VBUS regulator. This series
> > would be very helpful for us :)
> 
> :)
> 
> > Link: https://lore.kernel.org/all/DG8QBWSJ79MP.2MVIHFRBX3WXX@linux.dev/
> 
> Regarding the status of this series. Rob provided his r-b tag once I
> fixed the minor typo. I also need to fix bug [1] which is triggered by
> the asix binding. I could move the 'vbus-supply' example to the
> usb-device.yaml.
> 
> @Greg, @USB-maintainers
> Are the driver changes OK?

I have no idea, this thread was from a very long time ago.  Please
resubmit after rebasing on 7.0-rc1 when it is out as we can't do
anything with any new patches until then anyway.

thanks,

greg k-h

Re: [PATCH v4 0/5] Add onboard-dev USB hub host managed vbus handling support

[Marco Felsch]

On 26-02-10, Greg Kroah-Hartman wrote:
> On Tue, Feb 10, 2026 at 01:32:28PM +0100, Marco Felsch wrote:
> > Hi,
> > 
> > On 26-02-10, Ze Huang wrote:
> > > On Fri Sep 12, 2025 at 4:22 AM CST, Marco Felsch wrote:
> > > > Hi,
> > > >
> > > > the whole purpose of this series is to make it possible to control the
> > > > USB VBUS regulators of an USB hub via host managed regulators.
> > > >
> > > > Regards,
> > > >   Marco
> > > >
> > > > ---
> > > > Changes in v4:
> > > > - dt-bindings: change to vbus-supply and shift doc to usb-device.yaml
> > > > - onboard_dev: make use of new regulator API to parse child device
> > > >                regulators.
> > > > - onboard_dev: drop hard coded downstream port number and make it more
> > > >                dynamic
> > > > - onboard_dev: drop limiting support to SMSC hubs
> > > > - Link to v3: https://lore.kernel.org/r/20250821-v6-16-topic-usb-onboard-dev-v3-0-6d2b38a5d818@pengutronix.de
> > > >
> > > > Changes in v3:
> > > > - fix dt-bindings issues
> > > > - Link to v2: https://lore.kernel.org/all/20250327172803.3404615-1-m.felsch@pengutronix.de/
> > > >
> > > > Changes in v2:
> > > > - fix compile time errors in case the module builds
> > > > - Link to v1: https://lore.kernel.org/all/20240807-b4-v6-10-topic-usb-onboard-dev-v1-0-f33ce21353c9@pengutronix.de/
> > > >
> > > > ---
> > > > Marco Felsch (5):
> > > >       usb: port: track the disabled state
> > > >       usb: hub: add infrastructure to pass onboard_dev port features
> > > >       dt-bindings: usb: usb-device: add usb hub port vbus-supply suppport
> > > >       dt-bindings: usb: microchip,usb2514: add vbus-supply example
> > > >       usb: misc: onboard_dev: add hub downstream port host vbus-supply handling
> > > >
> > > >  .../devicetree/bindings/usb/microchip,usb2514.yaml |   7 ++
> > > >  .../devicetree/bindings/usb/usb-device.yaml        |   6 ++
> > > >  drivers/usb/core/hub.c                             |  55 +++++++++-
> > > >  drivers/usb/core/hub.h                             |   4 +
> > > >  drivers/usb/core/port.c                            |   6 ++
> > > >  drivers/usb/misc/onboard_usb_dev.c                 | 117 +++++++++++++++++++++
> > > >  include/linux/usb.h                                |   3 +
> > > >  7 files changed, 196 insertions(+), 2 deletions(-)
> > > > ---
> > > > base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> > > > change-id: 20250821-v6-16-topic-usb-onboard-dev-b8d4d1d8a086
> > > >
> > > > Best regards,
> > > 
> > > Hi Marco,
> > > 
> > > I'm checking in to ask about the status of this patch series.
> > > 
> > > We are currently working on the Spacemit K1 SoC and we have a use case
> > > that requires onboard_dev to manage the USB VBUS regulator. This series
> > > would be very helpful for us :)
> > 
> > :)
> > 
> > > Link: https://lore.kernel.org/all/DG8QBWSJ79MP.2MVIHFRBX3WXX@linux.dev/
> > 
> > Regarding the status of this series. Rob provided his r-b tag once I
> > fixed the minor typo. I also need to fix bug [1] which is triggered by
> > the asix binding. I could move the 'vbus-supply' example to the
> > usb-device.yaml.
> > 
> > @Greg, @USB-maintainers
> > Are the driver changes OK?
> 
> I have no idea, this thread was from a very long time ago.  Please
> resubmit after rebasing on 7.0-rc1 when it is out as we can't do
> anything with any new patches until then anyway.

Done.

Regards,
  Marco

> 
> thanks,
> 
> greg k-h
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |