public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Luca Weiss" <luca.weiss@fairphone.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Alexander Koskovich" <AKoskovich@pm.me>
Cc: <~postmarketos/upstreaming@lists.sr.ht>,
	<phone-devel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 5/5] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi
Date: Fri, 13 Feb 2026 15:24:04 +0100	[thread overview]
Message-ID: <DGDWHX20052Z.C8JH4RXIPJCK@fairphone.com> (raw)
In-Reply-To: <300f3ceb-546b-4670-a0ae-4a6f451a7f4e@oss.qualcomm.com>

On Wed Jan 21, 2026 at 12:50 PM CET, Konrad Dybcio wrote:
> On 1/16/26 3:50 PM, Luca Weiss wrote:
>> Configure and enable the WiFi node, and add the required pinctrl to
>> provide the sleep clock from the PMK8550 (PMK7635) to WCN6755.
>> 
>> Thanks to Alexander Koskovich for helping with the bringup, adding
>> the missing pinctrl to make the WPSS stop crashing.
>> 
>> Link: https://lore.kernel.org/linux-arm-msm/DBF7OWAWQ94M.FSCP4DPF8ZJY@fairphone.com/
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>>  arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 19 ++++++++++++++++++-
>>  1 file changed, 18 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> index cbe1507b0aaa..75f2b3a3e572 100644
>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> @@ -232,7 +232,7 @@ wcn6750-pmu {
>>  
>>  		clocks = <&rpmhcc RPMH_RF_CLK1>;
>>  
>> -		pinctrl-0 = <&bluetooth_enable_default>;
>> +		pinctrl-0 = <&bluetooth_enable_default>, <&pmk8550_sleep_clk_default>;
>>  		pinctrl-names = "default";
>>  
>>  		regulators {
>> @@ -704,6 +704,17 @@ &pmiv0104_eusb2_repeater {
>>  	qcom,tune-usb2-preem = /bits/ 8 <0x6>;
>>  };
>>  
>> +&pmk8550_gpios {
>> +	pmk8550_sleep_clk_default: sleep-clk-default-state {
>> +		pins = "gpio5";
>
> I'm thinking how to best reflect that. Perhaps gpio-gate-clock which
> would be consumed by the PMU?

This way of doing it already has a precedent with sm8550-hdk.dts and
sm8550-qrd.dts at least.

Regards
Luca

>
> FWIW PMK8550 can reportedly output this clock from GPIO3 and GPIO5
> (not sure if at once) if set to FUNC1
>
> Konrad


  reply	other threads:[~2026-02-13 14:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 14:50 [PATCH 0/5] Enable Bluetooth and WiFi on Fairphone (Gen. 6) Luca Weiss
2026-01-16 14:50 ` [PATCH 1/5] soc: qcom: pd-mapper: Add Milos compatible Luca Weiss
2026-01-16 16:13   ` Dmitry Baryshkov
2026-01-16 14:50 ` [PATCH 2/5] arm64: dts: qcom: milos: Split up uart11 pinctrl Luca Weiss
2026-01-20 14:12   ` Konrad Dybcio
2026-01-16 14:50 ` [PATCH 3/5] arm64: dts: qcom: milos: Add WCN6750 WiFi node Luca Weiss
2026-01-16 16:14   ` Dmitry Baryshkov
2026-01-20 14:39   ` Konrad Dybcio
2026-02-13 13:42     ` Luca Weiss
2026-02-17 11:01       ` Konrad Dybcio
2026-02-13 14:31     ` Dmitry Baryshkov
2026-02-17 10:59       ` Konrad Dybcio
2026-01-16 14:50 ` [PATCH 4/5] arm64: dts: qcom: milos-fairphone-fp6: Enable Bluetooth Luca Weiss
2026-01-16 16:15   ` Dmitry Baryshkov
2026-01-21 11:52   ` Konrad Dybcio
2026-03-13 10:40     ` Luca Weiss
2026-03-13 12:41       ` Konrad Dybcio
2026-03-13 14:00       ` Luca Weiss
2026-03-16 12:50         ` Konrad Dybcio
2026-01-16 14:50 ` [PATCH 5/5] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi Luca Weiss
2026-01-16 16:17   ` Dmitry Baryshkov
2026-01-21 11:50   ` Konrad Dybcio
2026-02-13 14:24     ` Luca Weiss [this message]
2026-02-17 10:56       ` Konrad Dybcio
2026-03-19  3:31 ` (subset) [PATCH 0/5] Enable Bluetooth and WiFi on Fairphone (Gen. 6) Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGDWHX20052Z.C8JH4RXIPJCK@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=AKoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox