From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Srinivas Kandagatla" <srinivas.kandagatla@oss.qualcomm.com>,
"Luca Weiss" <luca.weiss@fairphone.com>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <vkoul@kernel.org>
Cc: <conor+dt@kernel.org>, <srini@kernel.org>,
<yung-chuan.liao@linux.intel.com>,
<pierre-louis.bossart@linux.dev>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <alexey.klimov@linaro.org>,
<linux-sound@vger.kernel.org>
Subject: Re: [PATCH v4 4/7] soundwire: qcom: deprecate qcom,din/out-ports
Date: Fri, 27 Feb 2026 13:31:56 +0100 [thread overview]
Message-ID: <DGPQVOVH3N31.2XHZP30TUC18Q@fairphone.com> (raw)
In-Reply-To: <a814c0bf-e421-4cf2-8b9b-e5dac9b80dff@oss.qualcomm.com>
On Sun Feb 22, 2026 at 10:09 AM CET, Srinivas Kandagatla wrote:
> On 2/20/26 1:34 PM, Luca Weiss wrote:
>> Hi Srinivas,
>>
>> On Fri Sep 12, 2025 at 10:32 AM CEST, Srinivas Kandagatla wrote:
>>> Number of input and output ports can be dynamically read from the
>>> controller registers, getting this value from Device Tree is redundant
>>> and potentially lead to bugs.
>>>
>>> Remove the code parsing this property along with marking this as
>>> deprecated in device tree bindings.
>>
>> Could you help suggest how to correct kodiak.dtsi?
>>
>
> This needs fixing in kodiak.dtsi, for somereason the dtsi is trying to
> add ports that does not clearly reflect the actual hardware.
How should the qcom,ports-* properties be updated to be correct?
I'm seeing the same on Milos, where the hardware registers are +1 from
what downstream describes, in all 4 soundwire controllers there.
swr_rx (reg=0x03210000):
SWRM_COMP_PARAMS din: 1, dout: 6 (=7)
(downstream: rx_swr_master - qcom,swr-num-ports = <6>)
swr_tx (reg=0x033b0000):
SWRM_COMP_PARAMS din: 4, dout: 0 (=4)
(downstream va_swr_master - qcom,swr-num-ports = <3>)
swr_wsa (reg=0x03250000):
SWRM_COMP_PARAMS din: 3, dout: 6 (=9)
downstream: wsa_swr_master - qcom,swr-num-ports = <8>
bt_swr (reg=0x031e0000):
SWRM_COMP_PARAMS din: 5, dout: 4 (=9)
downstream: bt_swr_mstr - qcom,swr-num-ports = <8>
Regards
Luca
>
> --srini
>
>> I'm seeing these warnings on QCM6490:
>>
>> [ 36.952517] qcom-soundwire 3210000.soundwire: din-ports (0) mismatch with controller (1)
>> [ 36.952524] qcom-soundwire 3210000.soundwire: dout-ports (5) mismatch with controller (6)
>> [ 36.954285] qcom-soundwire 3230000.soundwire: din-ports (3) mismatch with controller (4)
next prev parent reply other threads:[~2026-02-27 12:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 8:32 [PATCH v4 0/7] soundwire: qcom: add support for v3.1.0 Srinivas Kandagatla
2025-09-12 8:32 ` [PATCH v4 1/7] of: base: Add of_property_read_u8_index Srinivas Kandagatla
2025-09-12 8:32 ` [PATCH v4 2/7] soundwire: qcom: remove unused rd_fifo_depth Srinivas Kandagatla
2025-09-12 8:32 ` [PATCH v4 3/7] dt-bindings: soundwire: qcom: deprecate qcom,din/out-ports Srinivas Kandagatla
2025-09-12 8:32 ` [PATCH v4 4/7] " Srinivas Kandagatla
2026-02-20 13:34 ` Luca Weiss
2026-02-20 14:06 ` Alexey Klimov
2026-02-22 9:09 ` Srinivas Kandagatla
2026-02-27 12:31 ` Luca Weiss [this message]
2026-03-04 11:41 ` Srinivas Kandagatla
2025-09-12 8:32 ` [PATCH v4 5/7] soundwire: qcom: prepare for v3.x Srinivas Kandagatla
2025-09-12 8:32 ` [PATCH v4 6/7] dt-bindings: soundwire: qcom: Document v3.1.0 version of IP block Srinivas Kandagatla
2025-09-12 8:32 ` [PATCH v4 7/7] soundwire: qcom: adding support for v3.1.0 Srinivas Kandagatla
2025-10-13 15:42 ` [PATCH v4 0/7] soundwire: qcom: add " Alexey Klimov
2025-11-05 14:58 ` Srinivas Kandagatla
2025-11-12 5:13 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGPQVOVH3N31.2XHZP30TUC18Q@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=alexey.klimov@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox