From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CDBF344DB5 for ; Sat, 14 Mar 2026 14:19:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773497982; cv=none; b=ntBKOBXM8kokuZdGni+hBBo9VrOTw4uhf2KdqILxCX3ewk+JB7GErQCxtVSrXCiOIdcXa6LOo/6KYKuNDWtfHZEa8/kLFPmECpksofgaGF9KzWH2BRtj50Lozb8AxCPo6o15yLwHHAR6AvoTe4wNQrBhPpO8MMlfEuubjvsO22E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773497982; c=relaxed/simple; bh=+Q2NHbqyScT8pUlf7wHWUJIw0RO1x/ZiSkOBZGtVGzI=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:Cc:To: References:In-Reply-To; b=o1vWzP51P9451OD6V8aeOW/3+emrXUD4ZXyVjMP1Xjlael7oIh5F8AbaFSqD0vArSbPAUZuVv1L9xlLVV6PKcemc0qOq9O1YCoF1UKYk9XkDDsb62pVwJqziuahjIgRDrE0SCYtecwwHASHenTzwFvnhn9ZLMNe/TGAW5h3sBzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=EGLEwi+W; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="EGLEwi+W" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1773497976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xl+Uf18fqruXHqchg5arUmkQufHcl9O3lBTne7YsaaQ=; b=EGLEwi+WJkwvV8gz682AmrPTMD1U66aeOBTeWeosWn8TziuY17rzTDlXucPem7yuwUbLq7 k3uD0kFRayntDssYJGY5sVuAI4wWbmSzOu41+ADPrUqBWx/pcBVOU/y3PRMs7gzvDGYPQp pAUXoiRHvDVg7A3RYc4ZIKtqh/wY2k3K/nqRwi0G2EU1+QwCIg9Yt9XjmSAnqGUL6Hxno4 bUE/fjvSpd7TFrBVCvYoMrAD9BRmxj8kEs1IeCwDxG1FQZv8v6n0o9bdsXtqGvZM0FsP3S 0NOxd6rWdW1wq8uXlM6U+ImQcs3Sb6OhNdv01nvwlWX2ZRas/1r+Da2eeYSf5w== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 14 Mar 2026 15:19:22 +0100 Message-Id: Subject: Re: [PATCH v2 0/3] media: rockchip: rkvdec: add support for the VDPU346 variant X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" Cc: "Christian Hewitt" , "Detlev Casanova" , =?utf-8?q?Olivier_Cr=C3=AAte?= , "Ezequiel Garcia" , "Mauro Carvalho Chehab" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , "Diederik de Haas" , "Dmitry Osipenko" , "Thomas Gleixner" , "Dragan Simic" , "Chukun Pan" , , , , , To: "Nicolas Dufresne" References: <20251226113140.573759-1-christianshewitt@gmail.com> In-Reply-To: X-Migadu-Flow: FLOW_OUT Hi Nicolas, On Sun Mar 8, 2026 at 10:40 PM CET, Nicolas Dufresne wrote: > Le vendredi 26 d=C3=A9cembre 2025 =C3=A0 11:31 +0000, Christian Hewitt a = =C3=A9crit=C2=A0: >> This series depends upon Detlev Casanova's current v7 series for VDPU381= and >> VDPU383 support [0]. It adds support for the VDPU346 IP block used for H= 264, >> HEVC and (in active work) VP9 on the RK356X boards. VDPU346 appears to b= e a >> close relation to VDPU381 used with RK3588, except with a single core, o= utput >> limited to 4K, and minor feature differences, e.g. HEVC level 5.1 on VDP= U346 >> vs 6.1 on VDPU381. To handle differences we declare a new compatible. >>=20 >> The device-tree changes are derived from prior-art in Detlev's patches f= or >> RK3576 and RK3588, the vendor kernel [1], and some earlier patch attempt= s >> from Piotr Oniszczuk and Diederik de Haas. >>=20 >> The register differences between VDPU346 and VDPU381 appear to be minima= l so >> we currently and intentionally reuse the VDPU381 h264, hevc, and regs fi= les >> to avoid duplicating code. There is some evidence of buffer size changes= in >> testing which still need to be explored. If further register analysis ne= eds >> separate files for VDPU346 the refactoring will be beyond my current n00= b >> coding skills and I will either need some coaching or would be happy to = pass >> the series over to a more experienced developer. > > A fluster score and explained error report is missing your this cover let= ter.=20 > This will probably highlight some of the instability issues reported in t= his > series. I'll mark the series are "Change Request", as you have few review > comments and now this test. > > Overall, I'd like to see probably investigations of the problem before go= ing > ahead. FTR: You replied to v2 while there is a v3 here: https://patch.msgid.link/20260110053727.2295260-1-christianshewitt@gmail.co= m/ It (still) doesn't have a fluster score, but it is the currently most recent version posted on the MLs. Cheers, Diederik