public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Alexander Koskovich" <akoskovich@pm.me>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Kees Cook" <kees@kernel.org>, "Tony Luck" <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: qcom: milos: Reduce rmtfs_mem size to 2.5MiB
Date: Mon, 23 Mar 2026 13:32:05 +0100	[thread overview]
Message-ID: <DHA5WVPN3F25.2Q71FMM8PD7UL@fairphone.com> (raw)
In-Reply-To: <bd33bd53-2539-42ee-ba3c-4a544a61b621@oss.qualcomm.com>

On Mon Mar 23, 2026 at 10:51 AM CET, Konrad Dybcio wrote:
> On 3/21/26 6:00 PM, Alexander Koskovich wrote:
>> The rmtfs_mem region is currently sized at 6MiB but the default for
>> milos downstream is 2.5MiB. This causes remoteproc crashes on devices
>> that expect the smaller size:
>> 
>> modem_ac.c:281:Access Control Error: Could not protect the region specified:Start:e1f00000 End:e2180000, PID:1
>> 
>> Reduce the default to 2.5MiB to match the QCOM downstream config, and
>> override the size for FP6.
>> 
>> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
>> ---
>>  arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 4 ++++
>>  arch/arm64/boot/dts/qcom/milos.dtsi              | 2 +-
>>  2 files changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> index 52895dd9e4fa..c0981ab731c4 100644
>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> @@ -724,6 +724,10 @@ &remoteproc_wpss {
>>  	status = "okay";
>>  };
>>  
>> +&rmtfs_mem {
>> +	reg = <0x0 0xe1f00000 0x0 0x600000>;
>
> +Luca

You didn't actually Cc me, but I found it on the mailing list anyways :)

>
> Could you please confirm that this was intentional in the first place?
>
> FWIW I see that volcano.dtsi indeed only requests 0x280_000 on a "clean"
> Qualcomm tree

Yes, it's intentional that it's 6 MiB on Fairphone (Gen. 6):

https://gerrit-public.fairphone.software/plugins/gitiles/platform/vendor/qcom/proprietary/devicetree/+/b3744ffef87e1f2a232b26e9cb270a1f82554bc3%5E!/

I think Fixes is appropriate since the default for Milos should be
0x280_000 and not 0x600_000?

Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")

And maybe a comment like this on top of the node?

/* Increase the size from 2.5 MiB to 6 MiB */

Anyways:

Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>


Regards
Luca

  reply	other threads:[~2026-03-23 12:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21 17:00 [PATCH 0/3] arm64: dts: qcom: Add support for the Nothing Phone (3a) Alexander Koskovich
2026-03-21 17:00 ` [PATCH 1/3] arm64: dts: qcom: milos: Reduce rmtfs_mem size to 2.5MiB Alexander Koskovich
2026-03-23  9:51   ` Konrad Dybcio
2026-03-23 12:32     ` Luca Weiss [this message]
2026-03-23 12:38       ` Konrad Dybcio
2026-03-21 17:00 ` [PATCH 2/3] dt-bindings: arm: qcom: Add the Nothing Phone (3a) Alexander Koskovich
2026-03-21 21:09   ` Krzysztof Kozlowski
2026-03-21 17:00 ` [PATCH 3/3] arm64: dts: " Alexander Koskovich
2026-03-22 10:24   ` Alexander Koskovich
2026-03-23 10:49   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHA5WVPN3F25.2Q71FMM8PD7UL@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox