public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: 曹珊珊 <sandie.cao@deepcomputing.io>, "Yixun Lan" <dlan@kernel.org>
Cc: "Conor Dooley" <conor+dt@kernel.org>,
	"Emil Renner Berthing" <kernel@esmil.dk>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Michael Opdenacker" <michael.opdenacker@rootcommit.com>,
	"Guodong Xu" <guodong@riscstar.com>,
	"Hendrik Hamerlinck" <hendrik.hamerlinck@hammernet.be>,
	"Yangyu Chen" <cyy@cyyself.name>, <spacemit@lists.linux.dev>,
	<linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] riscv: dts: spacemit: add DeepComputing FML13V05 board device tree
Date: Wed, 01 Apr 2026 14:42:28 +0800	[thread overview]
Message-ID: <DHHM43F6TE9I.1F5A3O0VOS6ND@linux.spacemit.com> (raw)
In-Reply-To: <407ce3d77416bb2522b7906b0df3d5adf02c27ee.4c756029.b64e.488e.905e.99baaf78d6a1@feishu.cn>

On Wed Apr 1, 2026 at 2:10 PM CST, 曹珊珊 wrote:
> Hi Lan,
>
>> From: "Yixun Lan"<dlan@kernel.org>
>> Hi Sandie, 
>> 
>> On 11:46 Tue 31 Mar     , Sandie Cao wrote:
>> > From: sandiecao <sandie.cao@deepcomputing.io>
>> > 
>> > The FML13V05 board from DeepComputing incorporates a SpacemiT K3 RISC-V
>> > SoC.It is a mainboard designed for the Framework Laptop 13 Chassis,
>> > which has (Framework) SKU FRANHQ0001.
>> > 
>> > The FML13V05 board features:
>> > - SpacemiT K3 RISC-V SoC
>> > - LPDDR5 16GB or 32GB
>> > - eMMC 32GB ~128GB (Optional)
>> > - UFS 3.1 256G (Optional)
>> > - QSPI Flash
>> > - MicroSD Slot
>> > - PCIe-based Wi-Fi
>> > - 4 USB-C Ports
>> >  - Port 1: PD 3.0 (65W Max), USB 3.2 Gen 1
>> >  - Port 2: PD 3.0 (65W Max), USB 3.2 Gen 1, DP 1.4 (4K@60Hz)
>> >  - Port 3 & 4: USB 3.2 Gen 1
>> > 
>> > This minimal device tree enables booting into a serial console with UART
>> > output.
>> > 
>> > Signed-off-by: sandiecao <sandie.cao@deepcomputing.io>
>> > Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> > +&uart0 {
>> Can you also add pinctrl data explicitly?
>
> To avoid conflict,  the common pinctrl table "k3-pinctrl.dtsi" should be uploaded by spacemit. 
> Then we will add the pinctrl data after k3-pico-itx.dts. That should be another patch. 
> Sandie
I think you don't understand what Yixun said.
You should add pinctrl properties here like:
pinctrl-0 = xxx;
pinctrl-names = "default";

While the bootloader is expected to initialize the UART pins, explicitly adding the pinctrl properties
ensures hardware state consistency.

                                      - Troy

  reply	other threads:[~2026-04-01  6:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  3:44 [PATCH v1 0/2] Add DeepComputing FML13V05 board dts Sandie Cao
2026-03-31  3:45 ` [PATCH v1 1/2] dt-bindings: riscv: spacemit: add deepcomputing,fml13v05 Sandie Cao
2026-03-31  6:03   ` Yixun Lan
2026-03-31  6:15     ` 曹珊珊
2026-03-31  6:24       ` Troy Mitchell
2026-03-31  6:38         ` 曹珊珊
2026-03-31 10:25   ` Krzysztof Kozlowski
2026-03-31  3:46 ` [PATCH v1 2/2] riscv: dts: spacemit: add DeepComputing FML13V05 board device tree Sandie Cao
2026-03-31  3:50   ` Troy Mitchell
2026-03-31  8:59   ` Yixun Lan
2026-04-01  6:10     ` 曹珊珊
2026-04-01  6:42       ` Troy Mitchell [this message]
2026-04-01  7:38         ` 曹珊珊
2026-04-01  7:55           ` Troy Mitchell
2026-04-01  8:25             ` Sandie Cao
2026-03-31  7:10 ` [PATCH v2 0/2] Add DeepComputing FML13V05 board dts Sandie Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHHM43F6TE9I.1F5A3O0VOS6ND@linux.spacemit.com \
    --to=troy.mitchell@linux.spacemit.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=cyy@cyyself.name \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=guodong@riscstar.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=hendrik.hamerlinck@hammernet.be \
    --cc=kernel@esmil.dk \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=michael.opdenacker@rootcommit.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=sandie.cao@deepcomputing.io \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox