From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0CD53DD53F for ; Thu, 2 Apr 2026 12:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775132702; cv=none; b=ffxDJia3WZruXdg+zH7Mz8Cmry6ngHshS07IhmAESM91+j3mR8+O/QB2ueuLPVBckkKHenBSV0q8xh9PBMR2qiGpZPkp6Zi8Kk813kEQEQ6PtsP1e96mix4t5n6CONI9bnkU5+lUfRkqga3d2XTMNEg+12Jgg/63yyBzNUjspEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775132702; c=relaxed/simple; bh=VFq9AWUrc9CcWHC7ojF6xOAibaAgS5IkinF3nAaUdvg=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=PhaxsZRTNPoXDcMiSmBEeN3png8nSEMo/QcM6RMex38LAqFpZ+NB103IId9JgirwWEOROjmMS/iTUKnfA49kMMlx5dNdqCyGOIiDQ4WVSdOyMO1Yd7Ksor8BSOAajmd5oX8SHGuiKYf5aMo6Lu3Ezott9eFiSCPaQknfVINkvSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=fI58aKgq; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="fI58aKgq" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6618bc129acso1078785a12.2 for ; Thu, 02 Apr 2026 05:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1775132699; x=1775737499; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kV57QUhm1LJKEL7ZZkpUHcm6gesGlh2s479uzYXuMeM=; b=fI58aKgq/aSY+7Z0jlFsYNSi0x5D4tu+9WTXceYNuambD3bAFsdlKg+qirj7dcEuts 2v6YPKNa8OvP4Q7GCGxf1TuI4QzsFq80O3AaW6VRUSXcLv+fbSOX1mrYLq1I1n2OffSm LRO/YU1TqqOJH/j7lTGWNq3X1VFAE7eJdX+gYbcZT7u1iKu+PeWoeWkywwQor1wOf2Pa Cr9P09ugasZw5iSDqQbL3uNM9akYymOkgikzPomeRz7eP19/hAg/jeGdQLSXplIWEq+Z vLGF0FQMrG26vj1ZdGrZUHWBi3QhQRgaNZjHYftVLgAVAckyxfvkfX+XqpNcpjpD1rJP 33Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775132699; x=1775737499; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kV57QUhm1LJKEL7ZZkpUHcm6gesGlh2s479uzYXuMeM=; b=VLFOlDBi2PvYOV28lf/QKfD9hxLRfSBTO1GnNfDv5PVb1q3AxBiSrog/m5Hv++XO8x SMlTSegy7w40gDsA5ke5e8xKhYmgNPt4u4CmArGsl8GLSH9RxvaRikNCR9jVFSVJIDSV 9ncGTMSkwd4GO4oNKVvipFvvYZI48aRYi7dKv37iclWV//bOwx2ptAvnJfSamTuet8tJ 3PbmMd7feYlo1va1vAl2uop0EVrlta5z1r/refo8O2anKW8diyPrTQMVUZvw1BUNj4/S lDCREK2YzuOIN/csVymH+kKJGJtgVsrMmlgoJ4U6av+BscDZfxY895nwX3e5nLoT4Nbl LI6Q== X-Forwarded-Encrypted: i=1; AJvYcCUMlWSEiRO3db6XO1fJvXwPiPwMBh/WuMMBI87CNr6OxmbtnQ85kncmte+5JQVdwCufsuJftBtBTfuu@vger.kernel.org X-Gm-Message-State: AOJu0YyR5JebqqHf26MwAGfATB6f3ANDhF8YhZmdX+OcwtWqcBh/J8uf Jf5c5d/mB6pz/hySTNhGlkZ0Ev6+3/9iCfp/vbY5zLV0b5Bh8DH7aoR4OK3vfmLyvMc= X-Gm-Gg: ATEYQzwkpCnGOA9pXP/ippLoKo4AxbJ2Vm9lZtbxiQLsL420roGa36hbhPVV96h0oKI /Juxrt7R+tiJVRA0Wo+R/hxppAc/g8rD2qE10DJTQMSwuLyr+k0IBb3uIY2X3yHYsGYQ/Snumlm 12jHQjQTH6vy1WU2p3PjKtkc+3y410ZQd3svKgDCkfj4gLVsZj7UgmLpxy3f8e7HwXcVVuvVRLh isQRw2A9SHfKeqaG2AldELGqBkMTAyyo4QSGIEV9mYsl+Jd+mh7RE9qQW0DrOQZ0VYi4hWtv2Tp MNqija4urJGNYMKHWaqVBvyAMHdoQouh27/BG13l1ksz0tERzm5+LH7+Us0aRwR1tgcYTDBwBHG 1dy7oewg+yIoc1l5v8S9/gUZvZlguw0C7bKMX9DtKc80mQnMnjTobZzhNwtH3pOBSFf2uavk4qK yytCaabVYlsKj9wK66d+2Dgot1CY2+2nB7b6vWPneOmvTP3iJAumZhr3sNeDPqSq9NC7Lzcir00 6+EzoUlf2IW7BbPogWt8fwOb4bcinDA63tXhokjsMCCqQA= X-Received: by 2002:a17:907:3895:b0:b97:c968:d9ba with SMTP id a640c23a62f3a-b9c1378f46emr488650466b.5.1775132699170; Thu, 02 Apr 2026 05:24:59 -0700 (PDT) Received: from localhost (2001-1c00-3b89-c600-71a4-084f-6409-1447.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b89:c600:71a4:84f:6409:1447]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3c99ec6esm82792766b.16.2026.04.02.05.24.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 05:24:58 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 02 Apr 2026 14:24:57 +0200 Message-Id: From: "Luca Weiss" To: "Krzysztof Kozlowski" , "Luca Weiss" Cc: "Bjorn Andersson" , "Michael Turquette" , "Stephen Boyd" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Konrad Dybcio" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH 1/3] dt-bindings: clock: qcom: document the Milos GX clock controller X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260306-milos-gxclkctl-v1-0-00b09ee159a7@fairphone.com> <20260306-milos-gxclkctl-v1-1-00b09ee159a7@fairphone.com> <20260307-inventive-stingray-of-pride-5c2216@quoll> <768180d0-bab6-466f-9f5f-54b36f353bd6@kernel.org> In-Reply-To: <768180d0-bab6-466f-9f5f-54b36f353bd6@kernel.org> On Thu Apr 2, 2026 at 10:23 AM CEST, Krzysztof Kozlowski wrote: > On 07/03/2026 16:30, Krzysztof Kozlowski wrote: >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - qcom,milos-gxclkctl >>> + >>> + power-domains: >>> + description: >>> + Power domains required for the clock controller to operate >>> + items: >>> + - description: GFX power domain >>> + - description: GPUCC(CX) power domain >>> + >>> + '#power-domain-cells': >>> + const: 1 >>> + >>> + reg: >>> + maxItems: 1 >>=20 >> reg should be the second property, like you have it in "required" part. >> I guess you copied it from kaanapali-gxclkctl.yaml, so lesson - qcom >> bindings have acceptable quality, but not good enough to take as correct >> starting point. >>=20 > > OTOH, why this entire binding cannot be squashed in Kaanapali one? > What's the difference? There's no GMXC power domain on Milos. Apart from that they're compatible from a bindings perspective. However it can re-use include/dt-bindings/clock/qcom,kaanapali-gxclkctl.h because the GX_CLKCTL_GX_GDSC definition would be identical. And also the driver (which can be used as-is) would be identical. In that driver qcom,kaanapali-gxclkctl.h is used so it makes sense to keep with the kaanapali header, or not? Making a qcom,milos-gxclkctl.h with the same definition is not wanted? Regards Luca