public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Describe IMEM on Milos
@ 2026-04-03 15:00 Luca Weiss
  2026-04-03 15:00 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: Add the Milos compatible Luca Weiss
  2026-04-03 15:00 ` [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node Luca Weiss
  0 siblings, 2 replies; 7+ messages in thread
From: Luca Weiss @ 2026-04-03 15:00 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
	linux-kernel, Luca Weiss

Add a compatible and describe the IMEM for the Milos SoC.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Luca Weiss (2):
      dt-bindings: sram: qcom,imem: Add the Milos compatible
      arm64: dts: qcom: milos: Add IMEM node

 Documentation/devicetree/bindings/sram/qcom,imem.yaml |  1 +
 arch/arm64/boot/dts/qcom/milos.dtsi                   | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)
---
base-commit: 83acad05dee54a5cff0c98dd7962e55d4c6b145a
change-id: 20260403-milos-imem-3a034224946a

Best regards,
--  
Luca Weiss <luca.weiss@fairphone.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] dt-bindings: sram: qcom,imem: Add the Milos compatible
  2026-04-03 15:00 [PATCH 0/2] Describe IMEM on Milos Luca Weiss
@ 2026-04-03 15:00 ` Luca Weiss
  2026-04-05  7:54   ` Krzysztof Kozlowski
  2026-04-03 15:00 ` [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node Luca Weiss
  1 sibling, 1 reply; 7+ messages in thread
From: Luca Weiss @ 2026-04-03 15:00 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
	linux-kernel, Luca Weiss

Add compatible for Milos SoC IMEM.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
index c63026904061..38488e28a6b4 100644
--- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
@@ -19,6 +19,7 @@ properties:
       - enum:
           - qcom,apq8064-imem
           - qcom,ipq5424-imem
+          - qcom,milos-imem
           - qcom,msm8226-imem
           - qcom,msm8974-imem
           - qcom,msm8976-imem

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node
  2026-04-03 15:00 [PATCH 0/2] Describe IMEM on Milos Luca Weiss
  2026-04-03 15:00 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: Add the Milos compatible Luca Weiss
@ 2026-04-03 15:00 ` Luca Weiss
  2026-04-03 19:30   ` Dmitry Baryshkov
  2026-04-07 10:21   ` Konrad Dybcio
  1 sibling, 2 replies; 7+ messages in thread
From: Luca Weiss @ 2026-04-03 15:00 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
	linux-kernel, Luca Weiss

Add a node for the IMEM found on Milos, which contains pil-reloc-info
and the modem tables for IPA, among others.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/milos.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
index 4a64a98a434b..1c045743ef77 100644
--- a/arch/arm64/boot/dts/qcom/milos.dtsi
+++ b/arch/arm64/boot/dts/qcom/milos.dtsi
@@ -2289,6 +2289,25 @@ scl-pins {
 			};
 		};
 
+		sram@14680000 {
+			compatible = "qcom,milos-imem", "syscon", "simple-mfd";
+			reg = <0x0 0x14680000 0x0 0x2c000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			ranges = <0 0 0x14680000 0x2c000>;
+
+			pil-reloc@94c {
+				compatible = "qcom,pil-reloc-info";
+				reg = <0x94c 0xc8>;
+			};
+
+			ipa_modem_tables: modem-tables@3000 {
+				reg = <0x3000 0x2000>;
+			};
+		};
+
 		apps_smmu: iommu@15000000 {
 			compatible = "qcom,milos-smmu-500", "qcom,smmu-500", "arm,mmu-500";
 			reg = <0x0 0x15000000 0x0 0x100000>;

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node
  2026-04-03 15:00 ` [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node Luca Weiss
@ 2026-04-03 19:30   ` Dmitry Baryshkov
  2026-04-07 10:21   ` Konrad Dybcio
  1 sibling, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2026-04-03 19:30 UTC (permalink / raw)
  To: Luca Weiss
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, ~postmarketos/upstreaming, phone-devel,
	linux-arm-msm, devicetree, linux-kernel

On Fri, Apr 03, 2026 at 05:00:24PM +0200, Luca Weiss wrote:
> Add a node for the IMEM found on Milos, which contains pil-reloc-info
> and the modem tables for IPA, among others.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/milos.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
> index 4a64a98a434b..1c045743ef77 100644
> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
> @@ -2289,6 +2289,25 @@ scl-pins {
>  			};
>  		};
>  
> +		sram@14680000 {
> +			compatible = "qcom,milos-imem", "syscon", "simple-mfd";

I think, the latest trend is to describe IMEM as a mmio-sram.

> +			reg = <0x0 0x14680000 0x0 0x2c000>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			ranges = <0 0 0x14680000 0x2c000>;
> +
> +			pil-reloc@94c {
> +				compatible = "qcom,pil-reloc-info";
> +				reg = <0x94c 0xc8>;
> +			};
> +
> +			ipa_modem_tables: modem-tables@3000 {
> +				reg = <0x3000 0x2000>;
> +			};
> +		};
> +
>  		apps_smmu: iommu@15000000 {
>  			compatible = "qcom,milos-smmu-500", "qcom,smmu-500", "arm,mmu-500";
>  			reg = <0x0 0x15000000 0x0 0x100000>;
> 
> -- 
> 2.53.0
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] dt-bindings: sram: qcom,imem: Add the Milos compatible
  2026-04-03 15:00 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: Add the Milos compatible Luca Weiss
@ 2026-04-05  7:54   ` Krzysztof Kozlowski
  2026-04-07  8:21     ` Luca Weiss
  0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-05  7:54 UTC (permalink / raw)
  To: Luca Weiss
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, ~postmarketos/upstreaming, phone-devel,
	linux-arm-msm, devicetree, linux-kernel

On Fri, Apr 03, 2026 at 05:00:23PM +0200, Luca Weiss wrote:
> Add compatible for Milos SoC IMEM.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> index c63026904061..38488e28a6b4 100644
> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> @@ -19,6 +19,7 @@ properties:
>        - enum:
>            - qcom,apq8064-imem
>            - qcom,ipq5424-imem
> +          - qcom,milos-imem

Wasn't this imem binding supposed to stop growing and switch to a
different style?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] dt-bindings: sram: qcom,imem: Add the Milos compatible
  2026-04-05  7:54   ` Krzysztof Kozlowski
@ 2026-04-07  8:21     ` Luca Weiss
  0 siblings, 0 replies; 7+ messages in thread
From: Luca Weiss @ 2026-04-07  8:21 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Luca Weiss
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio, ~postmarketos/upstreaming, phone-devel,
	linux-arm-msm, devicetree, linux-kernel

On Sun Apr 5, 2026 at 9:54 AM CEST, Krzysztof Kozlowski wrote:
> On Fri, Apr 03, 2026 at 05:00:23PM +0200, Luca Weiss wrote:
>> Add compatible for Milos SoC IMEM.
>> 
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>>  Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> index c63026904061..38488e28a6b4 100644
>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> @@ -19,6 +19,7 @@ properties:
>>        - enum:
>>            - qcom,apq8064-imem
>>            - qcom,ipq5424-imem
>> +          - qcom,milos-imem
>
> Wasn't this imem binding supposed to stop growing and switch to a
> different style?

Then I missed the memo. Is this written anywhere (apart from LKML)?

Regards
Luca

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node
  2026-04-03 15:00 ` [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node Luca Weiss
  2026-04-03 19:30   ` Dmitry Baryshkov
@ 2026-04-07 10:21   ` Konrad Dybcio
  1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2026-04-07 10:21 UTC (permalink / raw)
  To: Luca Weiss, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
	linux-kernel

On 4/3/26 5:00 PM, Luca Weiss wrote:
> Add a node for the IMEM found on Milos, which contains pil-reloc-info
> and the modem tables for IPA, among others.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/milos.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
> index 4a64a98a434b..1c045743ef77 100644
> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
> @@ -2289,6 +2289,25 @@ scl-pins {
>  			};
>  		};
>  
> +		sram@14680000 {
> +			compatible = "qcom,milos-imem", "syscon", "simple-mfd";

With the new compatible:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-04-07 10:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-03 15:00 [PATCH 0/2] Describe IMEM on Milos Luca Weiss
2026-04-03 15:00 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: Add the Milos compatible Luca Weiss
2026-04-05  7:54   ` Krzysztof Kozlowski
2026-04-07  8:21     ` Luca Weiss
2026-04-03 15:00 ` [PATCH 2/2] arm64: dts: qcom: milos: Add IMEM node Luca Weiss
2026-04-03 19:30   ` Dmitry Baryshkov
2026-04-07 10:21   ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox