public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Herve Codina" <herve.codina@bootlin.com>
Cc: "David Gibson" <david@gibson.dropbear.id.au>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Ayush Singh" <ayush@beagleboard.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	<devicetree-compiler@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree-spec@vger.kernel.org>,
	"Hui Pu" <hui.pu@gehealthcare.com>,
	"Ian Ray" <ian.ray@gehealthcare.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [RFC PATCH 15/15] Introduce v18 dtb version
Date: Wed, 08 Apr 2026 09:55:37 +0200	[thread overview]
Message-ID: <DHNM1XCPKD6P.1KD9C370G7H90@bootlin.com> (raw)
In-Reply-To: <20260407184423.3060f1cd@bootlin.com>

On Tue Apr 7, 2026 at 6:44 PM CEST, Herve Codina wrote:
> Hi Luca,
>
> On Wed, 01 Apr 2026 17:19:09 +0200
> "Luca Ceresoli" <luca.ceresoli@bootlin.com> wrote:
>
>> On Tue Feb 10, 2026 at 6:33 PM CET, Herve Codina wrote:
>> > This v18 version will add support for
>> >   - Structured tags.
>> >     Those tags value definition will allow old libfdt, dtc and other
>> >     tools to skip unknown tags if encountered in future dtb version.
>>
>> "old" seems to imply that versions released before today will be able to
>> wkip unknown tags. I think this should be clarified along the lines of:
>>
>>   libfdt, dtc and other tools implementing version v18 will be able to wkip
>>   unknown tags in dtbs generated with later versions of dtc
>
> Yes, I will add this clarification in the next iteration.
>
>>
>> >   - dt_flags header field.
>> >     For now this flag field is set to 0. It is a placeholder for future
>> >     dtb version and could be used to store some dtb related information
>> >     such as the kind of dtb.
>>
>> Is this intended for DT addons?
>>
>> You may mention a realistiv use case here.
>
> Intended, maybe not. Used by addons, yes, for sure.
>
> What do you think if I add the following:
>     For instance, the future addons format will use this field to
>     clearly identify that the dtb is an addon dtb.

This clarifies a lot to me, so I think it can be added to the commit
message.

>> > Compared to previous version, it is worth noting that the dtb is not
>>                                                                ^
>> 				                        "dtb version"
>>
>> > downgrade for all modification but only when unknown tags are removed
>>   ^
>>   downgraded for any
>>
>>
>> > due a property modification.
>>   ^
>>   "due to a ..."
>>
>> I'm not sure I got what you mean by the initial "Compared to previous
>> version". Version(s) of what?
>>
>> If I just remove those 4 words the sentence seems OK to me BTW.
>
> Is the following clearer?
>
>     It is worth noting that with this v18 version, the dtb version is not
>     downgraded for any modification but only when unknown tags are removed
>     due to a property modification. In v17 or older version any modification
>     led to a dtb version downgrade.

Yes, totally clear now, thanks!

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2026-04-08  7:55 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 17:33 [RFC PATCH 00/15] Add support for structured tags and v18 dtb version Herve Codina
2026-02-10 17:33 ` [RFC PATCH 01/15] dtc: Use a consistent type for basenamelen Herve Codina
2026-02-13  6:14   ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 02/15] fdtdump: Remove dtb version check Herve Codina
2026-02-14  2:12   ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 03/15] fdtdump: Return an error code on wrong tag value Herve Codina
2026-02-23  5:38   ` David Gibson
2026-02-23  8:39     ` Herve Codina
2026-02-24  5:57       ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 04/15] libfdt: fdt_rw: Introduce fdt_downgrade_version() Herve Codina
2026-02-24  6:09   ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 05/15] libfdt: Introduce fdt_first_node() Herve Codina
2026-04-01 15:11   ` Luca Ceresoli
2026-04-03  7:07     ` Herve Codina
2026-02-10 17:33 ` [RFC PATCH 06/15] libfdt: Don't assume that a FDT_BEGIN_NODE tag is available at offset 0 Herve Codina
2026-04-01 15:11   ` Luca Ceresoli
2026-04-07  8:51     ` Herve Codina
2026-02-10 17:33 ` [RFC PATCH 07/15] libfdt: fdt_check_full: Handle FDT_NOP when FDT_END is expected Herve Codina
2026-03-04 10:08   ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 08/15] tests: asm: Introduce treehdr_vers macro Herve Codina
2026-02-10 17:33 ` [RFC PATCH 09/15] Introduce structured tag value definition Herve Codina
2026-04-01 15:11   ` Luca Ceresoli
2026-04-07 11:42     ` Herve Codina
2026-02-10 17:33 ` [RFC PATCH 10/15] fdtdump: Handle unknown tags Herve Codina
2026-04-01 15:15   ` Luca Ceresoli
2026-04-07 14:03     ` Herve Codina
2026-04-07 15:46       ` Luca Ceresoli
2026-02-10 17:33 ` [RFC PATCH 11/15] flattree: " Herve Codina
2026-04-01 15:15   ` Luca Ceresoli
2026-02-10 17:33 ` [RFC PATCH 12/15] libfdt: Handle unknown tags in fdt_get_next() Herve Codina
2026-04-01 15:17   ` Luca Ceresoli
2026-04-07 14:29     ` Herve Codina
2026-02-10 17:33 ` [RFC PATCH 13/15] libfdt: Introduce fdt_ptr_offset_ Herve Codina
2026-04-01 15:18   ` Luca Ceresoli
2026-02-10 17:33 ` [RFC PATCH 14/15] libfdt: Handle unknown tags on dtb modifications Herve Codina
2026-04-01 15:18   ` Luca Ceresoli
2026-04-07 15:41     ` Herve Codina
2026-02-10 17:33 ` [RFC PATCH 15/15] Introduce v18 dtb version Herve Codina
2026-04-01 15:19   ` Luca Ceresoli
2026-04-07 16:44     ` Herve Codina
2026-04-08  7:55       ` Luca Ceresoli [this message]
2026-03-12  7:54 ` [RFC PATCH 00/15] Add support for structured tags and " Herve Codina
2026-03-12 10:21   ` David Gibson
2026-03-16 16:16     ` Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHNM1XCPKD6P.1KD9C370G7H90@bootlin.com \
    --to=luca.ceresoli@bootlin.com \
    --cc=ayush@beagleboard.org \
    --cc=conor+dt@kernel.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree-compiler@vger.kernel.org \
    --cc=devicetree-spec@vger.kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=herve.codina@bootlin.com \
    --cc=hui.pu@gehealthcare.com \
    --cc=ian.ray@gehealthcare.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox