From: Hardik Phalet <hardik.phalet@pm.me>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Hardik Phalet <hardik.phalet@pm.me>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Brigham Campbell" <me@brighamcampbell.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 2/4] dt-bindings: iio: magnetometer: Add binding for QST QMC5883P
Date: Sun, 12 Apr 2026 10:31:50 +0000 [thread overview]
Message-ID: <DHR3VMPNVUYG.15X09OF3SOTSO@pm.me> (raw)
In-Reply-To: <20260410-stimulating-happy-terrier-e82dcc@quoll>
On Fri Apr 10, 2026 at 1:25 PM IST, Krzysztof Kozlowski wrote:
> On Thu, Apr 09, 2026 at 09:07:29PM +0000, Hardik Phalet wrote:
>> Add the device tree binding document for the QST QMC5883P, a 3-axis
>> anisotropic magneto-resistive (AMR) sensor with a 16-bit ADC that
>> communicates over I2C. The binding exposes the required 'compatible'
>> and 'reg' properties along with an optional 'vdd-supply' for the
>> 2.5 V–3.6 V VDD rail.
>
> Drop last sentence. We can read the diff.
>
Noted.
> ...
>
>> +properties:
>> + compatible:
>> + const: qst,qmc5883p
>> +
>> + reg:
>> + maxItems: 1
>> + description: I2C address of the device; the default address is 0x2c.
>> +
>> + vdd-supply:
>> + description:
>> + VDD power supply (2.5 V to 3.6 V). Powers all internal analog and
>> + digital functional blocks.
>
> Supply should be required. Devices need them to operate.
My bad, I will fix this in the next series.
>
> Best regards,
> Krzysztof
Regards,
Hardik
next prev parent reply other threads:[~2026-04-12 10:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 21:07 [PATCH v2 0/4] Add QST QMC5883P magnetometer driver Hardik Phalet
2026-04-09 21:07 ` [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add QST Corporation Hardik Phalet
2026-04-10 7:52 ` Krzysztof Kozlowski
2026-04-12 10:30 ` Hardik Phalet
2026-04-09 21:07 ` [PATCH v2 2/4] dt-bindings: iio: magnetometer: Add binding for QST QMC5883P Hardik Phalet
2026-04-10 7:55 ` Krzysztof Kozlowski
2026-04-10 8:06 ` Krzysztof Kozlowski
2026-04-12 10:32 ` Hardik Phalet
2026-04-12 10:31 ` Hardik Phalet [this message]
2026-04-09 21:07 ` [PATCH v2 3/4] staging: iio: magnetometer: Add QST QMC5883P driver Hardik Phalet
2026-04-10 5:28 ` Greg Kroah-Hartman
2026-04-12 9:55 ` Hardik Phalet
2026-04-10 20:02 ` David Lechner
2026-04-12 9:54 ` Hardik Phalet
2026-04-12 18:52 ` David Lechner
2026-04-09 21:07 ` [PATCH v2 4/4] MAINTAINERS: Add entry for QST QMC5883P magnetometer driver Hardik Phalet
2026-04-10 19:32 ` David Lechner
2026-04-12 9:57 ` Hardik Phalet
2026-04-10 4:36 ` [PATCH v2 0/4] Add " Andy Shevchenko
2026-04-12 10:27 ` Hardik Phalet
2026-04-10 19:26 ` David Lechner
2026-04-12 10:05 ` Hardik Phalet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHR3VMPNVUYG.15X09OF3SOTSO@pm.me \
--to=hardik.phalet@pm.me \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@brighamcampbell.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox