From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71D353BBA07; Mon, 27 Apr 2026 12:59:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777294799; cv=none; b=Y5mDF5kGwEuFt+uASA5vUYEb50xgGXK0K8biwH6P6mstdLa12Jp+l0swEYPJNYcOq/d+9kl9iPk+bsTbwzJZYS2pHSva3m1/aLZCAOspmNwkm20uBzu7Us4Uz3ObAjNuM1ybWdZn12FUWyjFY7VkdJtm5TzUgxhev/LcCzSgMIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777294799; c=relaxed/simple; bh=8V1r61c1YDcfyb0te+S3PBFKsStolusEFex58/NJl7Q=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=jx8jGy07JJIcoJ+/b81+vyshq37UQkGcxI15D+oFSfNUFmnAhv6BY3wn5l0mamhT1GYuxalL+FRCm8Gqdri/QtPRPPGtkjnzlcAqvnwNEdflaWgR0LDQYau6gbXrSYmnZVzcmMvri0ul3LGWQ8GL60UKF0LAY4an5pAcMJibmRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KM19ZW6A; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KM19ZW6A" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E36D5C5CD48; Mon, 27 Apr 2026 13:00:38 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B81ED600D1; Mon, 27 Apr 2026 12:59:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1E5EF1072804C; Mon, 27 Apr 2026 14:59:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777294793; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=w1gq2kSLPRi8BDsMgY4czhQqlGkV5UyJsHxlDfVChz0=; b=KM19ZW6ABhnHYA6hBe+i6d5oGTfsERPMy9ZBlb6TXMxvbpEfHorIfO/ocCrZPQMj83+MMn WrD4/vTbGY6rM5cwa1G5nhIKmyZwF7QFL8+o25zNnOvvG/jh/xdbabGQtgw08qLzLadkNA chUGjND3ttfvUWbS6h1JpmC4LBiJh5KLijGlI/o8xH1uaR5QlibWlwsYuBtsx2A4z4qCtG hmpocuBB1sgz7UJbCtJkJ4N9n542wvcyqzOoR8Zc7rLbxjqeH2e+p95mVteN2TdGXD3UG3 cBQ7dp0YU54eialMN0ggw/T08DMOtO5qeg98RjTD0ZpS500TnopeLBbZtcZwTw== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 27 Apr 2026 14:59:47 +0200 Message-Id: Subject: Re: [PATCH v22 5/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY Cc: , , , , , , , "Alexander Stein" , "Ying Liu" To: "Laurentiu Palcu" , "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260424-dcss-hdmi-upstreaming-v22-0-30a28f89298d@oss.nxp.com> <20260424-dcss-hdmi-upstreaming-v22-5-30a28f89298d@oss.nxp.com> In-Reply-To: <20260424-dcss-hdmi-upstreaming-v22-5-30a28f89298d@oss.nxp.com> X-Last-TLS-Session-Version: TLSv1.3 Hello Laurentiu, On Fri Apr 24, 2026 at 1:07 PM CEST, Laurentiu Palcu wrote: > From: Sandor Yu > > Add bindings for Freescale iMX8MQ DP and HDMI PHY. > > Signed-off-by: Sandor Yu > Signed-off-by: Laurentiu Palcu > --- > .../bindings/phy/fsl,imx8mq-hdptx-phy.yaml | 80 ++++++++++++++++= ++++++ > 1 file changed, 80 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8mq-hdptx-phy.y= aml b/Documentation/devicetree/bindings/phy/fsl,imx8mq-hdptx-phy.yaml > new file mode 100644 > index 0000000000000..a24435139b8b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/fsl,imx8mq-hdptx-phy.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/fsl,imx8mq-hdptx-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence HDP-TX DP/HDMI PHY for Freescale i.MX8MQ SoC > + > +maintainers: > + - Sandor Yu Based on what you said in the cover, I guess this line will have to be changed. Are you willing to maintain this binding? > +description: > + The Cadence HDP-TX DP/HDMI PHY is a child node of the MHDP8501 bridge, > + sharing the same MMIO region as the parent bridge node. > + > +properties: > + compatible: > + const: fsl,imx8mq-hdptx-phy > + > + clocks: > + items: > + - description: PHY reference clock. > + - description: APB clock. > + > + clock-names: > + items: > + - const: ref > + - const: apb > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - clocks > + - clock-names > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + display-bridge@32c00000 { > + compatible =3D "fsl,imx8mq-mhdp8501"; > + reg =3D <0x32c00000 0x100000>; > + interrupts =3D , > + ; > + interrupt-names =3D "plug_in", "plug_out"; > + clocks =3D <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + phys =3D <&dp_phy>; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; The ports are not mentioned in the properties. I'm not a DT maintainer, but I think they should, e.g. to mention which port is the input and which is the output. > + > + port@0 { > + reg =3D <0>; > + endpoint { > + remote-endpoint =3D <&dcss_out>; > + }; > + }; > + > + port@1 { > + reg =3D <1>; > + endpoint { > + data-lanes =3D <2 1 0 3>; Having a remote-endpoint property would be nice here, to make the example more complete. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com