From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 167303859D5 for ; Fri, 1 May 2026 10:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777630330; cv=none; b=IH+7lvg5QpBvhbhWQKM9RqGownYhWq6qr79YivpDnzbU9hynT7fkP0j5uh/gOGYVVCsuh+wfnEwDzYSdJUgoRHlGYI+D2QED9szf4ft5q+CPK4Gj1rAxg7MOuw/hiNyv65wGqlaZ00yKyM3QsEw/ToCb4mBlY5DuLh7BAQHeIrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777630330; c=relaxed/simple; bh=AvAb+VClo4j0HIFtBFNn11Dt4inwSXzhC73YbSROzvQ=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Ey5yd6n1UQuxHId0FifwfMnJNj6V95p0TuDQyHWT6wq2zbnjYq6ul10YZbi9PWY3eQf8kLZ4MWX5Hs8HEQuaQLy1vskEgk7hM1uerHNPscgqNCTLY1xJrBR1YknLc9MZJlCp2JZP0XmdF3C7I4uFJzoC4mJwL30p9QlDUMKGwTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=cqaRvNPr; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="cqaRvNPr" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-449e96a8a80so785647f8f.3 for ; Fri, 01 May 2026 03:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1777630326; x=1778235126; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RF0fjg6u/pwfYA6LLXaoxUgWrAjG0ZfG5fQOPwpi1Kk=; b=cqaRvNPrGNQI+ytLz+wxRvb0uRUqd+4mRUUeMQzF3qd3PW60gky3e/WVqfkKiIi5V/ CYzBnutN6aqJLppfqowK+9XjIJBEnOd+5wO/YbDGkF7dwbzntpUweIIDLozt9zAzSQAL NXSodECjfdJ68KP05I+zNiz1vbGeVJXYD7ZMRzbmOJISF0Ke4TMV/pArA2hRdqosZQvG vlLE+wRe3EjUdJCtgL37pb8FQJLkVZgygHUM2sjbH0hza7VW1+rvsnJci4sGAgfWAKUO S1VaXAFZUuor1l/Lrx6Ypx3eH7gHl9P+kI/+C4XuqNKVDoFnbxgRfRkAd4aVNCNBBLih nzhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777630326; x=1778235126; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RF0fjg6u/pwfYA6LLXaoxUgWrAjG0ZfG5fQOPwpi1Kk=; b=CdaxFkpG+vvUmTUAimDChZGHhtFgYahNCX1tHGeo3sIuqP7/zhk5CQUnmwjyQ9HrzT /E9SCSIDgrE1u14vLlGIB8e+ny4W/UlAV9g1xVo14iWc3fT1veJHfq9okfrBtrtt9ttX Wv+CVrEfqOEdelJAEzzmB2HS98GN7YbKzaB6MRBtSlVGhq8+TYLZDY8mNUDm/ReYtpgs 46AB6MAOsoOaZoUvjNK+MOMo/Pgzt6Gp8Pkwi4/XIrpJ6ZtZMOVeE6VB8la/3kjNQOkF WkKRyH9EW2k8oXhqvp5ELRKMiECy9JvclYCICZPqX/X5c3NJ9xPoOfUjw7cm8FlfPGXk w/kw== X-Forwarded-Encrypted: i=1; AFNElJ8C5J8syHZ6hgJZpPSoJkAj+J0XRhgRSHV/NKH3Xh8dG31SpniUi1oLBk0Qac64mq8XMraaoHDyZ30K@vger.kernel.org X-Gm-Message-State: AOJu0YyMLacjLVFaZxkJpCFBXwjuj86XAXZcNCn2SyNk/F+LP2DeYvZh uzxNVWxRGKYbXGaL7NtvdfypP2Rd/9ItvJ6lRI/+bYajMv0OgvgjiZIAxPFCm88oluE= X-Gm-Gg: AeBDieuoD2/ju//QXGaUk64oURW1ezokTtNmUXzsudcc3RrhEpzCGUX9k7YJrGLkZyU UfStFkEI/EDgcV07QgVYWfhvB9VamhUhFQNNK4WjmAiNa2EL2uSjBl9oE76e0H9eAcvqRfDNWej AklZ0/FfF9DT0Efpq+CGXutd7wmnSdl6M59+V2V5PfR5SVGstRQWraudEnVoH9FU3IHEZK9b+uO xBFTfhuk+oid7fCifeKQFqzj6/dxPBfJZIJ0rjVQSG3q7+YYMJYa9j7JdWujqPlGmP2Jem0MD33 WegWgJGpSbiYDW28nv1xKX7bS9t06XPgWQP0T3+5XnpdGJv4JlSsx8Race4dLgyCsy/An+Uf9jl uIUOd0ftZGl99ypuGBLw88qXNsFWofULoOaFxg9vWRd6HpoNFoiTfFwyl3jmdCUsfxttQlvmvS9 TF4aKgMe5YtvCZ2lRaDH1J32GRcVsBA69zWHHrCWVVwg02jK12A/z7Qcv2F5K1Q4UJBt1mKuU= X-Received: by 2002:a05:6000:1a8a:b0:446:189c:ac4e with SMTP id ffacd0b85a97d-4493fa013fdmr10975312f8f.34.1777630326464; Fri, 01 May 2026 03:12:06 -0700 (PDT) Received: from localhost (046124199213.public.t-mobile.at. [46.124.199.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a8ea7cf97sm4324649f8f.6.2026.05.01.03.12.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2026 03:12:06 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 01 May 2026 12:12:04 +0200 Message-Id: Cc: "Konrad Dybcio" , "Bryan O'Donoghue" , "Conor Dooley" , "Robert Foss" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , "Krzysztof Kozlowski" , "Todor Tomov" , "Mauro Carvalho Chehab" , "Rob Herring" , "Krzysztof Kozlowski" , "Bjorn Andersson" Subject: Re: [PATCH v4 0/3] Add CAMSS support for SM6350 From: "Luca Weiss" To: "Bryan O'Donoghue" , "Luca Weiss" , "Vladimir Zapolskiy" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260216-sm6350-camss-v4-0-b9df35f87edb@fairphone.com> <2a108976-374a-46e1-968d-7befa4369a74@linaro.org> <4SLDL62Oin3XdiLjUEC_YAVA-m1dKV4j_8_RolU6NJFWCIWtem6e6sCb9n7OIHbcIWBfWdXx_vZy5mXCAbWUDg==@protonmail.internalid> In-Reply-To: Hi Bryan, On Fri Apr 3, 2026 at 5:07 PM CEST, Bryan O'Donoghue wrote: > On 03/04/2026 09:09, Luca Weiss wrote: >> Hi Vladimir, >>=20 >> On Tue Mar 31, 2026 at 12:49 AM CEST, Vladimir Zapolskiy wrote: >>> Hi Luca, >>> >>> On 2/16/26 10:54, Luca Weiss wrote: >>>> Add bindings, driver and dts to support the Camera Subsystem on the >>>> SM6350 SoC. >>>> >>>> These patches were tested on a Fairphone 4 smartphone with WIP sensor >>>> drivers (Sony IMX576 and IMX582), the camera pipeline works properly a= s >>>> far as I can tell. >>>> >>>> Though when stopping the camera stream, the following clock warning >>>> appears in dmesg. But it does not interfere with any functionality, >>>> starting and stopping the stream works and debugcc is showing 426.4 MH= z >>>> while the clock is on, and 'off' while it's off. >>>> >>>> Any suggestion how to fix this, is appreciated. >>> >>> I've looked at CAMCC recently, and I do notice that SM6350 CAMCC does n= ot >>> set '.use_rpm =3D true' flag for whatever reason. >>> >>> If you find a free minute, can you test the change below?.. >>=20 >> Unfortunately that change does not resolve the "gcc_camera_axi_clk >> status stuck at 'on'" warning. >>=20 >> fairphone-fp4:~$ cat /sys/bus/platform/drivers/sm6350-camcc/ad00000.cloc= k-controller/power/runtime_status >> active >>=20 >> fairphone-fp4:~$ cat /sys/bus/platform/drivers/sm6350-camcc/ad00000.cloc= k-controller/power/runtime_status >> suspended >>=20 >>> >>> ----8<---- >>> diff --git a/drivers/clk/qcom/camcc-sm6350.c b/drivers/clk/qcom/camcc-s= m6350.c >>> index 7df12c1311c6..ba880e4edcaf 100644 >>> --- a/drivers/clk/qcom/camcc-sm6350.c >>> +++ b/drivers/clk/qcom/camcc-sm6350.c >>> @@ -1880,6 +1880,7 @@ static const struct qcom_cc_desc camcc_sm6350_des= c =3D { >>> .num_clks =3D ARRAY_SIZE(camcc_sm6350_clocks), >>> .gdscs =3D camcc_sm6350_gdscs, >>> .num_gdscs =3D ARRAY_SIZE(camcc_sm6350_gdscs), >>> + .use_rpm =3D true, >>> }; >>> >>> static const struct of_device_id camcc_sm6350_match_table[] =3D { >>> ----8<---- >>> >>> This change could be considered to be included in any case, I believe. >>=20 >> I guess this change is now the way to enable pm_runtime, I had this >> series 3 years ago in February 2023: >> https://lore.kernel.org/linux-arm-msm/20230213-sm6350-camcc-runtime_pm-v= 3-0-d35e0d833cc4@fairphone.com/ >>=20 >> But I never followed up due to me not understanding pm_runtime well and >> no direct need for it. >>=20 >> But I guess reviving that with use_rpm =3D true, add power-domains & >> required-opps to dt-bindings and sm6350.dtsi should be a good idea? >>=20 >> Regards >> Luca >>=20 >>> >>>> [ 5738.590980] ------------[ cut here ]------------ >>>> [ 5738.591009] gcc_camera_axi_clk status stuck at 'on' >>>> [ 5738.591049] WARNING: CPU: 0 PID: 6918 at drivers/clk/qcom/clk-branc= h.c:87 clk_branch_toggle+0x170/0x190 >>>> [ 5738.591081] Modules linked in: >>>> [ 5738.591099] CPU: 0 UID: 10000 PID: 6918 Comm: plasma-camera Tainted= : G W 6.17.0-00057-ge6b67db49622 #71 NONE >>>> [ 5738.591118] Tainted: [W]=3DWARN >>>> [ 5738.591126] Hardware name: Fairphone 4 (DT) >>>> [ 5738.591136] pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS B= TYPE=3D--) >>>> [ 5738.591150] pc : clk_branch_toggle+0x170/0x190 >>>> [ 5738.591164] lr : clk_branch_toggle+0x170/0x190 >>>> [ 5738.591177] sp : ffff800086ed3980 >>>> [ 5738.591184] x29: ffff800086ed3990 x28: 0000000000000001 x27: ffff80= 0086ed3cd8 >>>> [ 5738.591208] x26: 0000000000000000 x25: ffffda14fcfbd250 x24: 000000= 0000000000 >>>> [ 5738.591230] x23: 0000000000000000 x22: ffffda14fc38bce0 x21: 000000= 0000000000 >>>> [ 5738.591252] x20: ffffda14fd33e618 x19: 0000000000000000 x18: 000000= 00000064c8 >>>> [ 5738.591274] x17: 0000000000000000 x16: 00001ae003667e9e x15: ffffda= 14fd2a07b0 >>>> [ 5738.591295] x14: 0000000000000000 x13: 6f27207461206b63 x12: 757473= 2073757461 >>>> [ 5738.591317] x11: 0000000000000058 x10: 0000000000000018 x9 : ffffda= 14fd2a0838 >>>> [ 5738.591338] x8 : 0000000000057fa8 x7 : 0000000000000a16 x6 : ffffda= 14fd2f8838 >>>> [ 5738.591360] x5 : ffff0001f6f59788 x4 : 0000000000000a15 x3 : ffff25= ecf9d7e000 >>>> [ 5738.591381] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff00= 00baf5c100 >>>> [ 5738.591403] Call trace: >>>> [ 5738.591412] clk_branch_toggle+0x170/0x190 (P) >>>> [ 5738.591429] clk_branch2_disable+0x1c/0x30 >>>> [ 5738.591445] clk_core_disable+0x5c/0xb4 >>>> [ 5738.591462] clk_disable+0x38/0x60 >>>> [ 5738.591478] camss_disable_clocks+0x44/0x78 >>>> [ 5738.591496] vfe_put+0x7c/0xc0 >>>> [ 5738.591512] vfe_set_power+0x40/0x50 >>>> [ 5738.591528] pipeline_pm_power_one+0x14c/0x150 >>>> [ 5738.591546] pipeline_pm_power+0x74/0xf4 >>>> [ 5738.591561] v4l2_pipeline_pm_use+0x54/0x9c >>>> [ 5738.591577] v4l2_pipeline_pm_put+0x14/0x40 >>>> [ 5738.591592] video_unprepare_streaming+0x18/0x24 >>>> [ 5738.591608] __vb2_queue_cancel+0x4c/0x314 >>>> [ 5738.591626] vb2_core_streamoff+0x24/0xc8 >>>> [ 5738.591643] vb2_ioctl_streamoff+0x58/0x98 >>>> [ 5738.591657] v4l_streamoff+0x24/0x30 >>>> [ 5738.591672] __video_do_ioctl+0x430/0x4a8 >>>> [ 5738.591689] video_usercopy+0x2ac/0x680 >>>> [ 5738.591705] video_ioctl2+0x18/0x40 >>>> [ 5738.591720] v4l2_ioctl+0x40/0x60 >>>> [ 5738.591734] __arm64_sys_ioctl+0x90/0xf0 >>>> [ 5738.591750] invoke_syscall.constprop.0+0x40/0xf0 >>>> [ 5738.591769] el0_svc_common.constprop.0+0x38/0xd8 >>>> [ 5738.591785] do_el0_svc+0x1c/0x28 >>>> [ 5738.591801] el0_svc+0x34/0xe8 >>>> [ 5738.591820] el0t_64_sync_handler+0xa0/0xe4 >>>> [ 5738.591838] el0t_64_sync+0x198/0x19c >>>> [ 5738.591854] ---[ end trace 0000000000000000 ]--- >>>> >>>> Signed-off-by: Luca Weiss >>>> --- >>>> Changes in v4: >>>> - Update power-domain-names order (Krzysztof) >>>> - Make hex numbers lower case in init seq (David) >>>> - Pick up tags >>>> - Link to v3: https://lore.kernel.org/r/20260213-sm6350-camss-v3-0-30a= 845b0b7cc@fairphone.com >>> >>> Should find some time myself to issue RBs, sorry for the delay. >>> >>>> Changes in v3: >>>> - Update dt-bindings to include everything related to camss >>>> - Update regulator names >>>> - Remove slow_ahb_src >>>> - Link to v2: https://lore.kernel.org/r/20251114-sm6350-camss-v2-0-d1f= f67da33b6@fairphone.com >>>> >>>> Changes in v2: >>>> - Remove prefix from interconnect-names >>>> - Move 'top' power-domain to the top of list >>>> - Update regulator supply names >>>> - Link to v1: https://lore.kernel.org/r/20251024-sm6350-camss-v1-0-63d= 626638add@fairphone.com >>>> >>>> --- >>>> Luca Weiss (3): >>>> dt-bindings: media: camss: Add qcom,sm6350-camss >>>> media: qcom: camss: Add SM6350 support >>>> arm64: dts: qcom: sm6350: Add CAMSS node >>>> >>>> .../bindings/media/qcom,sm6350-camss.yaml | 471 ++++++++++= +++++++++++ >>>> arch/arm64/boot/dts/qcom/sm6350.dtsi | 233 ++++++++++ >>>> .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 125 ++++++ >>>> drivers/media/platform/qcom/camss/camss-vfe.c | 2 + >>>> drivers/media/platform/qcom/camss/camss.c | 261 ++++++++++= ++ >>>> drivers/media/platform/qcom/camss/camss.h | 1 + >>>> 6 files changed, 1093 insertions(+) >>>> --- >>>> base-commit: 3daf23347bb5f4a375d0101ed29c97ce1a99721b >>>> change-id: 20251024-sm6350-camss-9c404bf9cfdd >>>> >>>> Best regards, >>=20 > > What about taking the clock out of hardware gated mode ? > > =E2=94=8C=E2=94=80[deckard@sagittarius-a] - [~/Development/qualcomm/qlt-k= ernel] - [Fri=20 > Apr 03, 16:05] > =E2=94=94=E2=94=80[$]> git diff > diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.= c > index a4d6dff9d0f7f..f98cb35bcd408 100644 > --- a/drivers/clk/qcom/gcc-sm6350.c > +++ b/drivers/clk/qcom/gcc-sm6350.c > @@ -909,8 +909,6 @@ static struct clk_branch gcc_camera_ahb_clk =3D { > static struct clk_branch gcc_camera_axi_clk =3D { > .halt_reg =3D 0x17018, > .halt_check =3D BRANCH_HALT, > - .hwcg_reg =3D 0x17018, > - .hwcg_bit =3D 1, Unfortunately this change has no effect, still getting the same error [ 192.154311] ------------[ cut here ]------------ [ 192.154339] gcc_camera_axi_clk status stuck at 'on' [ 192.154364] WARNING: drivers/clk/qcom/clk-branch.c:87 at clk_branch_togg= le+0x170/0x190, CPU#5: CameraManager/5996 [ 192.154387] Modules linked in: [ 192.154403] CPU: 5 UID: 10000 PID: 5996 Comm: CameraManager Tainted: G = W 7.0.0-00074-gb9262f98394c-dirty #31 PREEMPTLAZY Regards Luca