From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6241F30EF7E for ; Fri, 1 May 2026 13:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777641193; cv=none; b=DyHnAGRS54h5iZ78+WLNqFNHvmSaE9SDG62PwGaeakdKx+ALpTRXFMqf+J2GpIewqvToblMR2C9qBTZFTcDGr7CIJNaMFQ8ZHwt8WePVfvchUA0mRejRxqGhskfQ+mYMD/oQmUXYDB4bBJ7zPqXs9wKteoi3pD1JWHXVE+eMfw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777641193; c=relaxed/simple; bh=rd97/uXPxqn6H288Jjs0bKv8wRFMIpNUEz/u8OXZoDA=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=SggQKr1AxUDKZDEIprQUBpV1txSpzcaOQkcKhxW9dBkWV763Pi7mFi9NJplU8Qn3umHXE6cmuhLg/K8D7Pu9vEp9e0OH1eD0c6ALoHzYX/P1Yt4HCWbkenwxYwaoREfudOafyqE6kVYb6eg7SEPsPxwwMlHaBOBl64W4VZlq8Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UusdDTsN; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UusdDTsN" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso28685485e9.1 for ; Fri, 01 May 2026 06:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777641190; x=1778245990; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qkMubkfdTMo3EqsOQjlsb5eV0ALKcf2vjXa+TTJKq1E=; b=UusdDTsNNv4b1wOapkIQ49PIxRSYv5MAUP09w3z3f9e1idROGT5PShzf7A2F7dXGpG OTRIw6Pz2OtFKJweVe7EDJJjG0W1vExPURNhLGGdZ7kaXqL1DIQTectci97Rm3C3IKYY mF7rRQ5c9H2Uv0YJ5Hzz/O4KjIssOLGIu9xe22Hy3Bfuwa3xYj95FrAZJUPLAr0B7+pq DDRidqOHkogejXHTEzajnssKw4TIa7/4t0QFutvEF8AibgaG1OcpK8i22O1t1r0Cie1+ D+4VuqUnR8U/GwQUqgXNx/Rc1+gVOsFmI5Bovd+PtLwmrUFBwKvNt6JgkdPOKI7TKtdv FddA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777641190; x=1778245990; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qkMubkfdTMo3EqsOQjlsb5eV0ALKcf2vjXa+TTJKq1E=; b=j+wZ83Wrq8uywdro3iqBlj224bRhDWs9A3ab5HI901AOXrcLEVapy4QNyztQ8CuhDx GrsWxCI+leXq5PATRyjUSnyXf2ztg92pTO1z3PKHd01TLZ1/oDzL6fkZwr38ebAQqdRG suuZpFL5Qf2OUAy1ipw6OkQ7C3aihgiD873z9bLuLveSW06ftk+MG4qWPwZ3VDGeMDD8 WDuTs85w/mmRGD9ieT1Ukei4EY2vz2ehywAYIeeiF/V/tDcnw5DOlBeJlDdRREQ6esNq 3bJZma+6H+5/6I8NPC5N6ob9t8QruRwfnWah6ul6xxzgYXww2Mg9mlKnLybRq9q71GiY MaLw== X-Forwarded-Encrypted: i=1; AFNElJ+ohXQxJsUjQj6DBXL0ystslgI+vKdmlabiOsoNMqoZT+TttYES/DQLqoAw16i5zRG2sEL16DwlNx50@vger.kernel.org X-Gm-Message-State: AOJu0Yyphnbzz/IqRVFoP9ZIgjk6BbPd2vR6d9mfIP9/8emNej9uZfpE 9va/ZZ2w0tE0Orxd+rqGoqVs7zH9wpvXHn/uiM8X1PDA3j4pPo8fR45bjvsMGUulQzE= X-Gm-Gg: AeBDievQkYOfdUE8xW49pg8yJaWdE3X4YRMsbY1d7axcJ0VXcTN16EVeq5oIZ4nrNtO Jm6BBI5l03Kb0hevra72P24dRwxe2WDLzDq29ozFBXtWllNyoC5VKQrPvMBogb+A2lMB3+5Jc75 ARi9DIwJeLM7btNczDLBB20OqzbaVkgEAgeHgyHmJ5wVIQ0S2gX2kn0vvENWOV0Tg7G6Qr8e3Vs vsiDaIIgnGonZ6hphXwSnD9aDmZMG374F6AGPkQdHh3/z76DsDEQOuwilA+b82A+jPqOLHaJk8v DtMY3l6w+Gtuv9I3Lsq2TeW4TtBPf/rCqk/w4KhjFzGM/stFBlN3QUQpTrn1FGPvF5c+IgsRuAm rAY/Yt5VbAAc8oDSjCSfJ7qGGgsa/wA2LDLuGnb1xMNt6XlAsPsvhsohYlorQEuTsktmDrRDeYs QJh4bkBnb1g+daM8o4rlMGVI4S37uoSdrrP7FfZJIaqmYCBv3/k9nbc4UuvabgbB4V10M8Wb04L nuJP++btPjIKG7YSnmwqW9L X-Received: by 2002:a05:600c:6291:b0:48a:79d8:a8d6 with SMTP id 5b1f17b1804b1-48a85e75173mr108865535e9.7.1777641189806; Fri, 01 May 2026 06:13:09 -0700 (PDT) Received: from localhost ([94.4.195.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb6fffcsm56790225e9.4.2026.05.01.06.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2026 06:13:09 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 01 May 2026 14:13:07 +0100 Message-Id: Cc: , , , , , , , , , , "Krzysztof Kozlowski" Subject: Re: [PATCH v4 00/11] thermal: samsung: Add support for Google GS101 TMU From: "Alexey Klimov" To: "Tudor Ambarus" , "Rafael J. Wysocki" , "Zhang Rui" , "Lukasz Luba" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Krzysztof Kozlowski" , "Alim Akhtar" , "Bartlomiej Zolnierkiewicz" , "Kees Cook" , "Gustavo A. R. Silva" , "Peter Griffin" , =?utf-8?q?Andr=C3=A9_Draszik?= , "Daniel Lezcano" , "Sylwester Nawrocki" , "Chanwoo Choi" , "Michael Turquette" , "Stephen Boyd" , "Lee Jones" X-Mailer: aerc 0.21.0 References: <20260423-acpm-tmu-v4-0-8b59f8548634@linaro.org> In-Reply-To: <20260423-acpm-tmu-v4-0-8b59f8548634@linaro.org> On Thu Apr 23, 2026 at 4:22 PM BST, Tudor Ambarus wrote: > Add support for the Thermal Management Unit (TMU) on the Google GS101 > SoC. > > The GS101 TMU implementation utilizes a hybrid architecture where > management is shared between the kernel and the Alive Clock and > Power Manager (ACPM) firmware. This hybrid ACPM TMU architecture is=20 > also present on other Samsung Exynos SoCs (e.g., AutoV920, Exynos850). > > Dependencies > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - context dependency on the ACPM fixes sent at: > Link: https://lore.kernel.org/linux-samsung-soc/20260423-acpm-fixes-sas= hiko-reports-v1-0-2217b790925e@linaro.org/T/#t > - cleanup and prep firmware patches 2, 3, 4, 5, 6, 7: required by the > thermal driver (patch 8). > - bindings (patch 1): required for DTS validation. > - thermal driver patch 8: required by defconfig (patch 11) - logical > dependency.=20 I've took series locally using b4 and result doesn't compile: CC [M] drivers/firmware/samsung/exynos-acpm.o drivers/firmware/samsung/exynos-acpm.c:485:13: error: static declaration of= =E2=80=98acpm_set_xfer=E2=80=99 follows non-static declaration 485 | static void acpm_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t = cmdcnt, | ^~~~~~~~~~~~~ In file included from drivers/firmware/samsung/exynos-acpm.c:31: drivers/firmware/samsung/exynos-acpm.h:20:6: note: previous declaration of = =E2=80=98acpm_set_xfer=E2=80=99 with type =E2=80=98void(struct acpm_xfer *,= u32 *, size_t, unsigned int, bool)=E2=80=99 {aka =E2=80=98void(struct ac= pm_xfer *, unsigned int *, long unsigned int, unsigned int, _Bool)=E2=80= =99} 20 | void acpm_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t cmdcnt, | ^~~~~~~~~~~~~ drivers/firmware/samsung/exynos-acpm.c:485:13: warning: =E2=80=98acpm_set_x= fer=E2=80=99 defined but not used [-Wunused-function] 485 | static void acpm_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t = cmdcnt, | ^~~~~~~~~~~~~ make[5]: *** [scripts/Makefile.build:289: drivers/firmware/samsung/exynos-a= cpm.o] Error 1 (applies cleanly though). Could be related to "[PATCH v4 02/11] firmware: samsung: acpm: Consolidate transfer initialization helper". Anything missing from dependencies/prerequisites? [..] > Tudor Ambarus (11): > dt-bindings: thermal: Add Google GS101 TMU > firmware: samsung: acpm: Consolidate transfer initialization helper > firmware: samsung: acpm: Annotate rx_data->cmd with __counted_by_pt= r > firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops mem= bers > firmware: samsung: acpm: Make acpm_ops const and access via pointer > firmware: samsung: acpm: Add TMU protocol support > firmware: samsung: acpm: Add devm_acpm_get_by_phandle helper > thermal: samsung: Add Exynos ACPM TMU driver GS101 > MAINTAINERS: Add entry for Samsung Exynos ACPM thermal driver > arm64: dts: exynos: gs101: Add thermal management unit > arm64: defconfig: enable Exynos ACPM thermal support > > .../bindings/thermal/google,gs101-tmu-top.yaml | 68 +++ > MAINTAINERS | 8 + > arch/arm64/boot/dts/exynos/google/gs101-tmu.dtsi | 136 +++++ > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 18 + > arch/arm64/configs/defconfig | 1 + > drivers/clk/samsung/clk-acpm.c | 8 +- > drivers/firmware/samsung/Makefile | 1 + > drivers/firmware/samsung/exynos-acpm-dvfs.c | 20 +- > drivers/firmware/samsung/exynos-acpm-pmic.c | 20 +- > drivers/firmware/samsung/exynos-acpm-tmu.c | 240 +++++++++ > drivers/firmware/samsung/exynos-acpm-tmu.h | 28 ++ > drivers/firmware/samsung/exynos-acpm.c | 113 +++-- > drivers/firmware/samsung/exynos-acpm.h | 2 + > drivers/mfd/sec-acpm.c | 6 +- > drivers/thermal/samsung/Kconfig | 17 + > drivers/thermal/samsung/Makefile | 2 + > drivers/thermal/samsung/acpm-tmu.c | 547 +++++++++++++++= ++++++ > .../linux/firmware/samsung/exynos-acpm-protocol.h | 32 +- > 18 files changed, 1195 insertions(+), 72 deletions(-) > --- > base-commit: 2e68039281932e6dc37718a1ea7cbb8e2cda42e6 > change-id: 20260113-acpm-tmu-27e21f0e2c3b > prerequisite-change-id: 20260423-acpm-fixes-sashiko-reports-ae28b6ed5581:= v1 > prerequisite-patch-id: 18d89d0e2bc0efe2cb366746ac4db36f4682f061 > prerequisite-patch-id: eb4f90add371877a1930c442c5464c4da7242889 > prerequisite-patch-id: 021cd1ee6d2b93f554dd5098cd1158977294dc41 > prerequisite-patch-id: b5da16b5c6d6731ea519ed68302fd52ce57c7ffa Best regards, Alexey