From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34F3362154 for ; Tue, 9 Jun 2026 19:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034752; cv=none; b=btLut41SS8WDG9AqDhDH03f8jZZQb5eC9a9NxukNoObPM2QaJ5AlGyaaY5Q19QJDSoKdPwWxr2LPpcpffdTQC7NYaD+fjwoz3u5HppYU1eyPtMJhHtjd5aol4OQCFQFErDlxcWE0OEHsbh5QX6z6DE1mPhuY7kx9c5oUECRWIAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034752; c=relaxed/simple; bh=K1T6VA2P8uQBC9Qz6EIOyWqlugokZJCAHS6tuHawKh8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=p8GkbvHO/HKLpmxQ5Rs/x6C0OtXaOiqlBXEhTWAF4DHeCdq5xP4axOtO5LgJEs5qP3IKJ3+TumvOzB98cd4zWpKS7UGgYWzCBm6miD7Fa/sr2KBYDbDLFd6WAwSOnPasH+X2i4iy7nFIQAevIGP2ltKJ3WxVn7ag5u0Fa98exNQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=AOeaBGzl; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="AOeaBGzl" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1781034734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FmI8PUvl0y9cOUVYzfjTqYiM/XJNLR0tm65qzan3Ppo=; b=AOeaBGzl7oMpuwX23rf7rzw3qcQOe4ogFQhAi5TCmbEhKy3OJ3PlVbsf3fkxMKcPI59mwR IN4//tCOpt2V8cRmt5BBAi90+ch/VAQ66+lTqMTJOo9bUJ0uGtatt4sPivCzQyNDNV3Db2 3z3QYkUdr4UliUsE9o6zoJfhFAFnzAxhO3L8BinjviZNYhJ66T+37dM7iPVWHOQH81gWe+ /KgeVxgk3g7Or73PDL87I8Q6IZVMpzUPENF7OkqgW7A/PzF1kThV5qvFG03roQQrjdgn8I qCjl5MaVs+zzOkXkO3WH4KqZrOI9EbX0EdR4ape2N8QTMKEp/i6VXf1k0Hk/Qw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 09 Jun 2026 21:51:58 +0200 Message-Id: Cc: "Heiko Stuebner" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Greg Kroah-Hartman" , "devicetree@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] dt-bindings: usb: Add Rockchip RK3568 compatible for EHCI and OHCI X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Jonas Karlman" , "Diederik de Haas" References: <20260609154124.445182-1-jonas@kwiboo.se> <20260609154124.445182-2-jonas@kwiboo.se> <9e8f806d-72ec-4eb4-8967-3f82eb0e7dd4@kwiboo.se> In-Reply-To: <9e8f806d-72ec-4eb4-8967-3f82eb0e7dd4@kwiboo.se> X-Migadu-Flow: FLOW_OUT Hi Jonas, On Tue Jun 9, 2026 at 8:06 PM CEST, Jonas Karlman wrote: > Hi Diederik, > > On 6/9/2026 6:32 PM, Diederik de Haas wrote: >> Hi Jonas, >>=20 >> On Tue Jun 9, 2026 at 5:41 PM CEST, Jonas Karlman wrote: >>> The Rockchip RK3568 EHCI/OHCI controller depends on clk_usbphy1_480m >>> being enabled, or the system may freeze when registers are accessed. >>> >>> Add Rockchip RK3568 EHCI and OHCI compatibles with a similar four-clock >>> constraint as RK3588. >>> >>> Signed-off-by: Jonas Karlman >>> --- >>> Existing DTs for RK3568 use the plain generic-ehci/ohci compatible, >>> next patch make use of these new compatibles and adds the missing >>> clk_usbphy1_480m clock references. >>> --- >>> .../devicetree/bindings/usb/generic-ehci.yaml | 10 ++++++++++ >>> .../devicetree/bindings/usb/generic-ohci.yaml | 5 ++++- >>> 2 files changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/= Documentation/devicetree/bindings/usb/generic-ehci.yaml >>> index 55a5aa7d7a54..c49a1bbc8cfd 100644 >>> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml >>> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml >>> @@ -52,6 +52,7 @@ properties: >>> - ibm,476gtr-ehci >>> - nxp,lpc1850-ehci >>> - qca,ar7100-ehci >>> + - rockchip,rk3568-ehci >>> - rockchip,rk3588-ehci >>> - snps,hsdk-v1.0-ehci >>> - socionext,uniphier-ehci >>> @@ -186,6 +187,15 @@ allOf: >>> required: >>> - clocks >>> - clock-names >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + const: rockchip,rk3568-ehci >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 4 >>=20 >> I think that the constraint for rk3588 is this: >> - minItems: 1 >> - maxItems: 4 >>=20 >> Like ~ every other compatible; there's no 'branch' for rk3588-ehci. >>=20 >> That's different from what you add for rk3568. Is that deliberate? >> Because from the commit message I assumed they should be the same. > > It was deliberate, the intention is to use min/maxItems: 4 for rk3568 Thanks :-) > for both EHCI and OHCI. I left out anything related to k3588 to keep > existing behavior and avoid any possible breakage, and why I used > 'similar' and not 'same' in the commit message ;-) > > Did a check and the rk3588 variant also uses 4 clocks so I will add same > constraint for the rk3588 variant and address Sashiko's concern in v2. FWIW: I would be absolutely fine if you restrict this patch set to just RK3= 568. For the same reason you mentioned. All I wanted to know if it was deliberat= e and you confirmed that :-) Cheers, Diederik > Regards, > Jonas > >>=20 >>> unevaluatedProperties: false >>> =20 >>> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/= Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> index d42f448fa204..5f1b4d2bff89 100644 >>> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> @@ -47,6 +47,7 @@ properties: >>> - hpe,gxp-ohci >>> - ibm,476gtr-ohci >>> - ingenic,jz4740-ohci >>> + - rockchip,rk3568-ohci >>> - rockchip,rk3588-ohci >>> - snps,hsdk-v1.0-ohci >>> - const: generic-ohci >>> @@ -198,7 +199,9 @@ allOf: >>> properties: >>> compatible: >>> contains: >>> - const: rockchip,rk3588-ohci >>> + enum: >>> + - rockchip,rk3568-ohci >>> + - rockchip,rk3588-ohci >>=20 >> Here they clearly do have the same constraint. >>=20 >> Cheers, >> Diederik >>=20 >>> then: >>> properties: >>> clocks: >>=20