Re: [PATCH 2/5] iio: adc: Add ti-ads1262 driver

["Kurt Borja" <kuurtb@gmail.com>]

On Sun Jun 14, 2026 at 11:33 PM -05, Krzysztof Kozlowski wrote:
> On 14/06/2026 15:39, Jonathan Cameron wrote:
>> 
>>>> +
>>>> +DEFINE_RUNTIME_DEV_PM_OPS(ads1262_runtime_pm, ads1262_runtime_suspend,
>>>> +			  ads1262_runtime_resume, NULL);
>>>> +
>>>> +static const struct of_device_id ads1262_of_match[] = {
>>>> +	{ .compatible = "ti,ads1262" },
>>>> +	{ .compatible = "ti,ads1263" },  
>>>
>>> So devices are fully compatible? Then it should be expressed in the
>>> binding and drop one entry here.
>> 
>> They aren't. It's relying on one of them having a subnode that spins up an
>
> I don't  see anything in the this patch that would be using the other
> compatible, so driver looks like handling it fully compatible.
>
>
>
>> auxdev for the hardware block they don't share.  A fallback would be fine
>
> Patch #5 adding auxdev still does it uncoditionally, thus driver
> clearly treats them as 100% compatible.
>
> Or I missed piece of code - please point me where is any incompatible
> behavior coded.

You're right, Jonathan mentioned the same thing. This was the only check
when creating the auxiliary device.

	node = device_get_named_child_node(dev, "adc");
	if (!node)
		return 0;

But I should definitely check if chip is actually ads1263. I just
assumed user would know better, but I'm dropping the subnode anyway so
I'll check the model.

>
>
>
> Best regards,
> Krzysztof

-- 
Thanks,
 ~ Kurt