Re: [PATCH 02/12] dt-bindings: soc: fsl: qe: Set #interrupt-cells to 2 to support interrupt type encoding

["Paul Louvel" <paul.louvel@bootlin.com>]

On Fri Jul 3, 2026 at 3:40 PM CEST, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Schema unconditionally changes `#interrupt-cells` from 1 to 2, breaking backward compatibility with existing single-cell device trees.
> --
>
> commit ea9fdfe75d38976a589a83706c16b469e2657dbe
> Author: Paul Louvel <paul.louvel@bootlin.com>
>
> dt-bindings: soc: fsl: qe: Set #interrupt-cells to 2 to support interrupt type encoding
>
> This commit updates the #interrupt-cells property constraint in the FSL QE
> ports interrupt controller binding to support interrupt type encoding. It
> changes the required value from 1 to 2.
>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,qe-ports-ic.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,qe-ports-ic.yaml
>> index 2b8e7b9c6d7a4..2b7c6b4f03892 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,qe-ports-ic.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,qe-ports-ic.yaml
>> @@ -23,7 +23,7 @@ properties:
>>      const: 0
>>  
>>    '#interrupt-cells':
>> -    const: 1
>> +    const: 2
>
> [Severity: Medium]
> Does this unconditional change to const: 2 break backward compatibility with
> existing device trees?

Yes, unfortunatly.
An '#interrupt-cells' value of 1 was a mistake in the first place, because the
interrupt controller supports multiple interrupt types.

>
> Device tree bindings are generally considered ABI. By removing const: 1,
> schema validation (dtbs_check) will fail for any existing device tree blobs
> that use #interrupt-cells = <1>.
>
> Should this be updated to allow both values (e.g., enum: [1, 2]) to safely
> expand the cell counts while maintaining compatibility with older device
> trees?

Should this advice be taken into account ?

Thanks,
Paul.




-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com