Re: [PATCH v3 0/3] soc: apple: Add "PMGR misc" power controls driver

["Joshua Peisach" <jpeisach@ubuntu.com>]

On Sun Jul 5, 2026 at 4:16 AM EDT, Sasha Finkelstein wrote:
> Certain Apple SoCs have additional power state controls that are using
> a separate "misc" mmio interface. Currently this includes the fabric
> and memory controllers on pro/max/ultra SoCs.
>
> This series adds a driver to put those in a low power state when the
> machine enters sleep. The power savings are SoC-dependent and are
> around 1W.
>
> Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
> ---
> Changes in v3:
> - Remove ability to probe only one control, it is not used anyway
> - Allow building as module
> - Style fixes
> - Link to v2: https://patch.msgid.link/20260703-pmgr-misc-v2-0-4b26ba10c5a4@chaosmail.tech
>
> Changes in v2:
> - Error handling fixes
> - Reword binding description
> - Link to v1: https://patch.msgid.link/20260702-pmgr-misc-v1-0-4f075a3a95c1@chaosmail.tech
>
> ---
> Hector Martin (1):
>       soc: apple: Add driver for Apple PMGR misc controls
>
> Sasha Finkelstein (2):
>       dt-bindings: soc: apple: Add Apple PMGR misc controls
>       arm64: dts: apple: Add pmgr-misc nodes to t60xx
>
>  Documentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml |  45 +++++++++++++++++++++++++++
>  MAINTAINERS                                                            |   1 +
>  arch/arm64/boot/dts/apple/t600x-die0.dtsi                              |   7 +++++
>  arch/arm64/boot/dts/apple/t602x-die0.dtsi                              |   7 +++++
>  drivers/soc/apple/Kconfig                                              |  10 ++++++
>  drivers/soc/apple/Makefile                                             |   2 ++
>  drivers/soc/apple/apple-pmgr-misc.c                                    | 181 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 253 insertions(+)
> ---
> base-commit: e5d9690657844a2645a518cdf838206f6daf513e
> change-id: 20260702-pmgr-misc-ae1cbd5bc2c7
>
> Best regards,
> --  
> Sasha Finkelstein <k@chaosmail.tech>

Seems fine.

Reviewed-by: Joshua Peisach <jpeisach@ubuntu.com>