From: "Carlo Caione" <ccaione@baylibre.com>
To: <sashiko-reviews@lists.linux.dev>, "Carlo Caione" <ccaione@baylibre.com>
Cc: <devicetree@vger.kernel.org>, <robh@kernel.org>, <conor+dt@kernel.org>
Subject: Re: [PATCH v2 2/2] serial: 8250_mtk: honor DT serial aliases
Date: Mon, 27 Jul 2026 09:53:52 +0200 [thread overview]
Message-ID: <DK96WIHYRFSG.1E1TNF8OW6SU0@baylibre.com> (raw)
In-Reply-To: <20260727075153.4F9111F000E9@smtp.kernel.org>
On Mon Jul 27, 2026 at 9:51 AM CEST, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] The driver registers the 8250 port before enabling runtime PM, violating TTY subsystem guidelines and causing circular dependencies during probe.
> - [High] An integer overflow in baud rate calculation can cause a divide-by-zero kernel panic and incorrect fractional divisor calculations.
[...]
> [Severity: High]
> This is a pre-existing issue, but while looking at mtk8250_probe(), I noticed
[...]
> [Severity: High]
> This is another pre-existing issue, but I noticed a potential integer overflow
This is annoying. I'm NOT fixing pre-existing issue. There will always
be pre-existing issue.
--
Carlo Caione
next prev parent reply other threads:[~2026-07-27 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 7:38 [PATCH v2 0/2] Stabilize serial line numbers on MediaTek boards Carlo Caione
2026-07-27 7:38 ` [PATCH v2 1/2] arm64: dts: mediatek: alias all enabled serial ports Carlo Caione
2026-07-27 9:49 ` Chen-Yu Tsai
2026-07-27 11:30 ` AngeloGioacchino Del Regno
2026-07-27 11:49 ` Carlo Caione
2026-07-27 7:38 ` [PATCH v2 2/2] serial: 8250_mtk: honor DT serial aliases Carlo Caione
2026-07-27 7:51 ` sashiko-bot
2026-07-27 7:53 ` Carlo Caione [this message]
2026-07-27 9:39 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK96WIHYRFSG.1E1TNF8OW6SU0@baylibre.com \
--to=ccaione@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox