From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5A8C001DB for ; Mon, 14 Aug 2023 08:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233406AbjHNIXB (ORCPT ); Mon, 14 Aug 2023 04:23:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233178AbjHNIW3 (ORCPT ); Mon, 14 Aug 2023 04:22:29 -0400 Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [5.144.164.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D3682728 for ; Mon, 14 Aug 2023 01:21:58 -0700 (PDT) Received: from [192.168.2.144] (bband-dyn221.178-41-211.t-com.sk [178.41.211.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id B9E2A1F4A4; Mon, 14 Aug 2023 10:21:55 +0200 (CEST) Date: Mon, 14 Aug 2023 10:21:49 +0200 From: Martin Botka Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio Message-Id: In-Reply-To: <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> References: <20230814-sid-h616-v2-0-0267749b4471@somainline.org> <20230814-sid-h616-v2-1-0267749b4471@somainline.org> <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski wrote: > On 14/08/2023 08:38, Martin Botka wrote: >> Add binding for the SID controller found in H616 SoC >> >> Signed-off-by: Martin Botka >> --- >> >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> index 296001e7f498..2ec0a1b8f803 100644 >> --- >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> +++ >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> @@ -27,6 +27,7 @@ properties: >> - const: allwinner,sun50i-a64-sid >> - const: allwinner,sun50i-h5-sid >> - const: allwinner,sun50i-h6-sid >> + - const: allwinner,sun50i-h616-sid > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > Best regards, > Krzysztof > Yea completely forgot. Sorry for that. Will send v3 tomorrow with proper binding patch using items with enums