From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5340837CD5A for ; Mon, 10 Aug 2026 23:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403375; cv=none; b=ZF9mZwkHiiefIlN+9TEnIQSGgugi+ef9UzSnAG607jpxOXplfMClLYZjHY1MbHw61LRqo0D/s+nNW38QRcb6CinDtow8g4t1iuF96MMxPjQh5vh+5tuRpzIf3xIUy1Km7Cdj9mgxiGwbsZCEbchR9NybNfCQzx/eKJeAeU2qsgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403375; c=relaxed/simple; bh=X71rJPEpNGMX6fN3SCSNqa8xVuuAFnkmXfXpfSjM03A=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=cF40W5eBQ5/zXnTg//IyMuwia0Yyc98TAigmGG/oSmmPYuPfXoXPS+EkD1btIN5X2kfesGr0bsN0PxHq4yoNa2BNlQNydOyTDWPYpsQeaEpMymTzrkcHfezOj4/UbodwEUC0kXDLcP8O1alhdUANa4zzqDw5dH6W8MFo/CV1mpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EdH9zU1E; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EdH9zU1E" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4954df200ddso16031115e9.0 for ; Mon, 10 Aug 2026 16:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786403372; x=1787008172; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=IcYQ3EWiq+eD/+Q1XDAVHfH1xJiNbgDpsgmEp6vqXP0=; b=EdH9zU1EOaoGe1O4/F480a8328WuOi0isbKkVEp6ZkOIC+yWgaialhfrJ9J1mhgCz+ 3ehVVp4/KfBCBct8piMX0Z1Kf/iEPrIfe4gurTK9RlfrG+fZfG5t7XBIWZVCH0IgF6W1 A85doCB9j8sCPlp0rbr89d6VZixiP2kdyu3bueAaRRwg9FwA65CJ8XppJt+wmyMH86HK JJzmIXC3bcfyqoHvi+uCk0WKI7wQvlBj1QPTG7lCSsESBNqXAjDPFE+Wr5WwMMjDU2Ba KCorRGcmEFwPHZPoEPkxa6L3XJ/xAlvIi2nzY5rrSpVdXLV5I1J9XJkGdlSBWrZM1cjk vKyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786403372; x=1787008172; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IcYQ3EWiq+eD/+Q1XDAVHfH1xJiNbgDpsgmEp6vqXP0=; b=kzZRbRybzy/hGuigUB3v30bx8zfvMu/AC+488VB/CQEvw6FjWHLIoltkKRKmqxgOJf f5JwFpI3s8cTpa2PcjJaZt8CLmIrdJd7vDhvbG9ABPu1Jj+z2CxZdhBRrMDFJm+h/M7J 1YP4gVDQsm+p2HZ5310FDRhyfoAIGKO93r6veQFkW3e6nUy5RbObo+thXYV+y7bQBcxq e+VEeD7uAzkaxHvxLqZexZSCPQpjJFT3t8GNn8XmEo2x22/JSlzijpQZBKLZgif8NO02 9cBd/dA0JP7m49s4Stn/DoD6Hz7yuh5TnIskocSnV2g1D2UpcVJ89ele1UZlJXNa8FgE zHng== X-Forwarded-Encrypted: i=1; AHgh+Rr7fykOpcHUQFXI37MBKRUrPlgQArFESACrneQqU+GQRuOO//7K60L3Y6uyH7cNl6zUkf+/GGsJvufT@vger.kernel.org X-Gm-Message-State: AOJu0YzTlw16N4wRDoHe0acbAPRGGrq6bVYs7F5DjGyP9H3873vFtkyz kyKaWe+IwETeN+dlrzhHtfJqn5w1ZafkUjkECtA8VLt9OsicK4NTfD4H X-Gm-Gg: AR+sD108tve+3EZ3qEvMPbtlvJTET/OcE3I6uAf2hFq/a5VbUVdYtC/yz5e7tc2V8zT ZxLRpHtjsGe0SKspiS/oXJQwQXvYP997IyLWIxhrOE1rIWI/zwaZ8vUvp6TVFu7QxuWLDUfRdr/ HqjDVEKvq1WNacLExf+VvIg1Md6eUCGchRfFRwfgEnAuxa+p4Wm8aKtJAAcKRJPqKmn+fgcWJRL Ef4HkWtrf9RujsS++jtv3tCVcadMjuZuqCrmDCYelue9qH6mqTS9B4tBp/kb9tHAu0MDgUnooc9 mzFYOBnHkSj0OL6M5TglF9fUbatCBfjNmZyx8oYJ1TKLZ8Irt6/cRKwDAU+tsQYMsxIwCXZoBIS 4TDJWoWzQPjRed2dlKEP5cNLGnbBhOgJ+8+m8aEnRfnC+fSeYnyWgeJVYPw4F3xtbZS/Dk+zhbG NiYLr7Q1GDafBX166b789LPAsoytmhQ2lH8K2QreCXhcE9va1mjCAAF2ip+E95x7peWcnfPJgxm E4= X-Received: by 2002:a05:600c:840f:b0:493:a623:d090 with SMTP id 5b1f17b1804b1-49972796db0mr51504395e9.10.1786403372290; Mon, 10 Aug 2026 16:09:32 -0700 (PDT) Received: from localhost ([2001:4bb8:16f:15e0:67a4:d119:6328:800e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021e7b34sm37612569f8f.19.2026.08.10.16.09.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 16:09:31 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 11 Aug 2026 01:09:29 +0200 Message-Id: Subject: Re: [PATCH v5 4/4] iio: light: veml6031x00: add support for events and trigger Cc: "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , , To: "Andy Shevchenko" , "Javier Carrasco" From: "Javier Carrasco" X-Mailer: aerc 0.21.0-143-g2f3a2e260c09 References: <20260807-veml6031x00-v5-0-e60876fb3640@gmail.com> <20260807-veml6031x00-v5-4-e60876fb3640@gmail.com> In-Reply-To: On Mon Aug 10, 2026 at 5:32 PM CEST, Andy Shevchenko wrote: > On Fri, Aug 07, 2026 at 03:51:55PM +0200, Javier Carrasco wrote: >> The device provides a shared interrupt line for to notify events and >> data ready, which can be used as a trigger. The interrupt line is not a >> requirement for the device to work. Implement variants for the cases >> whether the interrupt line is provided or not. > > ... > ... >> +static int veml6031x00_write_th(struct iio_dev *iio, int val, int val2,= int dir) >> +{ >> + struct veml6031x00_data *data =3D iio_priv(iio); >> + __le16 regval =3D cpu_to_le16(val); > > There is no technical need to assign it here, especially if the below > validation won't pass, but it doesn't have any side effects, so I guess > it's fine. > I will assign it after the val check instead. >> + int ret; >> + >> + if (val < 0 || val > U16_MAX || val2) >> + return -EINVAL; >> + >> + if (dir =3D=3D IIO_EV_DIR_RISING) { >> + ret =3D regmap_bulk_write(data->regmap, VEML6031X00_REG_WH_L, >> + ®val, sizeof(regval)); >> + if (ret) >> + dev_dbg(regmap_get_device(data->regmap), >> + "Failed to set high threshold %d\n", ret); >> + } else { >> + ret =3D regmap_bulk_write(data->regmap, VEML6031X00_REG_WL_L, >> + ®val, sizeof(regval)); >> + if (ret) >> + dev_dbg(regmap_get_device(data->regmap), >> + "Failed to set low threshold %d\n", ret); >> + } >> + >> + return ret; >> +} > > ... > >> +static int veml6031x00_set_interrupt(struct veml6031x00_data *data, boo= l state) >> + __must_hold(&data->irq_lock) > > The sparse annotations is fine, but lockdep one is even better. > I have seen a few instances in a number of subsystems where both are used at the same time. What is the preferred alternative here? >> +{ >> + int ret; >> + >> + if (state) { >> + data->int_users++; >> + if (data->int_users > 1) >> + return 0; >> + } else { >> + data->int_users--; >> + if (data->int_users > 0) >> + return 0; >> + } >> + >> + ret =3D regmap_field_write(data->rf.int_en, state); >> + if (ret) { >> + if (state) >> + data->int_users--; >> + else >> + data->int_users++; >> + } >> + >> + return ret; >> +} > Best regards, Javier