From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B13263CF208 for ; Wed, 19 Aug 2026 18:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787164750; cv=none; b=Fx8Kw1wXAOUrdpDacZunEdHYhzd7iyfTLxc1PqPzkQZOzgT5fX2gELkKcsKxczg7TNza/yi7Ojb7VxFdNQ9PXnNGjRonHKxCKrKIzeryr8ePElOGw2Wo8PkK6yxu3ZEraO95sSYPbM++Oj55TROI5H2fam+KSjr+xko4Tuj1ayk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787164750; c=relaxed/simple; bh=S/kAfA5WC+LMKoBS1uFyMnrlO7jW1CV42eabY++XOVg=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=hjShvRXuP7BRY43i/hwhSVBKOpmSJd2bMCtyF6maURTFXktn3rxa2dMP+ifmHwF+Rn/0LZiVkyDK3m+5pcaG79UjsdiHTdEHj0m0ywUNAii0xjBrF4w+e+Ud04mEBFhnhoYpH4iHHSBZzQxP1GolheBWsg84FSrI8H5zq2Ujfiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IaZTwrCp; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IaZTwrCp" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47fe89fb333so699089f8f.3 for ; Wed, 19 Aug 2026 11:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787164746; x=1787769546; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WPgYwoDyqTp6QfKS6LN6UFIeQkwI9JmbGZkTQLSD5JE=; b=IaZTwrCpAUO/E29pna4j2Kc+PwqKGAU+IP6pXC1/wLJVG0L5qubstX9M/ovNviSjvb eHC2eN98SZD23EUXGWxkL6orNBi7fruIXh5qQ/Aap5Qru41OHC3vj+1eJMTTT3yoeCAm 3okWfosn396RLspk45BIsWYKjKLy7KXl9DAwt0AFc/7KxKXx5EA39g1e07VRrl+xQaRh X/2ZJksRSlT/ZIdLlHm1PeGku0OiJhUgZxjFvAInSzlLvi5RBAhl2GdDMNUyKTdjbmbj W2DH5lWSDD5i2VeBF4hxOBAKywC17ZWZ83tV/1NE9ZXJzEoVctEK6exTV96vg1uXFTRb 2RoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787164746; x=1787769546; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WPgYwoDyqTp6QfKS6LN6UFIeQkwI9JmbGZkTQLSD5JE=; b=PjviN+hj6B19nwW/ZrzDejxns1/9lY5wfBF3sI74YknLpr9AaYVvsjFqnQIaH2sdKH Ov2tSbVpoXsEz/WTsoXaYspNJW2Ok2M7uw21Krtl2Cj9KDL6XOyHHD013GRh4m3wpmlO aZkPCLZdM+DK3k/u9TZS6GjkvvPbBmZPgf3UiCjwYt4/SzbHAY3GZ5SZ6QQGxDmdUH7d KDbNQKiUq4+mpMZ69VK4ARrdSXJIqTvK/XIhCui7S697fHDx02xzHtueXV+KS3cqI3gE gMp6iqK5sZDPunNPpkpiqIb7k1qVZnKDzIKamzwyFWudIuZBk4iQ5o0N9dteumt3uGON X0+w== X-Forwarded-Encrypted: i=1; AHgh+RqbjxO+Z1aDTCz5POsRzrGCIEjQemdsJZHq8WDqbknHc8IZqoAedP428P2gaKEWI+jIekJqI9Fby0YI@vger.kernel.org X-Gm-Message-State: AFuF++kR9LCWBVy0qjYQ7QlQ58BYHRVSiV1IY+EgCKcBjBukceU30j6v AjQIOSo9x/ITkmvPsmmvxLJmU0eDV+kogOWY1QWXhf6yMUU8FFiub+vI X-Gm-Gg: AR+sD102Png+wYJJqq/d9EHXoenPRRRosVDCRiNqnX7WBYACvrgBx9GEQ2N7gWmqHLd II/IQdHRvcxvA7eF5Vs7ViSiK65Sm5VSZNBkht+JgJV6oYCLMy2EwjY57lLKcm/pbiqmbLZdWns tbU3jjF8Dt1H7RA4EmqGCNjjbHiCVcmg/wqx+EUjoKVEB5uRCbEzT9G24gbCze8Yhi6bPg5x2QP f+SW5w/tdUCp/PAZNibYyzN09BezOBzFpi4mt8wvlIWQMsHa+hQkWnoSWi7Nxc8RopQkl8oxIbz LlMgpyFKctb1nGkifH/3OqRPvo56jSPXV/giev5LrCV2tCFf96PlEPMtspwGUg9Rl/La6Ghe6/G S1+k/I3z1SyrIM6DrhG+ocJ9FQHfY1+zW54RxxJZYc/OHsu9wS20KNfybmlHibWgPsHp40abH6f iukJm6HsvuBoKHzSQ1G/DGIcs5Sw4nDQSKjWh2KoCRnRmEP+X8TU1shG7e2lrzbvlvONCNmtcme yA= X-Received: by 2002:a05:6000:1acc:b0:482:abf6:e3ec with SMTP id ffacd0b85a97d-482b2004955mr9751908f8f.21.1787164745998; Wed, 19 Aug 2026 11:39:05 -0700 (PDT) Received: from localhost ([2001:4bb8:17a:e1ae:eec4:cc25:791c:5824]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14b802dsm6340362f8f.17.2026.08.19.11.39.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 11:39:05 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 19 Aug 2026 20:39:03 +0200 Message-Id: Subject: Re: [PATCH v7 0/4] iio: light: add support for veml6031x00 ALS series Cc: "Javier Carrasco" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , , , "Krzysztof Kozlowski" To: "Jonathan Cameron" , "Andy Shevchenko" From: "Javier Carrasco" X-Mailer: aerc 0.21.0-143-g2f3a2e260c09 References: <20260818-veml6031x00-v7-0-2b0de0f20edf@gmail.com> <20260819020426.1de53bce@jic23-huawei> In-Reply-To: <20260819020426.1de53bce@jic23-huawei> On Wed Aug 19, 2026 at 3:04 AM CEST, Jonathan Cameron wrote: > On Tue, 18 Aug 2026 17:02:35 +0300 > Andy Shevchenko wrote: > >> On Tue, Aug 18, 2026 at 01:34:25PM +0200, Javier Carrasco wrote: >> > These ambient light sensors with I2C interface provide two light >> > channels (ALS and IR), high/low threshold alarms with configurable >> > persistence, and a data ready signal. >> > >> > The devices covered by this driver have the same resolution, and they >> > share most of their functionality. These are the differences between >> > them (note that the x belongs to their names, and it is not a wildcard= ): >> > >> > - Device ID: accessible via two 8-bit registers, different values for >> > veml6031x00/veml6031x01 and veml60311x00/veml60311x01. >> > - I2C address: same grouping, 0x29 and 0x10 I2C addresses. >> > - AEC qualification: AEC-Q100 for veml6031x00/veml60311x00 and >> > AEC-Q101 for veml6031x01/veml60311x01. >> > >> > The alarms and the data ready signals share the interrupt pin, and an >> > interrupt status register must be accessed to identify the source. Suc= h >> > multiplexing is not new in IIO, and I have followed existing examples >> > for it. The persistence setting (own attribute) to trigger the alarms >> > uses the pattern that has already been used for the veml6030. >> > >> > The device configuration is in general documented in the datasheet and >> > the application note. There is an exception, though: the activation of >> > the "active force" mode that is required for the data ready signal mus= t >> > be carried out in two steps even though the affected bits are located = in >> > the same register: first ALS_AF (active force mode enable) must be set= , >> > and then ALS_TRIG (active force trigger setting) must be enabled. I ha= ve >> > added a brief commentary in the code to explain this behavior, which h= as >> > been confirmed by the manufacturer. >> > >> > The datasheet specifies the scale and integration time for the ALS cha= nnel. >> > Although both settings also affect the measured IR value, no transfer >> > function, accuracy, or calibration is specified for converting the IR >> > output into a physical quantity. The IR channel is therefore intended = only >> > as a qualitative indication of the infrared content of the incident li= ght, >> > rather than as a precision measurement channel. Consequently, the driv= er >> > does not expose scale or integration time as IR-channel attributes. >> > >> > The only functionality that has not been implemented yet is the x0.66 >> > gain (and its x0.165 counterpart when PD_DIV=3D1), which makes the gts >> > helpers less usable due to the conversions required. It is indeed an >> > uncommon gain to use (there are x0.5 and x0.125 gains) with no known >> > use-case at the moment that justifies making adjustments to the gts >> > helpers or adding artificial conversions to make it work. >> > >> > This driver has been tested with the four supported devices separately >> > as well as in pairs where the I2C addresses don't overlap. >> >> Reviewed-by: Andy Shevchenko >> for all patches, but DT. >> >> There are minor things that may be addressed later, or in next version i= f asked >> for other reasons. >> > Assuming remaining discussion resolves, there is just enough requested > here that I think a v8 makes sense. This is particularly because > of where we are in the cycle and the massive amount of time we have > as a result. > > Note I didn't find anything that Andy hadn't already raised. > Looking nice! > > Jonathan I agree, a v8 makes sense even if there is no extra feedback. Anyway, I think I will wait for -rc1 to rebase, make sure that no conflicts arise, and send the new version. That should give enough time in case someone wants to chime in :) Best regards, Javier