Devicetree
 help / color / mirror / Atom feed
From: "Alexey Klimov" <alexey.klimov@linaro.org>
To: "Sam Protsenko" <semen.protsenko@linaro.org>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: exynos850: Add acpm SRAM node
Date: Fri, 11 Sep 2026 17:22:01 +0100	[thread overview]
Message-ID: <DLCMIMOI4D23.1YB1F2148RZE4@linaro.org> (raw)
In-Reply-To: <CAPLW+4kBHV=pcK1WyEerQ=yg-_XcR+FMXe1W7OmrMX3hxcXo_Q@mail.gmail.com>

On Fri Sep 11, 2026 at 1:28 AM BST, Sam Protsenko wrote:
> On Mon, Jul 27, 2026 at 8:23 AM Alexey Klimov <alexey.klimov@linaro.org> wrote:
>>
>> SRAM is used by the ACPM protocol to retrieve the ACPM channels
>> information and configuration data. Add the SRAM node.
>>
>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos850.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
>> index 3881f573ec08..0b614caa411c 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
>> @@ -163,6 +163,11 @@ soc: soc@0 {
>>                 #size-cells = <1>;
>>                 ranges = <0x0 0x0 0x0 0x20000000>;
>>
>> +               apm_sram: sram@2039000 {
>> +                       compatible = "samsung,exynos850-acpm-sram";
>> +                       reg = <0x2039000 0x40000>;
>
> Why it's 0x40000? I checked the TRM, and it says iRAM APM area is from
> 0x02039000 to 0x02069000, which is 0x30000 (192 KiB). The downstream
> kernel (v4.14) also say the APM SRAM size is 0x30000.

Good catch. That's my bad.

Thanks,
Alexey


  reply	other threads:[~2026-09-11 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 13:23 [PATCH v3 0/2] Exynos850 ACPM SRAM devicetree node Alexey Klimov
2026-07-27 13:23 ` [PATCH v3 1/2] dt-bindings: sram: Document samsung,exynos850-acpm-sram Alexey Klimov
     [not found]   ` <CAPLW+4ntx8qLy9jAYYdT+XwxwKHjvisutqEi04oPEQny8auD-Q@mail.gmail.com>
2026-09-11 16:20     ` Alexey Klimov
2026-09-12  5:52       ` Sam Protsenko
2026-07-27 13:23 ` [PATCH v3 2/2] arm64: dts: exynos850: Add acpm SRAM node Alexey Klimov
2026-09-11  0:28   ` Sam Protsenko
2026-09-11 16:22     ` Alexey Klimov [this message]
2026-09-10 21:38 ` [PATCH v3 0/2] Exynos850 ACPM SRAM devicetree node Alexey Klimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLCMIMOI4D23.1YB1F2148RZE4@linaro.org \
    --to=alexey.klimov@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox