Devicetree
 help / color / mirror / Atom feed
From: "Paul Louvel" <paul.louvel@bootlin.com>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Paul Louvel" <paul.louvel@bootlin.com>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Tony Luck" <tony.luck@intel.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>, <linux-edac@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v6 3/3] ARM: dts: renesas: r9a06g032: add EDAC node
Date: Tue, 13 Oct 2026 16:14:02 +0200	[thread overview]
Message-ID: <DM3RU2UQ7SDU.2FKZGSSLSRT7B@bootlin.com> (raw)
In-Reply-To: <87se29wvv4.fsf@bootlin.com>

On Tue Oct 13, 2026 at 3:52 PM CEST, Miquel Raynal wrote:
>
>>>> +               edac: memory-controller@4000d000 {
>>>> +                       compatible = "renesas,r9a06g032-ddr-edac", "cdns,ddr-edac";
>>>> +                       reg = <0x4000d000 0x1000>;
>>>> +                       interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
>>>> +                       clocks = <&sysctrl R9A06G032_CLK_DDRC>, <&sysctrl R9A06G032_HCLK_DDRC>;
>>>> +                       clock-names = "ddrc", "pclk";
>>>> +                       status = "disabled";
>>>
>>> Should this node be enabled by default, or am I too naive?
>>
>> The bootloader will be responsible to initialize the DDR controller and enable
>> ECC if specified. On this specific platform (r9a06g032), ECC is disabled by
>> default.
>> Enabling the ECC require a specific property to be present under the controller
>> node in U-Boot. I think it make sense to keep it by default disabled.
>
> Wouldn't enabling it also require some reserved memory regions? There
> should be an impact on the amount of available RAM for the system.

Yes, if the memory controller is configured by the bootloader to enable ECC.
U-Boot would fixup the memory node to reflect the correct amount of available
RAM in this case.

At the Linux level, it would not change anything if the EDAC driver is probed by
and ECC is disabled. It would just simply inform the EDAC core that SECDEC is
not supported and that's it.

>
> Thanks,
> Miquèl

-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2026-10-13 14:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 10:44 [PATCH v6 0/3] Add Renesas RZ/N1x EDAC driver Paul Louvel
2026-10-13 10:44 ` [PATCH v6 1/3] dt-bindings: edac: cdns,ddr-edac: add Cadence DDR EDAC Paul Louvel
2026-10-13 10:44 ` [PATCH v6 2/3] EDAC/cadence: Add Cadence DDR EDAC driver Paul Louvel
2026-10-13 10:45 ` [PATCH v6 3/3] ARM: dts: renesas: r9a06g032: add EDAC node Paul Louvel
2026-10-13 11:41   ` Geert Uytterhoeven
2026-10-13 11:57     ` Paul Louvel
2026-10-13 13:52       ` Miquel Raynal
2026-10-13 14:14         ` Paul Louvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM3RU2UQ7SDU.2FKZGSSLSRT7B@bootlin.com \
    --to=paul.louvel@bootlin.com \
    --cc=bp@alien8.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=herve.codina@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tony.luck@intel.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox