From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794923185; b=Tym9zIFEClJq9Y2WnobQ8KEZtR//OcbqdWPr4ecSZZTnklI/PEuVx+fHektC6Z3C0t+I Bs2OPDe0NkL+GthFVp3nfvXHvjbEctHFqvHjlhWrcPrt0Tj8QX7mGDiY1qc6/4+Nza/8G qSq5E5dRK098eLSjwU29GkdQdo58tgRR8jyGkiFzCPJ8lyBUYu4V05XytatYqtu4kISmq AyuxmRB014UOJOYsYAimVDmQPmP13M7Ci1Pc7Iy6hGXdWCLV4EAyEavH0sdqjyr5jyoRp 9UrBPzlHZQbMCajK1AyNYbFZTG2vAth/8DQeDVnCqcI7ULVNVEduPsILCzZoRegqFrw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794923185; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Mime-Version: Content-Transfer-Encoding:Content-Type:Date:Message-Id:Subject:From: To:Cc:X-Mailer:References:In-Reply-To:X-Last-TLS-Session-Version; bh=8f6rccMSyPsIrN1Q18fCGix5pfk1/BssylUZ+J+Wx/M=; b=ZiUXkMxxmv9xxgyrshUIxmhfzDi3iosReN8PMvtLABPu2D3+I9dDmELvM/Fu8DadAjo+ ciiBv0lrkdZK/ubfzrkHrWR7gPj9Q75NsmqwaRUpYoqBUpK6fzGAhfly8iGHMrwYDZGjb r5rWBTy/Aec8Q6nYUHtpB3eiF52Z5Q2pZiURfxSdZXM0EovtcCmPdniUoJ8c2ZlpvNMLJ nM6Kt2wVQVEO+vA0Yc4OO8/enzHbDXr16dStZ4xq0MBGMYNIfkudL5CoL8QB/RCnYEkMU irTb9nyTOoNkwhUJE0FVD2BIbDlUzwzHH28YAduVZPbpYtlMwVarIpWQcc8S7MGd+HQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=QrlVUiB7; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EF66606A31C; Tue, 17 Nov 2026 13:46:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2EF66606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=QrlVUiB7 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id B445C4E4156A; Tue, 17 Nov 2026 13:46:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7095D5FC81; Tue, 17 Nov 2026 13:46:23 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2DAE411BC0036; Tue, 17 Nov 2026 14:46:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1794923182; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=8f6rccMSyPsIrN1Q18fCGix5pfk1/BssylUZ+J+Wx/M=; b=QrlVUiB7S4f1Ljw6XDjLtzE2yG37yYuxWaCy7J6yDQCfIRxyIDLwGdJ06Yv14L2f350FY+ ePr3GM2ejnyWcN1TAjLk25JfSOxnUtJ/sCFT1dIusRNynHfbkaPtIIRD4IEN0cVw5j/LBm fv6RuaZTTAHIisqx2FJvLJU3zgoCrIjCd/zz/VAhADqNsV8dLYarDjqYvJskwJ3RKr7WhT 87RcHIbVIXbKakCoCygkmlQ5UCyz7Hn2I8YsaI572ctUTW1uDcdvvs4YGS8oU402LU97yL 2DSc45NejMlZq5YK0fHmiqIEpYGQoH4Tu/Fau9mLw71kT0EiOlQovgsTx66IAA== X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Nov 2026 14:46:15 +0100 Message-Id: Subject: Re: [PATCH v7 3/3] ARM: dts: renesas: r9a06g032: add EDAC node From: "Paul Louvel" To: "Wolfram Sang" , "Paul Louvel" Cc: "Borislav Petkov" , "Tony Luck" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Geert Uytterhoeven" , "Magnus Damm" , , , , , "Thomas Petazzoni" , "Miquel Raynal" , "Herve Codina" X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261019-paul-v7-3-rc1-edac-v7-0-84c76c6d7595@bootlin.com> <20261019-paul-v7-3-rc1-edac-v7-3-84c76c6d7595@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Hi Wolfram, On Tue Nov 17, 2026 at 2:08 PM CET, Wolfram Sang wrote: > >> + edac: memory-controller@4000d000 { >> + compatible =3D "renesas,r9a06g032-ddr-edac", "cdns,ddr-edac"; >> + reg =3D <0x4000d000 0x1000>; >> + interrupts =3D ; >> + clocks =3D <&sysctrl R9A06G032_CLK_DDRC>, <&sysctrl R9A06G032_HCLK_D= DRC>; >> + clock-names =3D "ddrc", "pclk"; >> + status =3D "disabled"; >> + }; > > On second thought, any reason we don't want this enabled by default? Please see my answer to Geert [1]. After reconsideration, maybe it is advisable to enable it by default. Enabl= ing ECC is done by the bootloader, and it might be better if no further actions= are required to enable it kernel side. If ECC is disabled, no errors will be generated, and the capabilties will j= ust be set to EDAC_CAP_NONE. [1]: https://lore.kernel.org/all/DM3OXV8IQQKR.36V79A742H52F@bootlin.com/ Thanks. Best regards, --=20 Paul Louvel, Bootlin Embedded Linux and Kernel engineering https://bootlin.com