Devicetree
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: Emil Medve <Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] Fix libraries (static and dynamic) installation
Date: Tue, 17 Feb 2009 10:14:38 -0600	[thread overview]
Message-ID: <E1LZSak-0006Ze-Mb@jdl.com> (raw)
In-Reply-To: <1234798759-32149-1-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>

> Signed-off-by: Emil Medve <Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
> ---
> 
> The static library was not installed at all and the dynamic library was
> installed without execute permission


Emil,

I rearranged that log to put your description in it.
But the real problem is that applying it is a no-op.
I think your patch is mal-formed.  Specifically, it
looks like the line counts:

    @@ -142,2 +142,2 @@ endif

are bogus.  Only 2 lines?

Cleverly, Git applys the patch and yields a commit
with no changes.  (Identical tree before and after.)
Clearly wrong.

Can you send me a better patch?

Thanks,
jdl



>  Makefile |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 1cfa28a..be0fc8b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -142,2 +142,2 @@ endif
>  # intermediate target and building them again "for real"
>  .SECONDARY: $(DTC_GEN_SRCS) $(CONVERT_GEN_SRCS)
> 
> -
> -
>  install: all
>  	@$(VECHO) INSTALL
>  	$(INSTALL) -d $(DESTDIR)$(BINDIR)
> -	$(INSTALL) -m 755 $(BIN) $(DESTDIR)$(BINDIR)
> +	$(INSTALL) $(BIN) $(DESTDIR)$(BINDIR)
>  	$(INSTALL) -d $(DESTDIR)$(LIBDIR)
> -	$(INSTALL) -m 644 $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
> +	$(INSTALL) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
> +	$(INSTALL) -m 644 $(LIBFDT_archive) $(DESTDIR)$(LIBDIR)
>  	$(INSTALL) -d $(DESTDIR)$(INCLUDEDIR)
>  	$(INSTALL) -m 644 $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR)
> 
> --
> 1.6.1.3
> 
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
> https://ozlabs.org/mailman/listinfo/devicetree-discuss

      parent reply	other threads:[~2009-02-17 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16 15:39 [PATCH] Fix libraries (static and dynamic) installation Emil Medve
     [not found] ` <1234798759-32149-1-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2009-02-17 16:14   ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LZSak-0006Ze-Mb@jdl.com \
    --to=jdl-cyomk+44s/e@public.gmane.org \
    --cc=Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org \
    --cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox