Re: dtc: Enable more warnings

[Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

> This patch turns on a bunch of extra gcc warnings, most of which are
> probably a good idea.  Of the new warnings -Wnested-externs and
> -Wstrict-prototypes need no code changes, we're already warning-clean.
> The remaining one, -Wmissing-prototypes requires trivial changes in
> some of the tests (making functions local).
> 
> This patch also rearranges the warnings flags into a separate make
> variable for convenience, and turns on -Werror, to really encourage
> people to keep the code warning-clean.
> 
> Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>

Well, I'd like to apply this patch.  But doing so appears
to be very effective.  So much so that the "make check"
now fails:

$ gcc --version
gcc (Debian 4.3.2-1.1) 4.3.2

$ make check
	CHK version_gen.h
	 CC tests/testutils.o
cc1: warnings being treated as errors
tests/testutils.c: In function ‘sigint_handler’:
tests/testutils.c:44: error: unused parameter ‘si’
tests/testutils.c:44: error: unused parameter ‘uc’
tests/testutils.c: In function ‘test_init’:
tests/testutils.c:52: error: unused parameter ‘argc’
tests/testutils.c: In function ‘check_property’:
tests/testutils.c:113: error: comparison between signed and unsigned
tests/testutils.c:117: error: comparison between signed and unsigned
make: *** [tests/testutils.o] Error 1

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss