Devicetree
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: dtc: Extend and better test dtbs_equal utility programs (resend)
Date: Fri, 30 Apr 2010 08:39:05 -0500	[thread overview]
Message-ID: <E1O7qQr-0004ZA-Ez@jdl.com> (raw)
In-Reply-To: <20100430053000.GV6284@yookeroo>

> The dtbs_equal_ordered test program is used to implement a number of
> testcases.  However, the test program itself has never been
> particularly well tested.  In addition there are testcases coming in
> future for which it would be useful to have a corresponding
> "dtbs_equal_unordered" which checks for equality of device trees, not
> considering the internal ordering of elements.  Finally, for some
> tests we may want it would be useful to check trees for equality with
> the PASS case being when they are *not* equal.
> 
> This patch addresses all of the above.  A dtbs_equal_unordered is
> added, and both it and the existing dtbs_equal_ordered program now
> take a -n option to make the PASS case be where the trees are not
> equal.  A number of example trees with slight modifications from
> test_tree1 are used to verify that both these programs correctly
> identify when the tree is altered, and a dtb_reverse program is used
> to verify that the unordered version does not depend on internal
> ordering.  These new testcases for the equality testing programs are
> split out into a new test group in run_tests.sh.
> 
> dtbs_equal_unordered uses the new property iteration functions, and so
> this also acts as further testing for those functions.
> dtbs_equal_unordered will be useful for further testing the recently
> added tree-merging code and its upcoming extensions.
> 
> Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>

Applied.

jdl

      reply	other threads:[~2010-04-30 13:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30  5:30 dtc: Extend and better test dtbs_equal utility programs (resend) David Gibson
2010-04-30 13:39 ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1O7qQr-0004ZA-Ez@jdl.com \
    --to=jdl-cyomk+44s/e@public.gmane.org \
    --cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox