Devicetree
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [dtc] Remove another bashism from run_tests.sh
Date: Mon, 20 Sep 2010 09:33:33 -0500	[thread overview]
Message-ID: <E1OxhQz-0006j3-1V@jdl.com> (raw)
In-Reply-To: <20100830025303.GA5210@yookeroo>

> Current we check for various error codes with [ $x == "NN" ].  However
> '==' is not actually a correct operator for the [ (test) command.  It
> should be either '=' for string comparison or '-eq' for integer
> comparison.  It appears that the bash builtin version of test
> implements '==' though, so we were getting away with it, as long as
> /bin/sh was bash - or the testsuite generated no errors.
> 
> This patch fixes the usage of test so that it should work on non-bash
> shells.
> 
> Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>

Applied.  Sorry for the delay.

Thanks,
jdl

      parent reply	other threads:[~2010-09-20 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30  2:53 [dtc] Remove another bashism from run_tests.sh David Gibson
2010-08-30  3:22 ` Grant Likely
2010-09-20 14:33 ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1OxhQz-0006j3-1V@jdl.com \
    --to=jdl-cyomk+44s/e@public.gmane.org \
    --cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox