From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Subject: Re: [PATCH] libfdt: include version number in soname Date: Fri, 29 Apr 2011 08:48:46 -0500 Message-ID: References: <1303380829-16965-1-git-send-email-pbonzini@redhat.com> <20110425030733.GA6263@yookeroo> <4DB5B8D0.90802@redhat.com> <20110426104527.GC6263@yookeroo> <4DB6A98B.6020107@redhat.com> <20110426151912.GE6263@yookeroo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20110426151912.GE6263@yookeroo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: David Gibson Cc: Paolo Bonzini , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org > On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote: > > On 04/26/2011 12:45 PM, David Gibson wrote: > > > > > > libfdt: include version number in soname > > > > > > From: Paolo Bonzini > > > > > > The libfdt shared library is only installed by its unversioned name. > > > Including it properly in a distribution requires installation of both > > > the versioned name (used in the binary-only package) and the unversioned > > > name (used in the development package). The latter is just a symbolic > > > link, so you need to change the soname in turn to include the version. > > > > > > While at it, use Makefile variables to shorten some lines and avoid > > > cut-and-paste typos; and clean up remnants of when shared libraries were > > > not supported on Darwin. > > > > > > Signed-off-by: Paolo Bonzini > > > Signed-off-by: David Gibson > > > > This: > > > > + $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^ > > > > should be $(LIBFDT_soname). > > Ugh, yes, instead of $(LIBFDT_SONAME) to be clear. I did check the > soname on my build, I must have made an accidental press of M-u after > I did so, sorry. Applied with last-minute mod and pushed out. Consider this the candidate for a 1.3.0 release! Thanks! jdl