* [PATCH REPOST] fdtget-runtest.sh: use printf instead of /bin/echo -e @ 2012-12-11 17:05 Stephen Warren [not found] ` <1355245551-6988-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Stephen Warren @ 2012-12-11 17:05 UTC (permalink / raw) To: David Gibson, jdl-CYoMK+44s/E Cc: Stephen Warren, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Not all /bin/echo implementations support the -e option. Instead, use printf, which appears to be more widely available than /bin/echo -e. See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't bash" for history. I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash and bash. Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> --- tests/fdtget-runtest.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh index c3a3559..8d8b058 100755 --- a/tests/fdtget-runtest.sh +++ b/tests/fdtget-runtest.sh @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT trap "rm -f $LOG $EXPECT" 0 expect="$1" -/bin/echo -e $expect >$EXPECT +printf '%b\n' "$expect" > $EXPECT shift verbose_run_log_check "$LOG" $VALGRIND $DTGET "$@" -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1355245551-6988-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]
* Re: [PATCH REPOST] fdtget-runtest.sh: use printf instead of /bin/echo -e [not found] ` <1355245551-6988-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> @ 2012-12-12 23:06 ` David Gibson 2013-01-06 22:03 ` Jon Loeliger 1 sibling, 0 replies; 3+ messages in thread From: David Gibson @ 2012-12-12 23:06 UTC (permalink / raw) To: Stephen Warren; +Cc: Stephen Warren, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ On Tue, Dec 11, 2012 at 10:05:51AM -0700, Stephen Warren wrote: > From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > Not all /bin/echo implementations support the -e option. Instead, use > printf, which appears to be more widely available than /bin/echo -e. > > See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't > bash" for history. > > I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash > and bash. > > Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by > Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH REPOST] fdtget-runtest.sh: use printf instead of /bin/echo -e [not found] ` <1355245551-6988-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2012-12-12 23:06 ` David Gibson @ 2013-01-06 22:03 ` Jon Loeliger 1 sibling, 0 replies; 3+ messages in thread From: Jon Loeliger @ 2013-01-06 22:03 UTC (permalink / raw) To: Stephen Warren; +Cc: Stephen Warren, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ > From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > Not all /bin/echo implementations support the -e option. Instead, use > printf, which appears to be more widely available than /bin/echo -e. > > See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't > bash" for history. > > I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash > and bash. > > Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by > Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Applied. Thanks, jdl ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-06 22:03 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-11 17:05 [PATCH REPOST] fdtget-runtest.sh: use printf instead of /bin/echo -e Stephen Warren [not found] ` <1355245551-6988-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2012-12-12 23:06 ` David Gibson 2013-01-06 22:03 ` Jon Loeliger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).