From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Subject: Re: Fix test relying in wrong behavior of is_printable Date: Sun, 06 Jan 2013 16:14:23 -0600 Message-ID: References: <1357326968-13124-1-git-send-email-panto@antoniou-consulting.com> <20130106035809.GG4674@truffula.fritz.box> <5B13DF52-26BE-4BA1-8BD7-25863B04A3B6@antoniou-consulting.com> Return-path: In-reply-to: <5B13DF52-26BE-4BA1-8BD7-25863B04A3B6@antoniou-consulting.com> Sender: linux-kernel-owner@vger.kernel.org To: Pantelis Antoniou Cc: David Gibson , Matt Porter , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Russ Dill List-Id: devicetree@vger.kernel.org > Hi David > > =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85 > > 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: > > > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: > >> After fixing the is_printable bug the test suite fails. > >> Fix it with this patch > >>=20 > >> Signed-off-by: Pantelis Antoniou > >=20 > > Rather than just removing the test, it would be better to still run it > > using an explicit -t bi to force the byte output. > > Perhaps it wasn't exactly clear in the patch. The old test case output is co= > mmented out but there is test case output for the new patch.=20 > > So the test is not removed.=20 Uh, yeah, something needs to be done here still. (There is a failing test still.) Could we get a resubmission of the fix, please? Thanks, jdl