devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RFC 2/2] ARM: add support for Cubox-i PWM-driven front panel LED
@ 2014-02-18 13:09 Russell King
  0 siblings, 0 replies; only message in thread
From: Russell King @ 2014-02-18 13:09 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Bryan Wu,
	Richard Purdie, Thierry Reding
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA

The front panel LED on the Cubox-i is driven by one of the iMX6 PWM
channels, and is wired between the PWM output and supply.  This means
that outputting a low level results in the LED being turned on, so we
need the duty cycle inverted.

There's a question about whether the output inversion should be at the
pwm or pwm-leds level - setting the output inversion bit in the iMX6
results in a PWM duty cycle of zero outputting logic zero, meaning that
the LED is fully on.  This is undesirable, as it becomes impossible to
turn the LED fully off.

Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
=-DO NOT APPLY-=
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index 64daa3b311f6..d9fbd7ff17df 100644
=-DO NOT APPLY-= a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
=+DO NOT APPLY+= b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -12,6 +12,20 @@
 		pinctrl-0 = <&pinctrl_cubox_i_ir>;
 	};
 
=+DO NOT APPLY+=	pwmleds {
=+DO NOT APPLY+=		compatible = "pwm-leds";
=+DO NOT APPLY+=		pinctrl-names = "default";
=+DO NOT APPLY+=		pinctrl-0 = <&pinctrl_cubox_i_pwm1>;
=+DO NOT APPLY+=
=+DO NOT APPLY+=		front {
=+DO NOT APPLY+=			active-low;
=+DO NOT APPLY+=			default-brightness = <128>;
=+DO NOT APPLY+=			label = "imx6:red:front";
=+DO NOT APPLY+=			max-brightness = <248>;
=+DO NOT APPLY+=			pwms = <&pwm1 0 50000>;
=+DO NOT APPLY+=		};
=+DO NOT APPLY+=	};
=+DO NOT APPLY+=
 	regulators {
 		compatible = "simple-bus";
 
@@ -88,6 +102,10 @@
 			>;
 		};
 
=+DO NOT APPLY+=		pinctrl_cubox_i_pwm1: cubox-i-pwm1-front-led {
=+DO NOT APPLY+=			fsl,pins = <MX6QDL_PAD_DISP0_DAT8__PWM1_OUT 0x1b0b0>;
=+DO NOT APPLY+=		};
=+DO NOT APPLY+=
 		pinctrl_cubox_i_spdif: cubox-i-spdif {
 			fsl,pins = <MX6QDL_PAD_GPIO_17__SPDIF_OUT 0x1b0b0>;
 		};
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-02-18 13:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 13:09 [PATCH RFC 2/2] ARM: add support for Cubox-i PWM-driven front panel LED Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).