Re: [PATCH v5 1/5] ASoC: codecs: Add msm8916-wcd analog codec

Srinivas Kandagatla
2016-09-19T11:00:22Z

Thanks for review,

On 16/09/16 16:41, Rob Herring wrote:
> On Thu, Sep 08, 2016 at 02:04:52PM +0100, Srinivas Kandagatla wrote:
>> msm8916-wcd codec is found in Qualcomm msm8916 and apq8016 processors.
>> This codec IP is split in to two parts (Digital & Analog).
>> Analog part is integrated in to PMIC PM8916 and the digital part is
>> integrated into Application processor. Data transfer between Analog and
>> Digital Die is done via a internal bus called PDM.
>>
>> This patch adds support to Analog part of the Codec which is integrated
>> into PMIC PM8916.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> .../bindings/sound/qcom,msm8916-wcd-analog.txt | 83 ++
>> sound/soc/codecs/Kconfig | 4 +
>> sound/soc/codecs/Makefile | 3 +-
>> sound/soc/codecs/msm8916-wcd-analog.c | 888 +++++++++++++++++++++
>> 4 files changed, 977 insertions(+), 1 deletion(-)
>> create mode 100644 Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt
>> create mode 100644 sound/soc/codecs/msm8916-wcd-analog.c
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt b/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt
>> new file mode 100644
>> index 0000000..f426c06
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt
>> @@ -0,0 +1,83 @@
>> +msm8916 analog audio CODEC
>> +
>> +Bindings for codec Analog IP which is integrated in pmic pm8916,
>> +
>> +## Bindings for codec core on pmic:
>> +
>> +Required properties
>> + - compatible = "qcom,msm8916-wcd-analog-codec";

I will also add pmic into this compatible so that it will be clear that
it is part of the PMIC chip.

something like "qcom,pm8916-wcd-analog-codec"

>> + - reg: represents the slave base address provided to the peripheral.
>> + - interrupt-parent : The parent interrupt controller.
>> + - interrupts: List of interrupts in given SPMI peripheral.
>> + - interrupt-names: Names specified to above list of interrupts in same
>> + order. List of supported interrupt names are:
>> + "cdc_spk_cnp_int" - Speaker click and pop interrupt.
>> + "cdc_spk_clip_int" - Speaker clip interrupt.
>> + "cdc_spk_ocp_int" - Speaker over current protect interrupt.
>> + "mbhc_ins_rem_det1" - jack insert removal detect interrupt 1.
>> + "mbhc_but_rel_det" - button release interrupt.
>> + "mbhc_but_press_det" - button press event
>> + "mbhc_ins_rem_det" - jack insert removal detect interrupt.
>> + "mbhc_switch_int" - multi button headset interrupt.
>> + "cdc_ear_ocp_int" - Earphone over current protect interrupt.
>> + "cdc_hphr_ocp_int" - Headphone R over current protect interrupt.
>> + "cdc_hphl_ocp_det" - Headphone L over current protect interrupt.
>> + "cdc_ear_cnp_int" - earphone cnp interrupt.
>> + "cdc_hphr_cnp_int" - hphr click and pop interrupt.
>> + "cdc_hphl_cnp_int" - hphl click and pop interrupt.
>> +
>> + - clocks: Handle to mclk.
>> + - clock-names: should be "mclk".
>> + - VDD-CDC-IO-supply: phandle to VDD_CDC_IO regulator device tree node.
>> + - VDD-CDC-TX-RX-CX-supply: phandle to VDD_CDC_TX/RX/CX regulator device tree node.
>> + - VDD-MICBIAS-supply: phandle of VDD_MICBIAS supply's regulator device tree node.
>
> Lowercase please.

Ok, I will do that in next version.
>
>> +
>> +Optional Properties:
>> +- qcom,micbias1-ext-cap: present if micbias1 has external capacitor connected.
>> +- qcom,micbias2-ext-cap: present if micbias2 has external capacitor connected.
>
> Explicitly state these are bool.
>
>> +
>> +Example:
>> +
>> +spmi_bus {
>> + ...
>> + msm8916_wcd_codec@f000{
>
> audio-codec@...
Yep. Will fix it in next version.

Thanks,
srini