Re: [PATCH 09/16] pinctrl: madera: Add driver for Cirrus Logic Madera codecs

Rob Herring
2017-04-10T17:56:58Z

On Wed, Apr 05, 2017 at 11:07:57AM +0100, Richard Fitzgerald wrote:
> These codecs have a variable number of I/O lines each of which
> is individually selectable to a wide range of possible functions.
>
> The functionality is slightly different from the traditional muxed
> GPIO since most of the functions can be mapped to any pin (and even
> the same function to multiple pins). Most pins have a dedicated
> "alternate" function that is only available on that pin. The
> alternate functions are usually a group of signals, though it is
> not always necessary to enable the full group, depending on the
> alternate function and how it is to be used. The mapping between
> alternate functions and GPIO pins varies between codecs depending
> on the number of alternate functions and available pins.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
> .../bindings/pinctrl/cirrus,madera-pinctrl.txt | 103 ++

As Linus said, separate patch is preferred. But I don't have any other
comments, so I'm not going to require it:

Acked-by: Rob Herring <robh@kernel.org>

> MAINTAINERS | 2 +
> drivers/pinctrl/Kconfig | 22 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/pinctrl-madera.c | 1092 ++++++++++++++++++++
> 5 files changed, 1220 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt
> create mode 100644 drivers/pinctrl/pinctrl-madera.c