[PATCH] arm64: dts: marvell: mcbin: add sdhci

[PATCH] arm64: dts: marvell: mcbin: add sdhci

[Russell King]

Add sdhci support for MACCHIATOBin boards.  This uses the AP806 SDHCI
for eMMC and CP110 master for the SD card slot.

Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
---

This version labels up the uSD connector, adds the vqmmc regulator for
the uSD (the regulator itself already present in the DT), and supports
the card detect signal.

For eMMC, this version adds the vqmmc regulator, which again is already
present in the DT, marks it as not supporting SD or SDIO, and also
includes "slow mode" since testing with previous versions of the driver
have shown that selecting faster speeds results in errors.

 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts |   23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
index cc167e05941a..60111ed3234a 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
@@ -95,6 +95,21 @@
 	status = "okay";
 };
 
+&ap_sdhci0 {
+	bus-width = <8>;
+	/*
+	 * Not stable in HS modes - phy needs "more calibration", so add
+	 * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
+	 */
+	marvell,xenon-phy-slow-mode;
+	no-1-8-v;
+	no-sd;
+	no-sdio;
+	non-removable;
+	status = "okay";
+	vqmmc-supply = <&v_vddo_h>;
+};
+
 &cpm_i2c0 {
 	clock-frequency = <100000>;
 	status = "okay";
@@ -105,6 +120,14 @@
 	status = "okay";
 };
 
+&cpm_sdhci0 {
+	/* U6 */
+	broken-cd;
+	bus-width = <4>;
+	status = "okay";
+	vqmmc-supply = <&v_3_3>;
+};
+
 &cpm_usb3_0 {
 	/* J38? - USB2.0 only */
 	status = "okay";
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: dts: marvell: mcbin: add sdhci

[Marcin Wojtas]

[-- Attachment #1: Type: text/plain, Size: 2245 bytes --]

Russel,

2017-05-16 15:45 GMT+02:00 Russell King <rmk+kernel@armlinux.org.uk>:

> Add sdhci support for MACCHIATOBin boards.  This uses the AP806 SDHCI
> for eMMC and CP110 master for the SD card slot.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>
> This version labels up the uSD connector, adds the vqmmc regulator for
> the uSD (the regulator itself already present in the DT), and supports
> the card detect signal.
>
> For eMMC, this version adds the vqmmc regulator, which again is already
> present in the DT, marks it as not supporting SD or SDIO, and also
> includes "slow mode" since testing with previous versions of the driver
> have shown that selecting faster speeds results in errors.
>
>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts |   23
> ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> index cc167e05941a..60111ed3234a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> @@ -95,6 +95,21 @@
>         status = "okay";
>  };
>
> +&ap_sdhci0 {
> +       bus-width = <8>;
> +       /*
> +        * Not stable in HS modes - phy needs "more calibration", so add
> +        * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
> +        */
> +       marvell,xenon-phy-slow-mode;
>

FYI, this property is by default present in armada-ap806.dtsi.

Marcin


> +       no-1-8-v;
> +       no-sd;
> +       no-sdio;
> +       non-removable;
> +       status = "okay";
> +       vqmmc-supply = <&v_vddo_h>;
> +};
> +
>  &cpm_i2c0 {
>         clock-frequency = <100000>;
>         status = "okay";
> @@ -105,6 +120,14 @@
>         status = "okay";
>  };
>
> +&cpm_sdhci0 {
> +       /* U6 */
> +       broken-cd;
> +       bus-width = <4>;
> +       status = "okay";
> +       vqmmc-supply = <&v_3_3>;
> +};
> +
>  &cpm_usb3_0 {
>         /* J38? - USB2.0 only */
>         status = "okay";
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[-- Attachment #2: Type: text/html, Size: 3536 bytes --]

Re: [PATCH] arm64: dts: marvell: mcbin: add sdhci

[Marcin Wojtas]

Re-send in plain text.

2017-05-16 17:40 GMT+02:00 Marcin Wojtas <mw-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>:
> Russel,
>
> 2017-05-16 15:45 GMT+02:00 Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>:
>>
>> Add sdhci support for MACCHIATOBin boards.  This uses the AP806 SDHCI
>> for eMMC and CP110 master for the SD card slot.
>>
>> Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
>> ---
>>
>> This version labels up the uSD connector, adds the vqmmc regulator for
>> the uSD (the regulator itself already present in the DT), and supports
>> the card detect signal.
>>
>> For eMMC, this version adds the vqmmc regulator, which again is already
>> present in the DT, marks it as not supporting SD or SDIO, and also
>> includes "slow mode" since testing with previous versions of the driver
>> have shown that selecting faster speeds results in errors.
>>
>>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts |   23
>> ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
>> b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
>> index cc167e05941a..60111ed3234a 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
>> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
>> @@ -95,6 +95,21 @@
>>         status = "okay";
>>  };
>>
>> +&ap_sdhci0 {
>> +       bus-width = <8>;
>> +       /*
>> +        * Not stable in HS modes - phy needs "more calibration", so add
>> +        * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
>> +        */
>> +       marvell,xenon-phy-slow-mode;
>
>
> FYI, this property is by default present in armada-ap806.dtsi.
>
> Marcin
>
>>
>> +       no-1-8-v;
>> +       no-sd;
>> +       no-sdio;
>> +       non-removable;
>> +       status = "okay";
>> +       vqmmc-supply = <&v_vddo_h>;
>> +};
>> +
>>  &cpm_i2c0 {
>>         clock-frequency = <100000>;
>>         status = "okay";
>> @@ -105,6 +120,14 @@
>>         status = "okay";
>>  };
>>
>> +&cpm_sdhci0 {
>> +       /* U6 */
>> +       broken-cd;
>> +       bus-width = <4>;
>> +       status = "okay";
>> +       vqmmc-supply = <&v_3_3>;
>> +};
>> +
>>  &cpm_usb3_0 {
>>         /* J38? - USB2.0 only */
>>         status = "okay";
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: dts: marvell: mcbin: add sdhci

[Russell King - ARM Linux]

On Tue, May 16, 2017 at 05:42:19PM +0200, Marcin Wojtas wrote:
> Re-send in plain text.
> 
> 2017-05-16 17:40 GMT+02:00 Marcin Wojtas <mw-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>:
> > Russel,
> >
> > 2017-05-16 15:45 GMT+02:00 Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>:
> >>
> >> Add sdhci support for MACCHIATOBin boards.  This uses the AP806 SDHCI
> >> for eMMC and CP110 master for the SD card slot.
> >>
> >> Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
> >> ---
> >>
> >> This version labels up the uSD connector, adds the vqmmc regulator for
> >> the uSD (the regulator itself already present in the DT), and supports
> >> the card detect signal.
> >>
> >> For eMMC, this version adds the vqmmc regulator, which again is already
> >> present in the DT, marks it as not supporting SD or SDIO, and also
> >> includes "slow mode" since testing with previous versions of the driver
> >> have shown that selecting faster speeds results in errors.
> >>
> >>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts |   23
> >> ++++++++++++++++++++++
> >>  1 file changed, 23 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> >> b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> >> index cc167e05941a..60111ed3234a 100644
> >> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> >> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> >> @@ -95,6 +95,21 @@
> >>         status = "okay";
> >>  };
> >>
> >> +&ap_sdhci0 {
> >> +       bus-width = <8>;
> >> +       /*
> >> +        * Not stable in HS modes - phy needs "more calibration", so add
> >> +        * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
> >> +        */
> >> +       marvell,xenon-phy-slow-mode;
> >
> >
> > FYI, this property is by default present in armada-ap806.dtsi.

Yes, it may be, it's unclear (at least to me) whether this is a board
problem or a SoC problem.  Given that it's at the SoC layer, it suggests
there's a SoC/driver problem that needs resolving.

However, given that the board is tested only in non-HS mode at the
moment, having the property in place is the sensible thing, even though
the SoC level currently has the property.  If we can prove that the
board is capable of HS modes, then I'd be happy to remove it, but not
before.  It could be that even if the SoC level is capable of HS modes,
the board may not support them.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: dts: marvell: mcbin: add sdhci

[Gregory CLEMENT]

Hi Russell King,
 
 On mar., mai 16 2017, Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org> wrote:
>> >>
>> >> +&ap_sdhci0 {
>> >> +       bus-width = <8>;
>> >> +       /*
>> >> +        * Not stable in HS modes - phy needs "more calibration", so add
>> >> +        * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
>> >> +        */
>> >> +       marvell,xenon-phy-slow-mode;
>> >
>> >
>> > FYI, this property is by default present in armada-ap806.dtsi.
>
> Yes, it may be, it's unclear (at least to me) whether this is a board
> problem or a SoC problem.  Given that it's at the SoC layer, it suggests
> there's a SoC/driver problem that needs resolving.

According to the feedback I got from Marvell the issue is at SoC level,
it seemed there was a integration problem of the Xenon IP inside the
AP806 so I don't expect it will ever work.

Gregory

>
> However, given that the board is tested only in non-HS mode at the
> moment, having the property in place is the sensible thing, even though
> the SoC level currently has the property.  If we can prove that the
> board is capable of HS modes, then I'd be happy to remove it, but not
> before.  It could be that even if the SoC level is capable of HS modes,
> the board may not support them.
>
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: dts: marvell: mcbin: add sdhci

[Gregory CLEMENT]

Hi Russell,
 
 On mar., mai 16 2017, Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org> wrote:

> Add sdhci support for MACCHIATOBin boards.  This uses the AP806 SDHCI
> for eMMC and CP110 master for the SD card slot.


Applied on mvebu/dt64

Thanks,

Gregory

>
> Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
> ---
>
> This version labels up the uSD connector, adds the vqmmc regulator for
> the uSD (the regulator itself already present in the DT), and supports
> the card detect signal.
>
> For eMMC, this version adds the vqmmc regulator, which again is already
> present in the DT, marks it as not supporting SD or SDIO, and also
> includes "slow mode" since testing with previous versions of the driver
> have shown that selecting faster speeds results in errors.
>
>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts |   23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> index cc167e05941a..60111ed3234a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> @@ -95,6 +95,21 @@
>  	status = "okay";
>  };
>  
> +&ap_sdhci0 {
> +	bus-width = <8>;
> +	/*
> +	 * Not stable in HS modes - phy needs "more calibration", so add
> +	 * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
> +	 */
> +	marvell,xenon-phy-slow-mode;
> +	no-1-8-v;
> +	no-sd;
> +	no-sdio;
> +	non-removable;
> +	status = "okay";
> +	vqmmc-supply = <&v_vddo_h>;
> +};
> +
>  &cpm_i2c0 {
>  	clock-frequency = <100000>;
>  	status = "okay";
> @@ -105,6 +120,14 @@
>  	status = "okay";
>  };
>  
> +&cpm_sdhci0 {
> +	/* U6 */
> +	broken-cd;
> +	bus-width = <4>;
> +	status = "okay";
> +	vqmmc-supply = <&v_3_3>;
> +};
> +
>  &cpm_usb3_0 {
>  	/* J38? - USB2.0 only */
>  	status = "okay";
> -- 
> 2.7.4
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html