Re: [PATCH v2 2/2] ASoC: cs43130: Add devicetree bindings for CS43130

Li Xu
2017-08-22T14:18:54Z

On Mon, Aug 21, 2017 at 06:31:48PM -0500, Rob Herring wrote:
> On Fri, Aug 18, 2017 at 11:00:20AM -0500, Li Xu wrote:
> > Add devicetree bindings documentation file for Cirrus
> > Logic CS43130 codec.
> >
> > Signed-off-by: Li Xu <li.xu@cirrus.com>
> > ---
> > .../devicetree/bindings/sound/cs43130.txt | 67 ++++++++++++++++++++++
> > 1 file changed, 67 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/cs43130.txt
>
> For the 4th time, I'm acking this (v2 and v3 last Dec and the new v1 a
> few weeks ago). Please add acks when posting new versions.
>
> Though you keep changing something looking at the diffstats. I'm not
> sure what though because you have no version history.
>
> Rob

Thanks for the feedback. I am new to Linux kernel patch submission.

I will add cover letter to patch set, which would explain version change info.
I will also add "Acked-by: Rob Herring <robh@kernel.org>" in commit message below
"Signed-off-by: ..."

Li