Re: [PATCH v2 16/19] ASoC: tlv320aic31xx: Add short circuit detection support

Andrew F. Davis
2017-12-01T15:32:12Z

On 12/01/2017 07:39 AM, Mark Brown wrote:
> On Wed, Nov 29, 2017 at 03:32:57PM -0600, Andrew F. Davis wrote:
>
>> +static irqreturn_t aic31xx_irq(int irq, void *data)
>> +{
>> + struct aic31xx_priv *aic31xx = (struct aic31xx_priv *)data;
>
> There is no need to cast away from void, doing so can only mask bugs.
>
>> + ret = regmap_read(aic31xx->regmap, AIC31XX_INTRDACFLAG, &value);
>> + if (ret) {
>> + dev_err(dev, "Failed to read interrupt mask: %d\n", ret);
>> + return IRQ_NONE;
>> + }
>> +
>> + if (value & AIC31XX_HPLSCDETECT)
>> + dev_err(dev, "Short circuit on Left output is detected\n");
>> + if (value & AIC31XX_HPRSCDETECT)
>> + dev_err(dev, "Short circuit on Right output is detected\n");
>> +
>> + return IRQ_HANDLED;
>
> This will report the interrupt as handled even if we didn't see an
> interrupt we understand which will break shared interrupt lines. At the
> very least we should log other interrupt sources numerically.
>

Okay, I think I can make that work by checking if no bits are set in the
interrupt regs and returning early if not, IRQ_NONE.

>> + if (aic31xx->irq > 0) {
>> + regmap_update_bits(aic31xx->regmap, AIC31XX_GPIO1,
>> + AIC31XX_GPIO1_FUNC_MASK,
>> + AIC31XX_GPIO1_INT1 <<
>> + AIC31XX_GPIO1_FUNC_SHIFT);
>
> Is the interrupt only available on GPIO1?
>

Some devices can route this to GPIO2 IIRC.

I'm not sure how that would be supported, I think we would need to add
interrupt names to DT so users could specify which gpio they wired their
IRQ lines to.

interrupt = <&host 23>;
interrupt-name = "gpio2";

or similar?