Re: [PATCH v2 18/19] ASoC: tlv320aic31xx: Add headphone/headset detection

Andrew F. Davis
2017-12-06T17:47:14Z

On 12/06/2017 11:32 AM, Mark Brown wrote:
> On Wed, Dec 06, 2017 at 11:25:15AM -0600, Andrew F. Davis wrote:
>> On 12/01/2017 07:41 AM, Mark Brown wrote:
>
>>> This only does half the job, there's no way for anything to specify a
>>> jack here.
>
>> Other CODECs drivers expose some kind of platform/machine specific
>> function(s) to send the jack definition to the CODEC, we seem to be
>
> Your driver doesn't do that.
>

Right, I don't have a specific machine in mind so didn't wan to do it
that way.

>> missing a generic way to report jack information up to the machine layer
>> driver.
>
> snd_soc_codec_set_jack()
>

Hmm, this looks close to what I was thinking (I was wanting to go the
other direction and have the codec report what jacks it supports, this
could allow for more than one jack), I'll see if I can make it work.