Re: [PATCH v2 15/19] ASoC: tlv320aic31xx: Reset registers during power up

Mark Brown
2017-12-01T13:37:23Z

[-- Attachment #1.1: Type: text/plain, Size: 449 bytes --]

On Wed, Nov 29, 2017 at 03:32:56PM -0600, Andrew F. Davis wrote:

> + gpiod_set_value(aic31xx->gpio_reset, 1);
> + ndelay(10); /* At least 10ns */
> + gpiod_set_value(aic31xx->gpio_reset, 0);

_cansleep(), this isn't being done from interrupt context.

> + } else {
> + ret = regmap_write(aic31xx->regmap, AIC31XX_RESET, 1);
> + if (ret < 0)
> + dev_err(aic31xx->dev, "Could not reset device\n");

Print the error to help people doing debug.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]