From mboxrd@z Thu Jan 1 00:00:00 1970 From: Segher Boessenkool Subject: Re: [PATCH 04/11] of/flattree: eliminate cell_t typedef Date: Thu, 26 Nov 2009 22:36:41 +0100 Message-ID: References: <20091124081316.6216.66310.stgit@angua> <20091124081827.6216.1896.stgit@angua> <1259207974.16367.226.camel@pasglop> <1259213266.16367.274.camel@pasglop> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1259213266.16367.274.camel@pasglop> Sender: sparclinux-owner@vger.kernel.org To: Benjamin Herrenschmidt Cc: Grant Likely , sfr@canb.auug.org.au, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net List-Id: devicetree@vger.kernel.org >> You're right, it's not, but makes merging less complex, and then I >> can >> refactor properly. > > Still, make them __be32 at least There is no alignment guarantee at all either, better make it all u8 and use accessor functions everywhere. Segher