From: Vijay Khemka <vijaykhemka@fb.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Jiri Kosina <trivial@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Patrick Venture <venture@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Anson Huang <anson.huang@nxp.com>,
Jeremy Gebben <jgebben@sweptlaser.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"openbmc @ lists . ozlabs . org" <openbmc@lists.ozlabs.org>,
Joel Stanley <joel@jms.id.au>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
Sai Dasari <sdasari@fb.com>
Subject: Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device
Date: Tue, 23 Jul 2019 17:13:49 +0000 [thread overview]
Message-ID: <F7BAC53E-925E-4FA4-815D-ACB82DF8D240@fb.com> (raw)
In-Reply-To: <CAL_Jsq+Kw0TFW_v54Y2QHcChqpNDYhFyCSO5Cj-be9yLSCq-Pw@mail.gmail.com>
On 7/23/19, 7:53 AM, "Rob Herring" <robh+dt@kernel.org> wrote:
On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <vijaykhemka@fb.com> wrote:
> >
> > The pxe1610 is a voltage regulator from Infineon. It also supports
> > other VRs pxe1110 and pxm1310 from Infineon.
What happened to the other compatibles? S/w doesn't need to know the
differences?
As far as driver is concerned, it doesn't need to know differences.
> >
> > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> > ---
> > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 2e742d399e87..1be648828a31 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -99,6 +99,8 @@ properties:
> > # Infineon IR38064 Voltage Regulator
> > - infineon,ir38064
> > # Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
> > + - infineon,pxe1610
> > + # Infineon PXE1610, PXE1110 and PXM1310 Voltage Regulators
>
> The comment goes above the entry.
>
> > - infineon,slb9635tt
> > # Infineon SLB9645 I2C TPM (new protocol, max 400khz)
> > - infineon,slb9645tt
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2019-07-23 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 0:20 [PATCH] dt-bindings: Add pxe1610 as a trivial device Vijay Khemka
2019-07-23 2:18 ` Joel Stanley
2019-07-23 14:50 ` Rob Herring
2019-07-23 14:52 ` Rob Herring
2019-07-23 17:13 ` Vijay Khemka [this message]
2019-08-02 6:31 ` Joel Stanley
2019-08-06 20:35 ` Vijay Khemka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7BAC53E-925E-4FA4-815D-ACB82DF8D240@fb.com \
--to=vijaykhemka@fb.com \
--cc=anson.huang@nxp.com \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jgebben@sweptlaser.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=sdasari@fb.com \
--cc=trivial@kernel.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox