From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1889C4332F for ; Tue, 1 Nov 2022 20:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230071AbiKAUbo (ORCPT ); Tue, 1 Nov 2022 16:31:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbiKAUbn (ORCPT ); Tue, 1 Nov 2022 16:31:43 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0D251CFC9; Tue, 1 Nov 2022 13:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1667334698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OnhnDCARi1SHGfCOfq1wUCr5JDb84bNveYmRAJuiXeQ=; b=CtDS//rGDFIqK8Hw6/xNTRXwLJ94vLlvhho1KiuNJN4BoA4Trk7wkkNNhVMGl9xjizpE7c 6FSsJH9ungA/Oein3L9MOUrzFXP83d67P3AdB12lHtEN4dCVPZnff1+KmbhuaUmP4kf+Ps LsAT/GEYQ2lVodMHXKocBpRG5eVbyYI= Date: Tue, 01 Nov 2022 20:31:28 +0000 From: Paul Cercueil Subject: Re: [PATCH v6 3/3] clk: Add Ingenic JZ4755 CGU driver To: Stephen Boyd Cc: Siarhei Volkau , Siarhei Volkau , Michael Turquette , Rob Herring , Krzysztof Kozlowski , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Message-Id: In-Reply-To: <20221101192216.5EE5DC433D6@smtp.kernel.org> References: <20221027192024.484320-1-lis8215@gmail.com> <20221027192024.484320-4-lis8215@gmail.com> <20221027215716.77250C433D6@smtp.kernel.org> <20221101192216.5EE5DC433D6@smtp.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Stephen, Le mar. 1 nov. 2022 =C3=A0 12:22:14 -0700, Stephen Boyd =20 a =C3=A9crit : > Quoting Paul Cercueil (2022-10-28 00:48:35) >> Hi Stephen, >>=20 >> Le jeu. 27 oct. 2022 =EF=BF=BD 14:57:14 -0700, Stephen Boyd=20 >> >> a =EF=BF=BDcrit : >> > Quoting Siarhei Volkau (2022-10-27 12:20:23) >> >> diff --git a/drivers/clk/ingenic/jz4755-cgu.c >> >> b/drivers/clk/ingenic/jz4755-cgu.c >> >> new file mode 100644 >> >> index 000000000..d2eb3ae0c >> >> --- /dev/null >> >> +++ b/drivers/clk/ingenic/jz4755-cgu.c >> >> @@ -0,0 +1,346 @@ >> > [...] >> >> +static void __init jz4755_cgu_init(struct device_node *np) >> >> +{ >> >> + int retval; >> >> + >> >> + cgu =3D ingenic_cgu_new(jz4755_cgu_clocks, >> >> + ARRAY_SIZE(jz4755_cgu_clocks),=20 >> np); >> >> + if (!cgu) { >> >> + pr_err("%s: failed to initialise CGU\n",=20 >> __func__); >> >> + return; >> >> + } >> >> + >> >> + retval =3D ingenic_cgu_register_clocks(cgu); >> >> + if (retval) >> >> + pr_err("%s: failed to register CGU Clocks\n", >> >> __func__); >> >> + >> >> + ingenic_cgu_register_syscore_ops(cgu); >> >> +} >> >> +CLK_OF_DECLARE_DRIVER(jz4755_cgu, "ingenic,jz4755-cgu", >> >> jz4755_cgu_init); >> > >> > Is there another driver that probes this device? >> > CLK_OF_DECLARE_DRIVER() >> > is for the situation where we want to probe this device again with >> > another platform driver. Please add a comment indicating what that >> > other >> > driver is. >>=20 >> See: 03d570e1a4dc ("clk: ingenic: Use CLK_OF_DECLARE_DRIVER macro") >>=20 >=20 > Does that mean this is also a simple-mfd? Yes - there's the USB PHY registers randomly in the middle of the=20 clocks IP. -Paul