From: Martin Botka <martin.botka@somainline.org>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: martin.botka1@gmail.com,
Konrad Dybcio <konrad.dybcio@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Jami Kettunen <jamipkettunen@somainline.org>,
Paul Bouchara <paul.bouchara@somainline.org>,
Jan Trmal <jtrmal@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Andre Przywara <andre.przywara@arm.com>,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/3] mfd: axp20x: Add support for AXP313a PMIC
Date: Tue, 28 Feb 2023 22:11:09 +0100 [thread overview]
Message-ID: <LU6TQR.1KVYI23YNZDD3@somainline.org> (raw)
In-Reply-To: <TY3P286MB261112915A6811BB91E8DE6C98A69@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
Hi Shengyu
On Sun, Feb 19 2023 at 01:52:50 AM +08:00:00, Shengyu Qu
<wiagn233@outlook.com> wrote:
> Hi Martin,
>> +static const struct regmap_range axp313a_writeable_ranges[] = {
>> + regmap_reg_range(AXP313A_ON_INDICATE, AXP313A_IRQ_STATE),
> No, according to datasheet, 0x00 reg is read-only.
>> +};
>> +
>> +static const struct regmap_range axp313a_volatile_ranges[] = {
>> + regmap_reg_range(AXP313A_ON_INDICATE, AXP313A_IRQ_STATE),
>
> As Tsai said, no meaning to set all register to volatile.
ack
>
> Also, please check the datasheet I metioned in part3 reply, seems its
> newer than yours.
ack
>
> Best regards,
>
> Shengyu
>
Best regards,
Martin
next prev parent reply other threads:[~2023-02-28 21:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 18:44 [PATCH v8 0/3] regulator: Add X-Powers AXP313a PMIC support* Martin Botka
2023-01-20 18:44 ` [PATCH v8 1/3] dt-bindings: mfd: x-powers,axp152: Document the AXP313a variant Martin Botka
2023-01-20 18:51 ` Martin Botka
2023-01-27 17:10 ` Chen-Yu Tsai
2023-01-20 18:44 ` [PATCH v8 2/3] mfd: axp20x: Add support for AXP313a PMIC Martin Botka
2023-01-27 17:40 ` Chen-Yu Tsai
2023-03-23 13:59 ` Andre Przywara
2023-03-23 14:24 ` Chen-Yu Tsai
2023-02-18 17:52 ` Shengyu Qu
2023-02-28 21:11 ` Martin Botka [this message]
2023-01-20 18:44 ` [PATCH v8 3/3] regulator: axp20x: Add support for AXP313a variant Martin Botka
2023-01-27 17:24 ` Chen-Yu Tsai
2023-02-18 10:08 ` Shengyu Qu
2023-02-28 21:09 ` Martin Botka
2023-03-23 13:59 ` Andre Przywara
2023-03-23 14:21 ` Chen-Yu Tsai
2023-03-23 16:07 ` Andre Przywara
2023-03-23 16:18 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LU6TQR.1KVYI23YNZDD3@somainline.org \
--to=martin.botka@somainline.org \
--cc=andre.przywara@arm.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=jernej.skrabec@gmail.com \
--cc=jtrmal@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka1@gmail.com \
--cc=paul.bouchara@somainline.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox