devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi
       [not found] ` <f8393f75-ff32-4450-b8d6-b08d43240200@lunn.ch>
@ 2023-05-30 15:41   ` Ben Schneider
  2023-05-31  9:20     ` Gregory CLEMENT
  0 siblings, 1 reply; 6+ messages in thread
From: Ben Schneider @ 2023-05-30 15:41 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Linux Arm Kernel, Gregory Clement, Sebastian Hesselbarth,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Devicetree,
	Linux Kernel

May 29, 2023, 16:07 by andrew@lunn.ch:

> Please Cc: the maintainers:
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Sorry! Maintainers cc'd.

Ben


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi
  2023-05-30 15:41   ` [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi Ben Schneider
@ 2023-05-31  9:20     ` Gregory CLEMENT
  2023-05-31 15:47       ` Ben Schneider
  0 siblings, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2023-05-31  9:20 UTC (permalink / raw)
  To: Ben Schneider, Andrew Lunn
  Cc: Linux Arm Kernel, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Devicetree, Linux Kernel

Hello Ben Schneider,

> May 29, 2023, 16:07 by andrew@lunn.ch:
>
>> Please Cc: the maintainers:
>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Sorry! Maintainers cc'd.

I don't see the patch so I can't apply it...

Gregory

>
> Ben
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi
  2023-05-31  9:20     ` Gregory CLEMENT
@ 2023-05-31 15:47       ` Ben Schneider
  2023-06-02  7:02         ` Gregory CLEMENT
  0 siblings, 1 reply; 6+ messages in thread
From: Ben Schneider @ 2023-05-31 15:47 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Andrew Lunn, Linux Arm Kernel, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Devicetree, Linux Kernel

May 31, 2023, 09:20 by gregory.clement@bootlin.com:

>
> I don't see the patch so I can't apply it...
>
>
Hi Gregory, sorry I wasn't sure if I should resend the patch.

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
vcc_sd1 had been disabled. The device manufacturer patched this issue in
their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
but not the EspressoBIN Ultra. Removing the device from the tree fixes
the boot hang and wifi.

Link: https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06

Signed-off-by: Ben Schneider <ben@bens.haus>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
index d29d2da95..f9abef8dc 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
@@ -24,6 +24,8 @@
                ethernet5 = &switch0port4;
        };
 
+       /delete-node/ regulator;
+
        reg_usb3_vbus: usb3-vbus {
                compatible = "regulator-fixed";
                regulator-name = "usb3-vbus";
@@ -66,6 +68,7 @@
};
 
&sdhci1 {
+       /delete-property/ vqmmc-supply;
        status = "disabled";
};

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi
  2023-05-31 15:47       ` Ben Schneider
@ 2023-06-02  7:02         ` Gregory CLEMENT
  2023-06-03  5:23           ` Ben Schneider
  0 siblings, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2023-06-02  7:02 UTC (permalink / raw)
  To: Ben Schneider
  Cc: Andrew Lunn, Linux Arm Kernel, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Devicetree, Linux Kernel

Ben Schneider <ben@bens.haus> writes:

> May 31, 2023, 09:20 by gregory.clement@bootlin.com:
>
>>
>> I don't see the patch so I can't apply it...
>>
>>
> Hi Gregory, sorry I wasn't sure if I should resend the patch.


Thanks however it is still not applicable, could you send with git-send
email ?

>
> Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
> vcc_sd1 had been disabled. The device manufacturer patched this issue in
> their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
> but not the EspressoBIN Ultra. Removing the device from the tree fixes
> the boot hang and wifi.
>
> Link: https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06
>
> Signed-off-by: Ben Schneider <ben@bens.haus>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index d29d2da95..f9abef8dc 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -24,6 +24,8 @@
>                 ethernet5 = &switch0port4;
>         };
>  
> +       /delete-node/ regulator;
> +
>         reg_usb3_vbus: usb3-vbus {
>                 compatible = "regulator-fixed";
>                 regulator-name = "usb3-vbus";
> @@ -66,6 +68,7 @@
> };
>  
> &sdhci1 {
> +       /delete-property/ vqmmc-supply;
>         status = "disabled";
> };

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi
  2023-06-02  7:02         ` Gregory CLEMENT
@ 2023-06-03  5:23           ` Ben Schneider
  2023-06-16 12:05             ` Gregory CLEMENT
  0 siblings, 1 reply; 6+ messages in thread
From: Ben Schneider @ 2023-06-03  5:23 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Andrew Lunn, Linux Arm Kernel, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Devicetree, Linux Kernel,
	Ben Schneider

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
vcc_sd1 had been disabled. The device manufacturer patched this issue in
their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
but not the EspressoBIN Ultra. Removing the device from the tree fixes
the boot hang and wifi.

Signed-off-by: Ben Schneider <ben@bens.haus>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
index d29d2da95..f9abef8dc 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
@@ -24,6 +24,8 @@
 		ethernet5 = &switch0port4;
 	};
 
+	/delete-node/ regulator;
+
 	reg_usb3_vbus: usb3-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb3-vbus";
@@ -66,6 +68,7 @@
 };
 
 &sdhci1 {
+	/delete-property/ vqmmc-supply;
 	status = "disabled";
 };
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi
  2023-06-03  5:23           ` Ben Schneider
@ 2023-06-16 12:05             ` Gregory CLEMENT
  0 siblings, 0 replies; 6+ messages in thread
From: Gregory CLEMENT @ 2023-06-16 12:05 UTC (permalink / raw)
  To: Ben Schneider
  Cc: Andrew Lunn, Linux Arm Kernel, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Devicetree, Linux Kernel,
	Ben Schneider

Ben Schneider <bschnei@gmail.com> writes:

> Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
> vcc_sd1 had been disabled. The device manufacturer patched this issue in
> their kernel fork noting that vcc_sd1 is used by the EspressoBIN model
> but not the EspressoBIN Ultra. Removing the device from the tree fixes
> the boot hang and wifi.
>
> Signed-off-by: Ben Schneider <ben@bens.haus>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Applied on mvebu/dt64

Thanks,

Gregory
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index d29d2da95..f9abef8dc 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -24,6 +24,8 @@
>  		ethernet5 = &switch0port4;
>  	};
>  
> +	/delete-node/ regulator;
> +
>  	reg_usb3_vbus: usb3-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "usb3-vbus";
> @@ -66,6 +68,7 @@
>  };
>  
>  &sdhci1 {
> +	/delete-property/ vqmmc-supply;
>  	status = "disabled";
>  };
>  
> -- 
> 2.17.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-06-16 12:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <NWNpfIn--3-9@bens.haus>
     [not found] ` <f8393f75-ff32-4450-b8d6-b08d43240200@lunn.ch>
2023-05-30 15:41   ` [PATCH] arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi Ben Schneider
2023-05-31  9:20     ` Gregory CLEMENT
2023-05-31 15:47       ` Ben Schneider
2023-06-02  7:02         ` Gregory CLEMENT
2023-06-03  5:23           ` Ben Schneider
2023-06-16 12:05             ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).