From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A744C55199 for ; Sun, 26 Apr 2020 12:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 492D92071C for ; Sun, 26 Apr 2020 12:57:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="AbMvu2fR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbgDZM5H (ORCPT ); Sun, 26 Apr 2020 08:57:07 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:43060 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbgDZM5F (ORCPT ); Sun, 26 Apr 2020 08:57:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1587905821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VP/mAC4xwNDT9V91K8RLHYB6nE7AooWd1wTlk6uRfp4=; b=AbMvu2fRXjCFm6r4XAiK02os0W+/STwoQ44/jocLsIYNNVAtsKI7bA90aQ74cVvhs5lLan y4d+F5TbWTAuE/jofT7aZmiSn7uZjLRQedgWMMNrNJZDpCXraPxAcOa+Dvq1A+6VE+7OU/ EEEX6kOGv5zhpzoTKdy5z9BpNqSjfRo= Date: Sun, 26 Apr 2020 14:56:47 +0200 From: Paul Cercueil Subject: Re: [PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540 To: "H. Nikolaus Schaller" Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?iso-8859-1?q?Beno=EEt?= Cousson , Tony Lindgren , Ralf Baechle , Paul Burton , James Hogan , Kukjin Kim , Krzysztof Kozlowski , Maxime Ripard , Chen-Yu Tsai , Thomas Bogendoerfer , Jonathan Bakker , Philipp Rossak , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, openpvrsgx-devgroup@letux.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Message-Id: In-Reply-To: <3fd18c747426e15fd1f3500b9c4adce2db9ddd0c.1587760454.git.hns@goldelico.com> References: <3fd18c747426e15fd1f3500b9c4adce2db9ddd0c.1587760454.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Le ven. 24 avril 2020 =E0 22:34, H. Nikolaus Schaller=20 a =E9crit : > From: Jonathan Bakker >=20 > All s5pv210 devices have a PowerVR SGX 540 (revision 120) attached. >=20 > There is no external regulator for it so it can be enabled by default. >=20 > Signed-off-by: Jonathan Bakker > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/s5pv210.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/s5pv210.dtsi=20 > b/arch/arm/boot/dts/s5pv210.dtsi > index 2ad642f51fd9..abbdda205c1b 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -512,6 +512,19 @@ vic3: interrupt-controller@f2300000 { > #interrupt-cells =3D <1>; > }; >=20 > + gpu: gpu@f3000000 { > + compatible =3D "samsung,s5pv210-sgx540-120"; > + reg =3D <0xf3000000 0x10000>; > + interrupt-parent =3D <&vic2>; > + interrupts =3D <10>; > + clock-names =3D "core"; > + clocks =3D <&clocks CLK_G3D>; > + > + assigned-clocks =3D <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > + assigned-clock-rates =3D <0>, <66700000>; > + assigned-clock-parents =3D <&clocks MOUT_MPLL>; What are these clocks for, and why are they reparented / reclocked? Shouldn't they be passed to 'clocks' as well? -Paul > + }; > + > fimd: fimd@f8000000 { > compatible =3D "samsung,s5pv210-fimd"; > interrupt-parent =3D <&vic2>; > -- > 2.25.1 >=20