From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guennadi Liakhovetski Subject: Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2 Date: Wed, 17 Apr 2013 16:07:49 +0200 (CEST) Message-ID: References: <201304021630.13371.arnd@arndb.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-media-owner@vger.kernel.org To: Arnd Bergmann Cc: devicetree-discuss@lists.ozlabs.org, Linux Media Mailing List , Rob Herring , Sylwester Nawrocki , Grant Likely List-Id: devicetree@vger.kernel.org Hi all On Tue, 2 Apr 2013, Guennadi Liakhovetski wrote: > On Tue, 2 Apr 2013, Arnd Bergmann wrote: > > > On Tuesday 02 April 2013, Guennadi Liakhovetski wrote: > > > Currently modular V4L2 build with enabled OF is broken dur to the > > > of_get_next_parent() function being unavailable to modules. Export it to > > > fix the build. > > > > > > Cc: Sylwester Nawrocki > > > Signed-off-by: Guennadi Liakhovetski > > > > Looks good to me, but shouldn't this be EXPORT_SYMBOL_GPL? > > "grep EXPORT_SYMBOL drivers/of/base.c" doesn't give a certain answer, but > it seems to fit other of_get_* functions pretty well: Ping, could this patch be pushed to -next asap, please? Without it the current V4L2 -next doesn't compile. Also, I think, ro avoid breaking the mainline, we should try to have this patch pulled in before the media tree, could that be done? Thanks Guennadi > EXPORT_SYMBOL(of_get_parent); > +EXPORT_SYMBOL(of_get_next_parent); > EXPORT_SYMBOL(of_get_next_child); > EXPORT_SYMBOL(of_get_next_available_child); > EXPORT_SYMBOL(of_get_child_by_name); --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/