From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
To: Vincent Cloutier <vincent.cloutier@icloud.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
imx@lists.linux.dev, linux-kernel@vger.kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, daniel.baluta@nxp.com, shawnguo@kernel.org,
agx@sigxcpu.org, angus@akkea.ca,
Vincent Cloutier <vincent@cloutier.co>
Subject: Re: [PATCH v1 4/4] arm64: dts: imx8mq-librem5: Set BQ25895 input voltage limit
Date: Sat, 03 Oct 2026 03:08:50 +0200 [thread overview]
Message-ID: <TUmf9Hq_Txaw7MkIttVh3Q@puri.sm> (raw)
In-Reply-To: <20260927145538.233548-5-vincent.cloutier@icloud.com>
[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]
On niedziela, 27 września 2026 16:55:38 czas środkowoeuropejski letni Vincent
Cloutier wrote:
> From: Vincent Cloutier <vincent@cloutier.co>
>
> Purism's production Librem 5 kernels used a 3.9 V absolute VINDPM
> threshold for years,
...because it was (likely accidentally) left over from the devkit dts where it
was genuinely needed.
> from the 2019 board support through the releases
> preceding the March 2026 charging update.
...which is when it was changed because it was found to be the cause of issues
due to interactions between TPS65982 and BQ25895 cut-off limits observed when
used with power sources that struggle to provide the required voltage when
under load.
> Use this established board
> setting for the BQ25895 input voltage limit.
Why? What makes you want to bring the bad value upstream?
> Set input-voltage-limit-microvolt to 3900000 to select absolute VINDPM
> and program the 3.9 V threshold through the generic binding.
>
> Tested on Librem 5r4: REG0D remained 0x8d across an attached boot, unplug,
> and flipped replug.
>
> Assisted-by: OpenCode:gpt-5.6-sol
> Assisted-by: OpenCode:gpt-6-astra
> Signed-off-by: Vincent Cloutier <vincent@cloutier.co>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi index
> 099195279e84..8badebfcdbb4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -1195,6 +1195,7 @@ bq25895: charger@6a {
> pinctrl-0 = <&pinctrl_charger_in>;
> interrupt-parent = <&gpio3>;
> interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> + input-voltage-limit-microvolt = <3900000>;
> ti,battery-regulation-voltage = <4208000>; /* uV */
> ti,termination-current = <128000>; /* uA */
> ti,precharge-current = <128000>; /* uA */
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-10-03 1:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 14:55 [PATCH v1 0/4] power: supply: bq25890: add input voltage limit Vincent Cloutier
2026-09-27 14:55 ` [PATCH v1 1/4] arm64: dts: imx8mq-librem5: Remove invalid monitored-battery Vincent Cloutier
2026-09-27 14:55 ` [PATCH v1 2/4] dt-bindings: power: supply: bq25890: Add input voltage limit Vincent Cloutier
2026-09-28 16:42 ` Conor Dooley
2026-09-27 14:55 ` [PATCH v1 3/4] " Vincent Cloutier
2026-09-27 15:06 ` sashiko-bot
2026-09-27 14:55 ` [PATCH v1 4/4] arm64: dts: imx8mq-librem5: Set BQ25895 " Vincent Cloutier
2026-10-03 1:08 ` Sebastian Krzyszkowiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TUmf9Hq_Txaw7MkIttVh3Q@puri.sm \
--to=sebastian.krzyszkowiak@puri.sm \
--cc=Frank.Li@nxp.com \
--cc=agx@sigxcpu.org \
--cc=angus@akkea.ca \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=vincent.cloutier@icloud.com \
--cc=vincent@cloutier.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox