From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Simon Ser <contact@emersion.fr>,
devicetree <devicetree@vger.kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support
Date: Tue, 5 Jan 2021 16:00:17 +0100 [thread overview]
Message-ID: <X/R/AY7YXBEyWNG1@aptenodytes> (raw)
In-Reply-To: <CAKb7UvhgHPkG5Sn-HLdpsFw0R=kATJKUmjSwPSuwviDCk0RGyw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1794 bytes --]
Hi,
On Wed 23 Dec 20, 18:31, Ilia Mirkin wrote:
> FWIW this is something I added, hoping it was going to get used at
> some point, but I never followed up with support in xf86-video-nouveau
> for Xv. At this point, I'm not sure I ever will. I encoded the
> "enabled" part into the value with a high bit (1<<24) -- not sure that
> was such a great idea. All NVIDIA hardware supports colorkey (and not
> actual alpha, until the very latest GPUs - Volta/Turing families),
> although my implementation only covers the pre-G80 series (i.e. DX9
> and earlier GPUs - pre-2008). Should a determination of usefulness be
> reached, it would be easy to implement on the remainder though.
Interesting to know!
Regarding a generic colorkey property, there was a discussion under thread:
drm: Add generic colorkey properties for display planes
and the latest proposal (RFC v4) can be found here:
https://patchwork.ozlabs.org/project/linux-tegra/patch/20180807172202.1961-2-digetx@gmail.com/
It looks like this was much more complex than anticipated and the series
was more or less abandonned. I didn't feel like picking it up in my logicvc
series so I kept the colorkey patch as not for merge.
If someone's up for picking the proposal and continuing the discussion,
I could provide insight on how it would fit with logicvc though!
Cheers,
Paul
> On Wed, Dec 23, 2020 at 5:20 PM Simon Ser <contact@emersion.fr> wrote:
> >
> > nouveau already has something for colorkey:
> > https://drmdb.emersion.fr/properties/4008636142/colorkey
> >
> > I know this is marked "not for merge", but it would be nice to discuss
> > with them and come up with a standardized property.
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-01-05 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 21:29 [PATCH v8 0/4] drm: LogiCVC display controller support Paul Kocialkowski
2020-12-23 21:29 ` [PATCH v8 1/4] dt-bindings: display: Document the Xylon LogiCVC display controller Paul Kocialkowski
2020-12-24 17:01 ` Rob Herring
2020-12-25 12:29 ` Paul Kocialkowski
2021-01-12 15:17 ` Rob Herring
2021-09-14 19:23 ` Paul Kocialkowski
2021-10-13 14:14 ` Geert Uytterhoeven
2020-12-23 21:29 ` [PATCH v8 2/4] dt-bindings: mfd: logicvc: Add patternProperties for the display Paul Kocialkowski
2020-12-23 21:29 ` [PATCH v8 3/4] drm: Add support for the LogiCVC display controller Paul Kocialkowski
2020-12-23 21:29 ` [PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support Paul Kocialkowski
2020-12-23 22:20 ` Simon Ser
2020-12-23 23:31 ` Ilia Mirkin
2021-01-05 15:00 ` Paul Kocialkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/R/AY7YXBEyWNG1@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=airlied@linux.ie \
--cc=contact@emersion.fr \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).