From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: conor.dooley@microchip.com
Cc: robh+dt@kernel.org, damien.lemoal@wdc.com,
jassisinghbrar@gmail.com, aou@eecs.berkeley.edu,
paul.walmsley@sifive.com, palmer@dabbelt.com,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
cyril.jean@microchip.com, david.abdurachmanov@gmail.com,
daire.mcnamara@microchip.com, anup.patel@wdc.com,
j.neuschaefer@gmx.net, atish.patra@wdc.com,
lewis.hanly@microchip.com
Subject: Re: [PATCH v3 3/5] soc: add polarfire soc system controller
Date: Tue, 5 Jan 2021 23:14:02 +0100 [thread overview]
Message-ID: <X/TkquplML5INtZg@latitude> (raw)
In-Reply-To: <20201223163310.29122-1-conor.dooley@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 2050 bytes --]
Hello,
On Wed, Dec 23, 2020 at 04:33:10PM +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> This driver provides an interface for other drivers to access the
> functions of the system controller on the Microchip PolarFire SoC.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
[...]
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -14,6 +14,7 @@ obj-$(CONFIG_ARCH_GEMINI) += gemini/
> obj-y += imx/
> obj-$(CONFIG_ARCH_IXP4XX) += ixp4xx/
> obj-$(CONFIG_SOC_XWAY) += lantiq/
> +obj-$(CONFIG_SOC_MICROCHIP_POLARFIRE) += microchip/
CONFIG_SOC_MICROCHIP_POLARFIRE is more specific than a flag guarding
the microchip directory should (intuitively) be (because there may be
Microchip SoCs that are not Microchip PolarFire). Fortunately, since
mpfs-sys-controller.o itself is guarded by CONFIG_POLARFIRE_SOC_SYS_CTRL,
using "obj-y += microchip/" here should work without a problem.
[...]
> +int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, void *msg,
> + void *response, u16 response_size_bytes)
> +{
> + int ret;
> +
> + mpfs_client->response = response;
> + mpfs_client->response_size_bytes = response_size_bytes;
> +
> + mutex_lock_interruptible(&transaction_lock);
> +
> + reinit_completion(&mpfs_client->c);
> +
> + ret = mbox_send_message(mpfs_client->chan, msg);
> + if (ret >= 0) {
> + if (wait_for_completion_timeout(&mpfs_client->c, HZ)) {
> + ret = 0;
> + } else {
> + ret = -ETIMEDOUT;
> + dev_warn(mpfs_client->client.dev, "MPFS sys controller transaction timeout");
\n is missing
> + }
> + } else {
> + dev_err(mpfs_client->client.dev,
> + "mpfs sys controller transaction returned %d\r\n", ret);
\r\n is quite unusual and probably unnecessary in printk-style
functions, \n is enough.
> + }
> +
> + mutex_unlock(&transaction_lock);
> +
> + return ret;
> +}
> +EXPORT_SYMBOL(mpfs_blocking_transaction);
Best regards,
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-01-05 22:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 16:33 [PATCH v3 3/5] soc: add polarfire soc system controller conor.dooley
2021-01-05 22:14 ` Jonathan Neuschäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/TkquplML5INtZg@latitude \
--to=j.neuschaefer@gmx.net \
--cc=anup.patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=conor.dooley@microchip.com \
--cc=cyril.jean@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=damien.lemoal@wdc.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).