From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD0CC433DB for ; Fri, 8 Jan 2021 18:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CDED23A7F for ; Fri, 8 Jan 2021 18:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728756AbhAHSwC (ORCPT ); Fri, 8 Jan 2021 13:52:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728731AbhAHSwB (ORCPT ); Fri, 8 Jan 2021 13:52:01 -0500 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C44EC0612EA for ; Fri, 8 Jan 2021 10:51:21 -0800 (PST) Received: by mail-oi1-x22d.google.com with SMTP id s75so12460669oih.1 for ; Fri, 08 Jan 2021 10:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yw5HNg0k9iL0QHuBnpeVEeXpmsT4zEnK0I09kWNg4VE=; b=spizBsCeh+YYB8W/IjGWwKrI/pXPx7LjOWGRXUcobQCpcJMuzvvYSXwo/EUa60JsKT xqqpQg4cjhZTH3RiJqykwYB5TPKMG3wEe0UkatR6OMwlSzLhFhWQ7C5dtU48nbJrSKuA i12Iez9VdRCHBrGjzjmgpQVRFfYvRqKSjMbLJJ0VzJpMcDzFPeXDsaOveDGSICugouUo Z+sIbi1pyYQzxa8XJBt2RvP06WF+GlIikHxSNNWOfi2IN9S8N9GIYZsKyBs/rk+OLHrS OWaqkXnzAY57hM6ps5KH9eaPJDojhSVPE7TJduuFCQ8KoUOUFfaqlRYYdoJZaO+x0q4B NzXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yw5HNg0k9iL0QHuBnpeVEeXpmsT4zEnK0I09kWNg4VE=; b=eSidDU9N8c2v5zYnh+U5S3zw6MymRHI/1X0U6o8TnqvhKExHvBKjnDufujjiHWxbd/ xOkKJGcib8b+oHEv9OlHVeZ5biHDRNEHzUzzlTsUIJI8BY1z8rq11anyeLhqRncE53yu stURhok2zsd+FrEWc7gv+MVNu23JuR+cfF07YwLTwrvi22k38QWN8AsMu7UQ3FPim8DF 0KyjOcI7glJ8S/BhncpW6V0kA6eALLpiUj9GjUXMiFp3/edpdlwK5qagf2nz4V0Xn0WB DJyt2CU+Ozwg5p6hDB0S0e4wSWrKYZdUsjbK0z2Ph7mBv12A0OA/WHm6k7ig1gi0wJuT pUlw== X-Gm-Message-State: AOAM532dBzn/bwRFeKzKluDz4mnYqU8O+ciaNX+md3zEvCnFRfAc7yNY IkRJ4vBilY1XsBWMDOfL3jTHew== X-Google-Smtp-Source: ABdhPJxR70l+gieQE6A1jIIhmWfNLp4ron556Hy+l+ahoezA8S0Np6gHH+AXBp6x7HPJr+JKligh/g== X-Received: by 2002:aca:b657:: with SMTP id g84mr3289190oif.86.1610131880733; Fri, 08 Jan 2021 10:51:20 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h11sm1907017ooj.36.2021.01.08.10.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 10:51:19 -0800 (PST) Date: Fri, 8 Jan 2021 12:51:18 -0600 From: Bjorn Andersson To: Robert Foss Cc: agross@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, leoyang.li@nxp.com, geert+renesas@glider.be, arnd@arndb.de, Anson.Huang@nxp.com, michael@walle.cc, agx@sigxcpu.org, max.oss.09@gmail.com, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrey Konovalov , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart Subject: Re: [PATCH v1 01/17] media: camss: Fix comment using wrong function name Message-ID: References: <20210108120429.895046-1-robert.foss@linaro.org> <20210108120429.895046-2-robert.foss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210108120429.895046-2-robert.foss@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 08 Jan 06:04 CST 2021, Robert Foss wrote: > Function name is comment is wrong, and was changed to be > the same as the actual function name. > > Signed-off-by: Robert Foss > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index fae2b513b2f9..478be4f0cab5 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -1077,7 +1077,7 @@ static void vfe_isr_wm_done(struct vfe_device *vfe, u8 wm) > } > > /* > - * vfe_isr_wm_done - Process composite image done interrupt > + * vfe_isr_comp_done - Process composite image done interrupt It's a function, so it should be "vfe_isr_comp_done()", but unless the comment is denoted kerneldoc by starting with '/' followed by two '*' it "doesn't matter". As a matter of fact, none of the kerneldoc in this file has the proper '/**' start, so this file is "undocumented". So please add another '*' and some () throughout the file. Regards, Bjorn > * @vfe: VFE Device > * @comp: Composite image id > */ > -- > 2.27.0 >