From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E8CC64E7A for ; Tue, 1 Dec 2020 03:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCAAF20705 for ; Tue, 1 Dec 2020 03:21:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XqI9Urtw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727650AbgLADUr (ORCPT ); Mon, 30 Nov 2020 22:20:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbgLADUq (ORCPT ); Mon, 30 Nov 2020 22:20:46 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0CC8C0613CF for ; Mon, 30 Nov 2020 19:20:06 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id t143so313293oif.10 for ; Mon, 30 Nov 2020 19:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z0jYbSuM2A7vj2WRSnCHpCXmrIAzvssFmwAmhCHBSEo=; b=XqI9UrtwtN+Xkgx9qqN1YpdIsr6BCmdt1rKQKFt7pEhILlu4Pj/Le6iJMF+WhAOETY A1tu2xf189iKGMPNVQECBebYglBbJzmwEg+sSVVHfEoXAdTuiJjBe9Ir8z1j0+R0dVBm HYQ00J7UwnYAqA1Nxdn9nw2wQRdbvPilvYXoE7ioGCITj7zVdzjB4ifT46aDZO0jpKmK nS3jobLJsNm1kfK1FIG4FZQ3M2CMWM6OUMNT3Ltxazz9OI9PAPVgLsAfRYPIEfrWtVkL 1AK5TURlrwTkqXxpvOs46WIIvJFlzFF9U9DyBWq4I9GrSV/nrcJHHLPXazZ3kUH+TfqL vtrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z0jYbSuM2A7vj2WRSnCHpCXmrIAzvssFmwAmhCHBSEo=; b=Ovyi+zBrStESJPrcWVsBVAH+in9VuBKSksY6fBu3f9GttK6CaLKrjsTFewyoAPGHBs M9dhHeGpCGOORSZMI3lMKZhYI/tB+CgKh+kX/fXqDEINw3Yeq/ex5fHzyeJqUTKvBnpl vh/XpdzMm43FUU23O7DCcbKM9vjz0+0s8Cl9Y0sAQdyhbmv9eTh3NFyBaaSuwxfA3maA YTVNPvB5PkgyiK3zbICDqtfQgMW9H8CUc8bhklmun7gVMHi0SgxiBlF/EceySHxG4XSC QO2Fg9Y0bY5lbYepd63a4InH2VZykWqq7q+iMEooz3FB3gUMNwJF8PDuJPfAZODMGx8Y KOOg== X-Gm-Message-State: AOAM533FgLt1g6XVoHg9Sk93OR5JIoxboJa0yU3hsrb7BFqMQgW4sEZZ 0h6CsL+ykgqFx/C0GS4T1kGc0w== X-Google-Smtp-Source: ABdhPJyN6aZnDw4AEl91NWEpYuIybD/5h2IcygpeviYHF8UN9qRx/2maQBrEcAUtwwRmtlRlduj85Q== X-Received: by 2002:aca:fc92:: with SMTP id a140mr603776oii.4.1606792806105; Mon, 30 Nov 2020 19:20:06 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 189sm127035oob.26.2020.11.30.19.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 19:20:05 -0800 (PST) Date: Mon, 30 Nov 2020 21:20:03 -0600 From: Bjorn Andersson To: Vinod Koul Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Add gpi dma node Message-ID: References: <20201130063946.2060317-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130063946.2060317-1-vkoul@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 30 Nov 00:39 CST 2020, Vinod Koul wrote: > This add the device node for gpi_dma0 and gpi_dma1 instances found in > sdm845. > > Signed-off-by: Vinod Koul > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 45 ++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 6465a6653ad9..a6f41678794c 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -1114,6 +1114,28 @@ opp-128000000 { > }; > }; > > + gpi_dma0: dma-controller@800000 { > + #dma-cells = <3>; I know you like dma, but may I have the compatible etc first in the nodes? Perhaps move #dma-cells down by the other dma- properties? > + compatible = "qcom,sdm845-gpi-dma"; > + reg = <0 0x00800000 0 0x60000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + dma-channels = <13>; > + dma-channel-mask = <0xfa>; > + iommus = <&apps_smmu 0x0016 0x0>; > + }; > + > qupv3_id_0: geniqup@8c0000 { > compatible = "qcom,geni-se-qup"; > reg = <0 0x008c0000 0 0x6000>; > @@ -1454,6 +1476,29 @@ uart7: serial@89c000 { > }; > }; > > + gpi_dma1: dma-controller@0xa00000 { > + #dma-cells = <3>; > + compatible = "qcom,sdm845-gpi-dma"; > + reg = <0 0x00a00000 0 0x60000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + dma-channels = <13>; > + dma-channel-mask = <0xfa>; > + iommus = <&apps_smmu 0x06d6 0x0>; > + status = "disabled"; I don't think it's nice to keep gpi_dma0 enabled and gpi_dma1 disabled. Either we do both enabled in sdm845.dtsi or we do both disabled and rely on the boards to enable what they need. Regards, Bjorn > + }; > + > qupv3_id_1: geniqup@ac0000 { > compatible = "qcom,geni-se-qup"; > reg = <0 0x00ac0000 0 0x6000>; > -- > 2.26.2 >