From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B035C8300F for ; Tue, 1 Dec 2020 19:20:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E418120639 for ; Tue, 1 Dec 2020 19:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jvGu+3Q2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392320AbgLATUG (ORCPT ); Tue, 1 Dec 2020 14:20:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388525AbgLATUG (ORCPT ); Tue, 1 Dec 2020 14:20:06 -0500 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC5ACC0613CF for ; Tue, 1 Dec 2020 11:19:25 -0800 (PST) Received: by mail-ot1-x343.google.com with SMTP id z24so2772186oto.6 for ; Tue, 01 Dec 2020 11:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LckDgaqy2Wn4VuU1MAexf+GwPBgKOOjs/09Enf2QqEI=; b=jvGu+3Q2FsjzlBtj5IKsZi6iALz3dK5Xe3RDwwDEe1RT2cUcBSZmgBrAEOUEy0o6h7 Znugijy0meUrqw/tVTge/FAqw7rmxM+jFVbXFXnewASdmgRQGEazt0bvEfji8750r+Tf zpINcxzekeIzYml0kcdkNaQ48tq+QTDU7oQoplnoj/QcQ5VXENH2vFCv7U3OdurXFpcx 39Tt4JyzaZL28+wB8w3eVpIrtF3s0dU+yYwl4mCZ1uTruwlPZHgywD6y1cMn3mZkLokV 8lvGdixK+43GbWXPwT2HBi77PqcpznA2HnucSvw6FetZzxUPlyvNT27HgMXME4SxGtRv 6BYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LckDgaqy2Wn4VuU1MAexf+GwPBgKOOjs/09Enf2QqEI=; b=f+ZT6viSuE2U9Tp9inGb3889gZs3DUUbQvYvFOEmW5ZbVwuF/QTv+ZGrYTmZd+eZL9 +mHbnLU2TjMNgsrcHq+h8MyOd+/vRk2yeXPYbHQezQ7Gqe+c7tE2yApTi/l0c6GwKA3P 2CsS6Uz+8l3r00aYrbyXHoSWJhOOkPDuXC3/bvWIp09suv6GxdscfkG72Gg962FmWZd4 DxqVMk3Bnlgib/0kKVkeknHXkXel1L0blLKt+52DDHf389Kd9MaIHkQIk1O19uJZV6sn gTDeDoLNlxOUYeYty4eLp+Z5x6bywBrzLl9g2GPdjiZMdOZ8mlUaGIC3LOlwbi18VwEf l9SA== X-Gm-Message-State: AOAM532+iNi3nWb0sdALgwOARR3gRG8nN7mxSMnfG+wPv9Y0xsoXUoXR dN+EFxrXyd2VBLoftSCjp+ag+uy3amITMA== X-Google-Smtp-Source: ABdhPJziF8nfchXr/paN/pGLeZ7h7zcwalH41lLBL6jw9cAaRkTEMDNlDx8yasaAW1upVFR/s15mIw== X-Received: by 2002:a05:6830:1e08:: with SMTP id s8mr2926116otr.144.1606850365226; Tue, 01 Dec 2020 11:19:25 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id u20sm99053oie.56.2020.12.01.11.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 11:19:24 -0800 (PST) Date: Tue, 1 Dec 2020 13:19:22 -0600 From: Bjorn Andersson To: Srinivas Kandagatla Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm8250: add mi2s pinconfs Message-ID: References: <20201201153706.13450-1-srinivas.kandagatla@linaro.org> <20201201153706.13450-6-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201153706.13450-6-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 01 Dec 09:37 CST 2020, Srinivas Kandagatla wrote: > Add primary and tertinary mi2s pinconfs required to get I2S audio. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 98 ++++++++++++++++++++++++++++ > 1 file changed, 98 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 19dd7460e586..a87940e157be 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -1561,6 +1561,9 @@ > }; > }; > > + sound: sound { > + }; > + > usb_1_hsphy: phy@88e3000 { > compatible = "qcom,sm8250-usb-hs-phy", > "qcom,usb-snps-hs-7nm-phy"; > @@ -1884,6 +1887,60 @@ > gpio-ranges = <&tlmm 0 0 180>; > wakeup-parent = <&pdc>; > > + pri_mi2s_sck_active: pri-mi2s-sck-active { > + mux { As in patch 3, please make these state-centric and flatten the inner subnode. > + pins = "gpio138"; > + function = "mi2s0_sck"; > + }; > + > + config { > + pins = "gpio138"; > + drive-strength = <8>; > + bias-disable; > + output-high; If function is mi2s0_sck is the output value relevant? Or should this be dropped? Regards, Bjorn > + }; > + }; > + > + pri_mi2s_ws_active: pri-mi2s-ws-active { > + mux { > + pins = "gpio141"; > + function = "mi2s0_ws"; > + }; > + > + config { > + pins = "gpio141"; > + drive-strength = <8>; > + output-high; > + }; > + }; > + > + pri_mi2s_sd0_active: pri-mi2s-sd0-active { > + mux { > + pins = "gpio139"; > + function = "mi2s0_data0"; > + }; > + > + config { > + pins = "gpio139"; > + drive-strength = <8>; > + bias-disable; > + output-high; > + }; > + }; > + > + pri_mi2s_sd1_active: pri-mi2s-sd1-active { > + mux { > + pins = "gpio140"; > + function = "mi2s0_data1"; > + }; > + > + config { > + pins = "gpio140"; > + drive-strength = <8>; > + output-high; > + }; > + }; > + > qup_i2c0_default: qup-i2c0-default { > mux { > pins = "gpio28", "gpio29"; > @@ -2480,6 +2537,47 @@ > function = "qup18"; > }; > }; > + > + tert_mi2s_sck_active: tert-mi2s-sck-active { > + mux { > + pins = "gpio133"; > + function = "mi2s2_sck"; > + }; > + > + config { > + pins = "gpio133"; > + drive-strength = <8>; > + bias-disable; > + output-high; > + }; > + }; > + > + tert_mi2s_sd0_active: tert-mi2s-sd0-active { > + mux { > + pins = "gpio134"; > + function = "mi2s2_data0"; > + }; > + > + config { > + pins = "gpio134"; > + drive-strength = <8>; > + bias-disable; > + output-high; > + }; > + }; > + > + tert_mi2s_ws_active: tert-mi2s-ws-active { > + mux { > + pins = "gpio135"; > + function = "mi2s2_ws"; > + }; > + > + config { > + pins = "gpio135"; > + drive-strength = <8>; > + output-high; > + }; > + }; > }; > > apps_smmu: iommu@15000000 { > -- > 2.21.0 >